From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79BF345E71; Wed, 11 Dec 2024 04:15:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A5CC402E2; Wed, 11 Dec 2024 04:15:01 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 06735402DE for ; Wed, 11 Dec 2024 04:15:00 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-216728b1836so13177215ad.0 for ; Tue, 10 Dec 2024 19:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733886899; x=1734491699; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ppsrK+z9/Vs0gSGSrrTWsnETxyJKFApZ68aKf+n7rs0=; b=PyxAckf8oN23uMpzkY3/EQURerUY0xB3TwAow7H7yb5hsE3fiWMGnIdz86xXCQz7sa NOPs/qrSCt1m9SAM5dVp/FJF3ukNeCN84cl4mqmQZdo+qvS4gLTFIgqWSKTXO1Kc9XcQ 6HNxJ23gOY19GJmF+h8lQoUnTwZFmy3fGWjlRKAIqO1sqaw+K8+NErTmLcVOPWwhSNjp EnFRKHMoDzZxmq0DjC0CQd+wQcZA3o/ezWVnZ782q/zyDT2h86zQQY0aD+lJaEa6hGVG lQvjKl/l/Sx4BRdoF6WwFy/Yd7o/Lsf4zGKtSW21idTb9v5y3rWrh859IhfJ5ltiAx7D SzmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733886899; x=1734491699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ppsrK+z9/Vs0gSGSrrTWsnETxyJKFApZ68aKf+n7rs0=; b=en63b7rJQvBK5CqIWJD/ZDVPwmPLk8QX3N4bWR8D5d74N3cEqCI0QvtB/jeDbuEm1i MtNldfaM5odAfMfanEjznuoNp5XAg2lMlwrqzAoxpjzbAoqI0M4qX91F0/vK6jfesIOC xIxwoSHSwhhGS454MAlNGRrdSb/zf0G96Z3S72bUM+wMgMmc3Zw2KFBkThD19+iX00kR xccHHp4IaxBkOSHa9COO8AWLrax9VzrCgDhxOEmew2wUTauMGHdqNN/kdjsKPCCfY/7G dC12ksngjKo/8WbLbBQbAFFeEHiydZyzR/d76iCryYU7imBhiIxRnsUC8amhQioPQm9x Otfw== X-Gm-Message-State: AOJu0YzSjG4Kqhr43Y+gptcRxLeJux6LnmyCqOQ2TMRsi+YP/Jigb8BO QeIp+kvwZTpPCJjqHuns2y1OG8EeHdLwy4CRGm3jve09wF8Qx3UT9TXPx9ANxD4= X-Gm-Gg: ASbGncsqCUZ381Swu81zB5aiVJG9N6U5E7agkrAIs9CHhjeaBlfhKSVlOEP7I/Xr7a2 7hjU/wzLMkPsK0ScYuIoW+dx/YkKMAwFWYG4R8Z2MqaCiLHGgaRr5Xr8XcMxmvjKb0d3O3PgfyO RBfXnW+r2ez2ktaef6TtD8uc52jfAbrRkrm+N2NW83e+O6efAJZF2sk9xB9YD3d2iH2Yyyf7sHu uoolZHlTYTrO78vXQ/A63E9sHmAHC1K9WejNvP+YhR66dsGxxqJREp6NVpLVGRDge/BSdf+bRe2 FlVO2JpEiMor7bpb2PH5c9M/Htvaf5I= X-Google-Smtp-Source: AGHT+IHtWsKONphKmTst+bE/eDDAeUXmLWQJB3AG2tvu78+dJLNlX24gA+NSz75g4yFVjbt2OFGZ4g== X-Received: by 2002:a17:902:ebc6:b0:216:56d5:d87 with SMTP id d9443c01a7336-217783c757cmr22637115ad.34.1733886899167; Tue, 10 Dec 2024 19:14:59 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2177de1ce9fsm1546055ad.139.2024.12.10.19.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 19:14:58 -0800 (PST) Date: Tue, 10 Dec 2024 19:14:56 -0800 From: Stephen Hemminger To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH 00/21] use portable variadic macros Message-ID: <20241210191456.43d0a35d@hermes.local> In-Reply-To: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Dec 2024 18:05:30 -0800 Andre Muezerie wrote: > 1) Use portable variadic macros > > Many places are using a GCC extension related to variadic macros, > where a name prepends the ellipsis. This results in a warning like > the one below when compiling the code with MSVC: > > app\test-pmd\testpmd.h(1314): error C2608: > invalid token '...' in macro parameter list > > Variadic macros became a standard part of the C language with C99. > GCC, Clang and MSVC handle them properly. > > The fix is to remove the prefix name (args... becomes ...) and use > __VA_ARGS__. Could you add a coccinelle script and/or a checkpatch check to make sure that there are no new usages of ellipsis arg to deal with?