From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2649145E6D;
Tue, 10 Dec 2024 22:28:25 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0E7664026A;
Tue, 10 Dec 2024 22:28:12 +0100 (CET)
Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com
[209.85.210.177])
by mails.dpdk.org (Postfix) with ESMTP id 0807D4029B
for <dev@dpdk.org>; Tue, 10 Dec 2024 22:28:09 +0100 (CET)
Received: by mail-pf1-f177.google.com with SMTP id
d2e1a72fcca58-728e81257bfso728616b3a.2
for <dev@dpdk.org>; Tue, 10 Dec 2024 13:28:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733866089;
x=1734470889; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=VmsUnJf7qBF2iNHCpyXdR33t3dr632ELmFiBctHwTbk=;
b=dq+K8BgSJAG6/Np481RSKoJh0SrurDyZR9mFiIxsekqYw+RbxxgprZgSwc/vRi5Mhs
/AZs+zl9GwOP5TuCGogGspFXGP8GiMvKnNOmYx8ZIK2OrduAEoOpeN+WK0sIaCLq0jk5
oPToN6D8/mFCvIk95fbiK4K98zeaH78VxYBH5zfWiWCXr2odFHCODE+hJmyJ2te3Dpoo
COJhVZi2eZGWkLKKcmuDHpY66WXsEjoc0pb0yVOs6c1D6E3e6SJgjz7+FU54K/tQ8Fsf
FnPHHBWltOlLvZSLpiJaZUruqGV0xhE5XM/pn0MiGMJ4Dq5jDe9pSAW7qgE2cU8bEsk9
yZEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1733866089; x=1734470889;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=VmsUnJf7qBF2iNHCpyXdR33t3dr632ELmFiBctHwTbk=;
b=Rf8UO8jDATW3QIVOzu5jN5ZJFUMNEc4AKznL7BwNDSrmeaVca2cKj4gByr/tpZJjMO
H/kB1+ObMYnd25XYKeY7A6ZPIpyEaN5MvIokGkl5ktLI1iy5/NFRlKA8Q5n5Hl92/P7a
nKxIzvrE9NjtpB0koxFtymoVim9krbnYBseUrT38zBuPsbsMbWVzgkUkoUE8tA/OrfIf
6fiIvNm6iA9Aag9frFlTFzjIQDjAqJNNrj/+gdfdHoSvW7lvIVaWLMeSC4vURvHMQ+EE
JMQo10nZYSZ7ik6yZmWOmh4OWjdcdRH4NhM//fYBL/ITfuGtf5TugcWXdAGylcWkX25C
YLlg==
X-Gm-Message-State: AOJu0YxhjZ54ExsZT+jFKejIvwvhvyvS6wt3T8cg8qG170MwLogTbokf
J4BVY3NGjzx5IBvE4+iuirQiEUSGeH2l66FunDLw74O/4NGwX1JJ7zULnPnXWLGjTmoTGLpnuS4
s
X-Gm-Gg: ASbGncvbhDYUiKyZEzw1ThxBeKfT0/IbX2L2unwgvM1q7bAHorM5G9Hqrg4Xge1n4Rh
tVqQZczJqaHuBda7z6avMJxlYC7YoIgoTUF20VxK8SwFuiOWOpZxbyL8ZnjF4ab0lrZcqyUenGv
/3xfB5pdrk4bRmtqNQJLuW9NizDD7eGA+lx/xUyX6x+V9rbwvWGbOqx8Y533+Xpdhk3KAgGZ6Zr
DiK0UyVtdfDDj9vmN7I+bEgvF399ansnozGew14gOtagwSrh9cjIYSdqrBqYX2WUEHLiNd68Tzt
t8vKcJtqBbEEIeb8znYSAsODrn4SkBY=
X-Google-Smtp-Source: AGHT+IEDLqjjPAN6k8vuu04QzXOCGyZdz3dhXQK9w8Ot4n9ruxJgj7MdEZ2kMlYQb3ReOJRFWhNj8w==
X-Received: by 2002:a05:6a00:3c93:b0:725:e4b9:a600 with SMTP id
d2e1a72fcca58-728ed492ea3mr630923b3a.16.1733866089082;
Tue, 10 Dec 2024 13:28:09 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-725e7c98efbsm4972577b3a.186.2024.12.10.13.28.08
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 10 Dec 2024 13:28:08 -0800 (PST)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [RFC 2/8] net/ioring: implement link state
Date: Tue, 10 Dec 2024 13:23:33 -0800
Message-ID: <20241210212757.83490-3-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241210212757.83490-1-stephen@networkplumber.org>
References: <20241210212757.83490-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add hooks to set kernel link up/down and report state.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
doc/guides/nics/features/ioring.ini | 1 +
drivers/net/ioring/rte_eth_ioring.c | 84 +++++++++++++++++++++++++++++
2 files changed, 85 insertions(+)
diff --git a/doc/guides/nics/features/ioring.ini b/doc/guides/nics/features/ioring.ini
index c4c57caaa4..d4bf70cb4f 100644
--- a/doc/guides/nics/features/ioring.ini
+++ b/doc/guides/nics/features/ioring.ini
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Link status = Y
Linux = Y
x86-64 = Y
Usage doc = Y
diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c
index 7b62c47f54..fa3e748cda 100644
--- a/drivers/net/ioring/rte_eth_ioring.c
+++ b/drivers/net/ioring/rte_eth_ioring.c
@@ -47,6 +47,53 @@ struct pmd_internals {
struct rte_ether_addr eth_addr; /* address assigned by kernel */
};
+static int
+eth_dev_change_flags(struct rte_eth_dev *dev, uint16_t flags, uint16_t mask)
+{
+ struct pmd_internals *pmd = dev->data->dev_private;
+
+ int sock = socket(AF_INET, SOCK_DGRAM, 0);
+ if (sock < 0)
+ return -errno;
+
+ struct ifreq ifr = { };
+ strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ);
+
+ int ret = ioctl(sock, SIOCGIFFLAGS, &ifr);
+ if (ret < 0)
+ goto error;
+
+ /* NB: ifr.ifr_flags is type short */
+ ifr.ifr_flags &= mask;
+ ifr.ifr_flags |= flags;
+
+ ret = ioctl(sock, SIOCSIFFLAGS, &ifr);
+error:
+ close(sock);
+ return (ret < 0) ? -errno : 0;
+}
+
+static int
+eth_dev_get_flags(struct rte_eth_dev *dev, short *flags)
+{
+ struct pmd_internals *pmd = dev->data->dev_private;
+
+ int sock = socket(AF_INET, SOCK_DGRAM, 0);
+ if (sock < 0)
+ return -errno;
+
+ struct ifreq ifr = { };
+ strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ);
+
+ int ret = ioctl(sock, SIOCGIFFLAGS, &ifr);
+ if (ret == 0)
+ *flags = ifr.ifr_flags;
+
+ close(sock);
+ return (ret < 0) ? -errno : 0;
+}
+
+
/* Creates a new tap device, name returned in ifr */
static int
tap_open(const char *name, struct ifreq *ifr, uint8_t persist)
@@ -103,6 +150,39 @@ tap_open(const char *name, struct ifreq *ifr, uint8_t persist)
return -1;
}
+
+static int
+eth_dev_set_link_up(struct rte_eth_dev *dev)
+{
+ return eth_dev_change_flags(dev, IFF_UP, 0);
+}
+
+static int
+eth_dev_set_link_down(struct rte_eth_dev *dev)
+{
+ return eth_dev_change_flags(dev, 0, ~IFF_UP);
+}
+
+static int
+eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
+{
+ struct rte_eth_link *eth_link = &dev->data->dev_link;
+ short flags = 0;
+
+ if (eth_dev_get_flags(dev, &flags) < 0) {
+ PMD_LOG(ERR, "ioctl(SIOCGIFFLAGS): %s", strerror(errno));
+ return -1;
+ }
+
+ *eth_link = (struct rte_eth_link) {
+ .link_speed = RTE_ETH_SPEED_NUM_UNKNOWN,
+ .link_duplex = RTE_ETH_LINK_FULL_DUPLEX,
+ .link_status = (flags & IFF_UP) ? RTE_ETH_LINK_UP : RTE_ETH_LINK_DOWN,
+ .link_autoneg = RTE_ETH_LINK_FIXED,
+ };
+ return 0;
+};
+
static int
eth_dev_close(struct rte_eth_dev *dev)
{
@@ -126,8 +206,12 @@ eth_dev_close(struct rte_eth_dev *dev)
static const struct eth_dev_ops ops = {
.dev_close = eth_dev_close,
+ .link_update = eth_link_update,
+ .dev_set_link_up = eth_dev_set_link_up,
+ .dev_set_link_down = eth_dev_set_link_down,
};
+
static int
ioring_create(struct rte_eth_dev *dev, const char *tap_name, uint8_t persist)
{
--
2.45.2