From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59C3B45E6D;
Tue, 10 Dec 2024 22:28:37 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3B39F4064A;
Tue, 10 Dec 2024 22:28:14 +0100 (CET)
Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com
[209.85.210.182])
by mails.dpdk.org (Postfix) with ESMTP id 7FAF5402E9
for <dev@dpdk.org>; Tue, 10 Dec 2024 22:28:11 +0100 (CET)
Received: by mail-pf1-f182.google.com with SMTP id
d2e1a72fcca58-725ecc42d43so2146056b3a.3
for <dev@dpdk.org>; Tue, 10 Dec 2024 13:28:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733866091;
x=1734470891; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=5i/Otp8vcGDR6l4/RkhpyZHkQ5X9HgD2xvIP/fOfszA=;
b=i/EW4zqMm/P0hFVYpMaSt6O/XrZoUBn6NNtrgcE77XlVDNycWFtHQ6U1Ena28fq4wB
d/ieOUMYCI7pRd6V0yPLBKbz9WDlL/2sb9boBZkIq2ps8GEfBeHfbAVMUv7UAfuk02B1
XXg3YE5Fe5c9Rgz4y9CisE9fzvwm7rnTlg07Cqx2VKIqu0H9a52kCb10Avgjal+tHrsS
aEwJGkee1HuvdRQxKtOj18awNR5CdyE5XG0pX5SE+1Gk8JTjg0njx5IPiS6j6by4VPn8
djQd2MWS2dg507B91dJ96a4oSw84MKjG7O4KUvTtdXeCnJRNaw9KeVV9BrGsYmimKwk0
pVjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1733866091; x=1734470891;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=5i/Otp8vcGDR6l4/RkhpyZHkQ5X9HgD2xvIP/fOfszA=;
b=CKUwdiVYB1XMtxQTHMCFXWb+bO6/ioOaWP14nGWW2TQmDqAxMPUMDaaPpWgNtDEoJC
J4ykWRPMfaCQxOcOdjqrCSYcP+ShcpFB9DRKjwxYeGEb37WvbyEkocYmcE7s8goeX3vl
lVH/ak7Cgc1TBwbVeEdOeWUh7+EH89CVGWXn0lGmm1d7vdWTVY5UzVDedCEWjj7M9tCD
DSyW5VpGhWPxAVn02H4700tKFwFtjuLI2bicwSQLlCby1tcesef23HNR/gemZBEgtlnH
Qdqqg1F0j7nIfA7nFmMGO5iGPor4fb3hwwLPuG9mHLLY+WiMOtL/6Ts/IC+o3cxImqm/
Bl1g==
X-Gm-Message-State: AOJu0YzZYQLvwHc6xIUbC0vo4zmd2WAZHZ6ka1bHk6I5DIg5V5njEvys
dKNdZaevAEGzeaGOARQTVYTMJSrvoAMqSqzWFXbitK8Qh9pVcPh5b4F2CRm2zpxUyHLBNbGwWd7
n
X-Gm-Gg: ASbGncsX3RUuEBT+d1sKsCOFBTPVABFNVScXePCMrvctSTJFUTOP7KvttRrF2hz1Bo/
7PjXUbd0hn768P9TACCKsL+CwbTeCYv8p/5zRyXg7DWAB7VCl28UCsZZqusXHYFNisII67JWLZ7
qFQuJ8NyFCjKHGhzCsiIGWEuDOhBBKLjFpIlQbyH2ayxwK8h1eHJ0f5/0FcfMerLmXnCXQECPKR
uHmXub4L2wHDuHB2eKA77d805b0COlozm1JmBJevXL6E5zzeSqmklFMhCKVJcwmZXBZkNd/m64A
lyhJ6KTDg6J7HhtPCVMsy1ndZeA1HsE=
X-Google-Smtp-Source: AGHT+IHF/LMs8S8MeyP9POwO5CjkuU6rBXMtf9EW/rCUNNAXr2RGiQfiWOk6FAYcXyY9ssNwyu7mqg==
X-Received: by 2002:a05:6a00:2e89:b0:714:15ff:a2a4 with SMTP id
d2e1a72fcca58-728ed3db486mr774111b3a.13.1733866090719;
Tue, 10 Dec 2024 13:28:10 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d2e1a72fcca58-725e7c98efbsm4972577b3a.186.2024.12.10.13.28.09
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 10 Dec 2024 13:28:10 -0800 (PST)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [RFC 4/8] net/ioring: implement management functions
Date: Tue, 10 Dec 2024 13:23:35 -0800
Message-ID: <20241210212757.83490-5-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241210212757.83490-1-stephen@networkplumber.org>
References: <20241210212757.83490-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add start, stop, configure and info functions.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/ioring/rte_eth_ioring.c | 72 ++++++++++++++++++++++++++---
1 file changed, 66 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c
index de10a4d83f..b5d9c12bdf 100644
--- a/drivers/net/ioring/rte_eth_ioring.c
+++ b/drivers/net/ioring/rte_eth_ioring.c
@@ -212,12 +212,16 @@ static int
eth_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
{
struct pmd_internals *pmd = dev->data->dev_private;
+
+ int sock = socket(AF_INET, SOCK_DGRAM, 0);
+ if (sock < 0)
+ return -errno;
+
struct ifreq ifr = { .ifr_mtu = mtu };
- int ret;
strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ);
- ret = ioctl(pmd->ctl_sock, SIOCSIFMTU, &ifr);
+ int ret = ioctl(sock, SIOCSIFMTU, &ifr);
if (ret < 0) {
PMD_LOG(ERR, "ioctl(SIOCSIFMTU) failed: %s", strerror(errno));
ret = -errno;
@@ -230,14 +234,17 @@ static int
eth_dev_macaddr_set(struct rte_eth_dev *dev, struct rte_ether_addr *addr)
{
struct pmd_internals *pmd = dev->data->dev_private;
- struct ifreq ifr = { };
- int ret;
+ int sock = socket(AF_INET, SOCK_DGRAM, 0);
+ if (sock < 0)
+ return -errno;
+
+ struct ifreq ifr = { };
strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ);
ifr.ifr_hwaddr.sa_family = ARPHRD_ETHER;
memcpy(ifr.ifr_hwaddr.sa_data, addr, sizeof(*addr));
- ret = ioctl(pmd->ctl_sock, SIOCSIFHWADDR, &ifr);
+ int ret = ioctl(sock, SIOCSIFHWADDR, &ifr);
if (ret < 0) {
PMD_LOG(ERR, "ioctl(SIOCSIFHWADDR) failed: %s", strerror(errno));
ret = -errno;
@@ -246,6 +253,56 @@ eth_dev_macaddr_set(struct rte_eth_dev *dev, struct rte_ether_addr *addr)
return ret;
}
+static int
+eth_dev_start(struct rte_eth_dev *dev)
+{
+ dev->data->dev_link.link_status = RTE_ETH_LINK_UP;
+ eth_dev_set_link_up(dev);
+
+ for (uint16_t i = 0; i < dev->data->nb_rx_queues; i++) {
+ dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+ dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED;
+ }
+
+ return 0;
+}
+
+static int
+eth_dev_stop(struct rte_eth_dev *dev)
+{
+ dev->data->dev_link.link_status = RTE_ETH_LINK_DOWN;
+ eth_dev_set_link_down(dev);
+
+ for (uint16_t i = 0; i < dev->data->nb_rx_queues; i++) {
+ dev->data->rx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+ dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STOPPED;
+ }
+
+ return 0;
+}
+
+static int
+eth_dev_configure(struct rte_eth_dev *dev)
+{
+ /* rx/tx must be paired */
+ if (dev->data->nb_rx_queues != dev->data->nb_tx_queues)
+ return -EINVAL;
+
+ return 0;
+}
+
+static int
+eth_dev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
+{
+ struct pmd_internals *pmd = dev->data->dev_private;
+
+ dev_info->if_index = if_nametoindex(pmd->ifname);
+ dev_info->max_mac_addrs = 1;
+ dev_info->max_rx_pktlen = RTE_ETHER_MAX_LEN;
+
+ return 0;
+}
+
static int
eth_dev_close(struct rte_eth_dev *dev)
{
@@ -263,11 +320,14 @@ eth_dev_close(struct rte_eth_dev *dev)
close(pmd->keep_fd);
pmd->keep_fd = -1;
}
-
return 0;
}
static const struct eth_dev_ops ops = {
+ .dev_start = eth_dev_start,
+ .dev_stop = eth_dev_stop,
+ .dev_configure = eth_dev_configure,
+ .dev_infos_get = eth_dev_info,
.dev_close = eth_dev_close,
.link_update = eth_link_update,
.dev_set_link_up = eth_dev_set_link_up,
--
2.45.2