From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 355D245E6D; Tue, 10 Dec 2024 22:28:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6221E4064F; Tue, 10 Dec 2024 22:28:15 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 788004060C for ; Tue, 10 Dec 2024 22:28:12 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-725ef0397aeso2379693b3a.2 for ; Tue, 10 Dec 2024 13:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733866092; x=1734470892; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CWXmByB4L66Uu9FEgEMjHKvfHUiK3k4Z04IDAW45dzE=; b=F5oy4pYBTMU5Rj4xClTVMME3FNwsxjFjuXArNNQUb9g3LKxf0KTZQhdj3Bdj6PpHI6 TeWtgxl2sAToOPzKH7Lu7moPH2M6yvYJHilCneGUE3eoIYpG+iltHdlYyJesDWpqyRz0 7UKxKTZYu+alzjp6j9rm6911n3LXcZKajb15j7z6Z7LfBcFSzX9+o6XCvhfed1o/nJWu z+KOHFy8t6D8maS5fo85P3DL26O4nywoFyULlHEH6/UOnVfLQigl8jL6tUNYap4QkVYi qDSrK5E4vewu2Sf3TrJoMNVb2UzrQLOzXKnnr3w6TOStGLdKQdwZGuSyBzCftUzKRUdw Gyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733866092; x=1734470892; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CWXmByB4L66Uu9FEgEMjHKvfHUiK3k4Z04IDAW45dzE=; b=idVZTpmMaWbw9ZY3inDNWgap1GRpGSfUIDGAEiLrOWyII/tQMjVqS89oEyTlpCRURe vZFIcMrHKhGsxcTEyU8Jyz59nVGOlfqKif6toZ+VotcW9nHOdVJp3/4NVE52sGjyXgws RnWe8b40zT0/9GYxeoOUb+HsvN4veunTnguX4Zm11gLGYDxcfLYHLdWGwoGEPFVdNk/k pyJ9tsUQfqmNe8x7dc3Zwh/7qBED0zNs1qhCO1qHZGzsta213gpBwuiKTnEmq+pyN43O K5iZojK/JiR5D8FDenspDa0LvO7I9bQ+I6vVDXaiZdR/J4ucHVOifTWa+x8O8MEbyV9F PNcw== X-Gm-Message-State: AOJu0Yxx5/ONzngYmQqraIj5aF4Ll7HKgz2cpJt/LE5Cn0wMCI1jV62b f+nldKzTGZlrmK8Heg6Xz4vvO8MBR+7unN4zSBfxE6yXrIb25eZMvmHPaKChzk/9pwbrhrnaLCt w X-Gm-Gg: ASbGncu7W7OEyhajIbcwql8AfcKHLTI1CiBNhxqD7IbWMtLo8GattJOEXxFlPymR4WY zCT7SOWQt7DY3xPzsbsMTr1Z/4g3B86Ym7W44gXi5UPEOmrd45taLkkAlnlBrfw5Dux4DfI9c1O Dfx9o5Dgf0cx89S882GPveBQ2a4XpqhpZurIFZqvZQDatp0AXqJsNUkHg+6KzaXnxhU21yR9LA5 3VukGdLbKvXZd2nR/8hBqOV+J1IGorGWji82oCfAj6f121x7cTUq8nCC35zFiTDHhypUqGUHE9/ Gm+S2J8vq8plQx/GODpjQgJJGEti3UA= X-Google-Smtp-Source: AGHT+IEf831PlexTKh+3IZrqhnNm/MPtGO6ubkPp9E6gINfBHEKKKEI23GP5NWzIycfF7ZTbqd6yVA== X-Received: by 2002:a05:6a00:1487:b0:725:ef4b:de21 with SMTP id d2e1a72fcca58-728ed4392a7mr882831b3a.20.1733866091625; Tue, 10 Dec 2024 13:28:11 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725e7c98efbsm4972577b3a.186.2024.12.10.13.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 13:28:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [RFC 5/8] net/ioring: implement primary secondary fd passing Date: Tue, 10 Dec 2024 13:23:36 -0800 Message-ID: <20241210212757.83490-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241210212757.83490-1-stephen@networkplumber.org> References: <20241210212757.83490-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add support for communicating fd's from primary to secondary. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 136 +++++++++++++++++++++++++++- 2 files changed, 135 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/ioring.ini b/doc/guides/nics/features/ioring.ini index 199c7cd31c..da47062adb 100644 --- a/doc/guides/nics/features/ioring.ini +++ b/doc/guides/nics/features/ioring.ini @@ -8,6 +8,7 @@ Link status = Y MTU update = Y Promiscuous mode = Y Allmulticast mode = Y +Multiprocess aware = Y Linux = Y x86-64 = Y Usage doc = Y diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c index b5d9c12bdf..ddef57adfb 100644 --- a/drivers/net/ioring/rte_eth_ioring.c +++ b/drivers/net/ioring/rte_eth_ioring.c @@ -28,6 +28,7 @@ #include #define IORING_DEFAULT_IFNAME "enio%d" +#define IORING_MP_KEY "ioring_mp_send_fds" RTE_LOG_REGISTER_DEFAULT(ioring_logtype, NOTICE); #define RTE_LOGTYPE_IORING ioring_logtype @@ -400,6 +401,84 @@ parse_iface_arg(const char *key __rte_unused, const char *value, void *extra_arg return 0; } +/* Secondary process requests rxq fds from primary. */ +static int +ioring_request_fds(const char *name, struct rte_eth_dev *dev) +{ + struct rte_mp_msg request = { }; + + strlcpy(request.name, IORING_MP_KEY, sizeof(request.name)); + strlcpy((char *)request.param, name, RTE_MP_MAX_PARAM_LEN); + request.len_param = strlen(name); + + /* Send the request and receive the reply */ + PMD_LOG(DEBUG, "Sending multi-process IPC request for %s", name); + + struct timespec timeout = {.tv_sec = 1, .tv_nsec = 0}; + struct rte_mp_reply replies; + int ret = rte_mp_request_sync(&request, &replies, &timeout); + if (ret < 0 || replies.nb_received != 1) { + PMD_LOG(ERR, "Failed to request fds from primary: %s", + rte_strerror(rte_errno)); + return -1; + } + + struct rte_mp_msg *reply = replies.msgs; + PMD_LOG(DEBUG, "Received multi-process IPC reply for %s", name); + if (dev->data->nb_rx_queues != reply->num_fds) { + PMD_LOG(ERR, "Incorrect number of fds received: %d != %d", + reply->num_fds, dev->data->nb_rx_queues); + return -EINVAL; + } + + int *fds = dev->process_private; + for (int i = 0; i < reply->num_fds; i++) + fds[i] = reply->fds[i]; + + free(reply); + return 0; +} + +/* Primary process sends rxq fds to secondary. */ +static int +ioring_mp_send_fds(const struct rte_mp_msg *request, const void *peer) +{ + const char *request_name = (const char *)request->param; + + PMD_LOG(DEBUG, "Received multi-process IPC request for %s", request_name); + + /* Find the requested port */ + struct rte_eth_dev *dev = rte_eth_dev_get_by_name(request_name); + if (!dev) { + PMD_LOG(ERR, "Failed to get port id for %s", request_name); + return -1; + } + + /* Populate the reply with the xsk fd for each queue */ + struct rte_mp_msg reply = { }; + if (dev->data->nb_rx_queues > RTE_MP_MAX_FD_NUM) { + PMD_LOG(ERR, "Number of rx queues (%d) exceeds max number of fds (%d)", + dev->data->nb_rx_queues, RTE_MP_MAX_FD_NUM); + return -EINVAL; + } + + int *fds = dev->process_private; + for (uint16_t i = 0; i < dev->data->nb_rx_queues; i++) + reply.fds[reply.num_fds++] = fds[i]; + + /* Send the reply */ + strlcpy(reply.name, request->name, sizeof(reply.name)); + strlcpy((char *)reply.param, request_name, RTE_MP_MAX_PARAM_LEN); + reply.len_param = strlen(request_name); + + PMD_LOG(DEBUG, "Sending multi-process IPC reply for %s", request_name); + if (rte_mp_reply(&reply, peer) < 0) { + PMD_LOG(ERR, "Failed to reply to multi-process IPC request"); + return -1; + } + return 0; +} + static int ioring_probe(struct rte_vdev_device *vdev) { @@ -407,14 +486,43 @@ ioring_probe(struct rte_vdev_device *vdev) const char *params = rte_vdev_device_args(vdev); struct rte_kvargs *kvlist = NULL; struct rte_eth_dev *eth_dev = NULL; + int *fds = NULL; char tap_name[IFNAMSIZ] = IORING_DEFAULT_IFNAME; uint8_t persist = 0; int ret; PMD_LOG(INFO, "Initializing %s", name); - if (rte_eal_process_type() == RTE_PROC_SECONDARY) - return -1; /* TODO */ + if (rte_eal_process_type() == RTE_PROC_SECONDARY) { + struct rte_eth_dev *eth_dev; + + eth_dev = rte_eth_dev_attach_secondary(name); + if (!eth_dev) { + PMD_LOG(ERR, "Failed to probe %s", name); + return -1; + } + eth_dev->dev_ops = &ops; + eth_dev->device = &vdev->device; + + if (!rte_eal_primary_proc_alive(NULL)) { + PMD_LOG(ERR, "Primary process is missing"); + return -1; + } + + fds = calloc(RTE_MAX_QUEUES_PER_PORT, sizeof(int)); + if (fds == NULL) { + PMD_LOG(ERR, "Failed to alloc memory for process private"); + return -1; + } + + eth_dev->process_private = fds; + + if (ioring_request_fds(name, eth_dev)) + return -1; + + rte_eth_dev_probing_finish(eth_dev); + return 0; + } if (params != NULL) { kvlist = rte_kvargs_parse(params, valid_arguments); @@ -432,21 +540,45 @@ ioring_probe(struct rte_vdev_device *vdev) persist = 1; } + /* Per-queue tap fd's (for primary process) */ + fds = calloc(RTE_MAX_QUEUES_PER_PORT, sizeof(int)); + if (fds == NULL) { + PMD_LOG(ERR, "Unable to allocate fd array"); + return -1; + } + for (unsigned int i = 0; i < RTE_MAX_QUEUES_PER_PORT; i++) + fds[i] = -1; + eth_dev = rte_eth_vdev_allocate(vdev, sizeof(struct pmd_internals)); if (eth_dev == NULL) { PMD_LOG(ERR, "%s Unable to allocate device struct", tap_name); goto error; } + eth_dev->data->dev_flags = RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; + eth_dev->dev_ops = &ops; + eth_dev->process_private = fds; + if (ioring_create(eth_dev, tap_name, persist) < 0) goto error; + /* register the MP server on the first device */ + static unsigned int ioring_dev_count; + if (ioring_dev_count == 0) { + if (rte_mp_action_register(IORING_MP_KEY, ioring_mp_send_fds) < 0) { + PMD_LOG(ERR, "Failed to register multi-process callback: %s", + rte_strerror(rte_errno)); + goto error; + } + } + ++ioring_dev_count; rte_eth_dev_probing_finish(eth_dev); return 0; error: if (eth_dev != NULL) rte_eth_dev_release_port(eth_dev); + free(fds); rte_kvargs_free(kvlist); return -1; } -- 2.45.2