From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00D6D45E79; Wed, 11 Dec 2024 17:29:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D477C4060B; Wed, 11 Dec 2024 17:29:18 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 0C4A5402EB for ; Wed, 11 Dec 2024 17:29:15 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21619108a6bso42757285ad.3 for ; Wed, 11 Dec 2024 08:29:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1733934555; x=1734539355; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VmsUnJf7qBF2iNHCpyXdR33t3dr632ELmFiBctHwTbk=; b=BGsRgwE89T9X2WLHsVz9ZrzfzqHKCbZInzHsVEsl4FaXy1c5O0y2kifK31YGS3lknC MRSBOojQ1YBc96+4hr5/vQ4WE6xjzTWoMb+B4qYFoi+O6VZ2OEmjOQrCR0w7OF9GrfDH 34eguA7t7Rk8iISFigeV5GPwXBWLMI+/5v5wHjiyk80QdRDGcecJ0FEqQPD1lyJthn7K eSOggvTZd+PrqUAjaEdgSOBTblSM3A53+0gDl9pRaiglcbqCEMPsG2coOhbGaUZ4Rbdu iZwUtXXY0WY7cZAWlG6mantpeQzpPiziU+GxxfsC35HU25Xw4d/1lSDsqsUHYuEc4wGH qCSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733934555; x=1734539355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VmsUnJf7qBF2iNHCpyXdR33t3dr632ELmFiBctHwTbk=; b=Mu5dr7pOq+LsEFHyhQEjId0sOgxDJat4Awp++f1kbgQLOHLFcxSRPtuRtheInYUyRG +2W80ct6Ip6YJDxWBbK6w0I2B72OFPJgmaA9PAa8rK7Mo2nooueDXBjlF9DtzLRdiEBA 08tT9ge4+qdBaboEqLR/uqDCONoyUKHvbea7QmEi/AJTEr4+aHQQbwb1NF5lJ7CDva40 DQeF8Z0SPszzvB8SC7OhHUx+zPJOFRBv2I4DLWeQYkYYCahUC+gMz7ixUaWML3wh0LxN 22tnJTOD4h+VHQvQSEzqu1iL/8FKsisuUeOHqw/X4EZSWOMO/4c0B8HRbiIgTcidGzS0 mMnQ== X-Gm-Message-State: AOJu0YwFTkg8FYu6/aPEm0vkj1449fWlaZg0C3sI3A/bwf6xFsh212Be sdFkBHEbSI1ydsLb15M1s0purjkjjqcSpSe31fi89+IAFRsTToz12KkFAZw78El8oD+dqlqGFAe s X-Gm-Gg: ASbGncvJ8OVWXtbgI0l8WMkwayp4EQt4bGa3oc1Q3MhqucIQ8PxQzOI9sFIpz+ACRQ9 N6Xh8UBbeO/fdS8EBctQ5RBtNOZxoaUUgiX+KhUyJAeMKJ7mJAcPpbLsvF6c/ortnXrjDUSMZ9F 0+/5YkiGf2/PJje38agjo9C3VmJ+/OU+DdHrFZTHfMRprBKq+FuPSz5+3DiPVryB0odofNKBpqW 3vl+L6vR1IEmDwv6YQLGGWbItMtHjLw4Y4ZORN6ASSNQc60YNHeH7IaCHEM07LSb/UnNda8K1SM AyCDJi4JUfmeaIglj332CjdZxSVphP8= X-Google-Smtp-Source: AGHT+IGax03tVb/lEA7akNOQSH5QViNPMm3SM/w+cGqdF/1fHts0FpjKDvch/s5Gg+s3w3TCE2Mxpw== X-Received: by 2002:a17:902:cecc:b0:216:2b14:b625 with SMTP id d9443c01a7336-2177853690emr62519515ad.31.1733934555139; Wed, 11 Dec 2024 08:29:15 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21632c4fc62sm71989895ad.194.2024.12.11.08.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2024 08:29:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v2 2/8] net/ioring: implement link state Date: Wed, 11 Dec 2024 08:28:03 -0800 Message-ID: <20241211162904.121695-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241211162904.121695-1-stephen@networkplumber.org> References: <20241210212757.83490-1-stephen@networkplumber.org> <20241211162904.121695-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add hooks to set kernel link up/down and report state. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/ioring.ini | 1 + drivers/net/ioring/rte_eth_ioring.c | 84 +++++++++++++++++++++++++++++ 2 files changed, 85 insertions(+) diff --git a/doc/guides/nics/features/ioring.ini b/doc/guides/nics/features/ioring.ini index c4c57caaa4..d4bf70cb4f 100644 --- a/doc/guides/nics/features/ioring.ini +++ b/doc/guides/nics/features/ioring.ini @@ -4,6 +4,7 @@ ; Refer to default.ini for the full list of available PMD features. ; [Features] +Link status = Y Linux = Y x86-64 = Y Usage doc = Y diff --git a/drivers/net/ioring/rte_eth_ioring.c b/drivers/net/ioring/rte_eth_ioring.c index 7b62c47f54..fa3e748cda 100644 --- a/drivers/net/ioring/rte_eth_ioring.c +++ b/drivers/net/ioring/rte_eth_ioring.c @@ -47,6 +47,53 @@ struct pmd_internals { struct rte_ether_addr eth_addr; /* address assigned by kernel */ }; +static int +eth_dev_change_flags(struct rte_eth_dev *dev, uint16_t flags, uint16_t mask) +{ + struct pmd_internals *pmd = dev->data->dev_private; + + int sock = socket(AF_INET, SOCK_DGRAM, 0); + if (sock < 0) + return -errno; + + struct ifreq ifr = { }; + strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ); + + int ret = ioctl(sock, SIOCGIFFLAGS, &ifr); + if (ret < 0) + goto error; + + /* NB: ifr.ifr_flags is type short */ + ifr.ifr_flags &= mask; + ifr.ifr_flags |= flags; + + ret = ioctl(sock, SIOCSIFFLAGS, &ifr); +error: + close(sock); + return (ret < 0) ? -errno : 0; +} + +static int +eth_dev_get_flags(struct rte_eth_dev *dev, short *flags) +{ + struct pmd_internals *pmd = dev->data->dev_private; + + int sock = socket(AF_INET, SOCK_DGRAM, 0); + if (sock < 0) + return -errno; + + struct ifreq ifr = { }; + strlcpy(ifr.ifr_name, pmd->ifname, IFNAMSIZ); + + int ret = ioctl(sock, SIOCGIFFLAGS, &ifr); + if (ret == 0) + *flags = ifr.ifr_flags; + + close(sock); + return (ret < 0) ? -errno : 0; +} + + /* Creates a new tap device, name returned in ifr */ static int tap_open(const char *name, struct ifreq *ifr, uint8_t persist) @@ -103,6 +150,39 @@ tap_open(const char *name, struct ifreq *ifr, uint8_t persist) return -1; } + +static int +eth_dev_set_link_up(struct rte_eth_dev *dev) +{ + return eth_dev_change_flags(dev, IFF_UP, 0); +} + +static int +eth_dev_set_link_down(struct rte_eth_dev *dev) +{ + return eth_dev_change_flags(dev, 0, ~IFF_UP); +} + +static int +eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) +{ + struct rte_eth_link *eth_link = &dev->data->dev_link; + short flags = 0; + + if (eth_dev_get_flags(dev, &flags) < 0) { + PMD_LOG(ERR, "ioctl(SIOCGIFFLAGS): %s", strerror(errno)); + return -1; + } + + *eth_link = (struct rte_eth_link) { + .link_speed = RTE_ETH_SPEED_NUM_UNKNOWN, + .link_duplex = RTE_ETH_LINK_FULL_DUPLEX, + .link_status = (flags & IFF_UP) ? RTE_ETH_LINK_UP : RTE_ETH_LINK_DOWN, + .link_autoneg = RTE_ETH_LINK_FIXED, + }; + return 0; +}; + static int eth_dev_close(struct rte_eth_dev *dev) { @@ -126,8 +206,12 @@ eth_dev_close(struct rte_eth_dev *dev) static const struct eth_dev_ops ops = { .dev_close = eth_dev_close, + .link_update = eth_link_update, + .dev_set_link_up = eth_dev_set_link_up, + .dev_set_link_down = eth_dev_set_link_down, }; + static int ioring_create(struct rte_eth_dev *dev, const char *tap_name, uint8_t persist) { -- 2.45.2