From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 054C445E7C;
	Wed, 11 Dec 2024 22:35:35 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 87D6F40263;
	Wed, 11 Dec 2024 22:35:35 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 4E7DE400D7
 for <dev@dpdk.org>; Wed, 11 Dec 2024 22:35:34 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 894C9204721F; Wed, 11 Dec 2024 13:35:33 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 894C9204721F
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1733952933;
 bh=R2PEbf5slTRw/NIUvbPmkliADX1eUfcZVIICuaFW0Z8=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=hn5elLlKHjUw8nlfrH7qz2hVfX35KDCN2NPECBvtCdmdvGEevRaeimtNf8b2yVSoE
 kvfXDQQlZF0nJndEbvynZOnK10JU2LdpkJwW0h0X6618FvFWn5J6iYMzdL5RJhcV3D
 00JIV32LJ/gDgJ7ki29Z7TPa8kSfc/Fmiw3DG+G4=
Date: Wed, 11 Dec 2024 13:35:33 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 00/21] use portable variadic macros
Message-ID: <20241211213533.GA19697@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1733882751-29598-1-git-send-email-andremue@linux.microsoft.com>
 <20241210191456.43d0a35d@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20241210191456.43d0a35d@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Dec 10, 2024 at 07:14:56PM -0800, Stephen Hemminger wrote:
> On Tue, 10 Dec 2024 18:05:30 -0800
> Andre Muezerie <andremue@linux.microsoft.com> wrote:
> 
> > 1) Use portable variadic macros
> > 
> > Many places are using a GCC extension related to variadic macros,
> > where a name prepends the ellipsis. This results in a warning like
> > the one below when compiling the code with MSVC:
> > 
> > app\test-pmd\testpmd.h(1314): error C2608:
> >     invalid token '...' in macro parameter list
> > 
> > Variadic macros became a standard part of the C language with C99.
> > GCC, Clang and MSVC handle them properly.
> > 
> > The fix is to remove the prefix name (args... becomes ...) and use
> > __VA_ARGS__.
> 
> Could you add a coccinelle script and/or a checkpatch check to
> make sure that there are no new usages of ellipsis arg to deal with?

There is already a test for this in checkpatches.sh. Its message is:
MESSAGE='Do not use variadic argument pack in macros'

This test was probably added after these instances were written.