From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 1/4] net/e1000: prevent crashes in secondary processes
Date: Thu, 12 Dec 2024 10:02:23 -0800 [thread overview]
Message-ID: <20241212100223.2863e50b@hermes.local> (raw)
In-Reply-To: <3c323577ce36cf4425d2c2def85d0d6644b87dc8.1734020337.git.anatoly.burakov@intel.com>
On Thu, 12 Dec 2024 16:19:03 +0000
Anatoly Burakov <anatoly.burakov@intel.com> wrote:
> Currently, the architecture of the base driver is such that it uses
> function pointers internally. These are not guaranteed to be valid in
> secondary processes, which can lead to crashes. This patch prevents these
> functions from being executed in e1000 driver.
>
> Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)")
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
Not a fan of this. It creates so many special cases like: "This is ixgbe, and
it can do X but not Y in secondary process".
Either the driver should get fixed correctly so that all operations work
in secondary process, yes you would have to fix the base code.
Or the driver should be not support secondary process model at all.
If you have to write lots of documentation about limitations, it is not helping
the user.
next prev parent reply other threads:[~2024-12-12 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 16:19 Anatoly Burakov
2024-12-12 16:19 ` [PATCH v1 2/4] net/igb: " Anatoly Burakov
2024-12-12 16:19 ` [PATCH v1 3/4] net/igc: " Anatoly Burakov
2024-12-12 16:19 ` [PATCH v1 4/4] net/ixgbe: " Anatoly Burakov
2024-12-12 18:02 ` Stephen Hemminger [this message]
2024-12-13 9:09 ` [PATCH v1 1/4] net/e1000: " Burakov, Anatoly
2025-02-17 13:54 ` [PATCH v2 " Anatoly Burakov
2025-02-17 13:54 ` [PATCH v2 2/4] " Anatoly Burakov
2025-02-17 13:54 ` [PATCH v2 3/4] " Anatoly Burakov
2025-02-17 13:54 ` [PATCH v2 4/4] net/ixgbe: " Anatoly Burakov
2025-02-17 17:28 ` Medvedkin, Vladimir
2025-02-17 15:28 ` [PATCH v2 1/4] net/e1000: " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212100223.2863e50b@hermes.local \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).