From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74CE245D10; Thu, 12 Dec 2024 19:02:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F4DD4027D; Thu, 12 Dec 2024 19:02:29 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id DC99040269 for ; Thu, 12 Dec 2024 19:02:26 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21644aca3a0so10865975ad.3 for ; Thu, 12 Dec 2024 10:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734026546; x=1734631346; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MoHhvovB2CtJPBe4atGcZFcpm71k0Eb5IvtkgYkZ+KM=; b=HLx9yZOKtjVoVToAqshrfQhqzIOxy5X5OVDm1R/s9cBLU3VBvfzLRigAAD0DXJ4gww RPOVc7uuXsEN/0mqxB6D8XATytPGOBhrXhR7Y//F1jtx4FcJl8ONJLh9N86kfp7BnbOc tQxCUIWnpmx0ySk/jcsiT2eqNPZqzpBngrHO9jxZ5P3lLfmlyo90kYEWPJ7skWrRHjBB Z2KegjN3Se75IwfA1EMCSy/H3LuH5HrEc2JFALbWrwSEs5UecUZxAUOkadk8HiUsTD4p KaVK91ZGb/ULfW7qECmOxEXP7JDW1U/0p4ZcWKx9KeSXQLjfV372C4vl1w1CYrZUN51q VVxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734026546; x=1734631346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MoHhvovB2CtJPBe4atGcZFcpm71k0Eb5IvtkgYkZ+KM=; b=mWyhxSFg0T+2syu3eBNifcKvhApXWHAvXMrYBFkquYVDQFAUFe03+ECSAjBrJ3JfXt dgusVDCwiZd/wESqOAVGCM3UouVz5uLmL5wyzzXQBRIp6kr9JkMudORILWQdeTonmKBY bniHuAOvX2l+GE11+EUKzesbjcJ/v6Cj4iQ070PtpjTTx9uTZjRHBTtmPQiI6XVbu36G o/CanKIR95xYRPjsAQ/rDH0wF3Xk8eOABj/KTXkADIzNZqRHaD6kM+YYGlNP44nPpjAP b6iCYEEvAhaNnUQv1udAyHCtEjTeKAjeDItKLJVR8+LTs1Hql1vDuA+Z1zaIB+sP7Jm7 PNHA== X-Gm-Message-State: AOJu0YyiqYXK5CDKQEHsHdoqS4H/EiSeEQ2mW6RyViuAMeIA6ZQedI3m ur1s8mi9oHsY9TijH7RS+x2Brs5ui9gpzhwvfSZb7ldXdb1MZeayaLdlPKp4QxQ= X-Gm-Gg: ASbGncvRus6NBgS/bog59HiUjviCC+Co1W7RcJEZb9uBH1LnGWT5iSRxZsKTmiKw0bx 5J70oyn+Rz1GiR2B/Xfll4kGbKR1Ppw79JdzDpubPklk9egCrilQriyMLVlzc/IKqHgUx5Mp8g7 3QeccfMx+ytcaR9RpveaJOM/zO2IeJp8IyM0+Xn5/m9uNUH0tTMF3JcZiRaldCDP8XOhY5e2EH7 +Rb4y2VnTA+umkLqJtGSqnVfFDtjScgSaBVmW/9Hv8M0MoWh8ZH7TWK3Xgca/BGb8auRmCQzNcB EHG5xFApEiTpU1bPBtMyQcNCuwB6CWq5uw== X-Google-Smtp-Source: AGHT+IHyZJa7iu9+7bJ881+h5+rGs1eOc7d6KMuHrLBQGTOcyjW2XTvo1MvpB7OKTIf6Yx0s8f+iIQ== X-Received: by 2002:a17:902:d54a:b0:216:45b9:43ad with SMTP id d9443c01a7336-2177854b79dmr119370455ad.34.1734026545411; Thu, 12 Dec 2024 10:02:25 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd3f4b77d7sm7675353a12.23.2024.12.12.10.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 10:02:25 -0800 (PST) Date: Thu, 12 Dec 2024 10:02:23 -0800 From: Stephen Hemminger To: Anatoly Burakov Cc: dev@dpdk.org Subject: Re: [PATCH v1 1/4] net/e1000: prevent crashes in secondary processes Message-ID: <20241212100223.2863e50b@hermes.local> In-Reply-To: <3c323577ce36cf4425d2c2def85d0d6644b87dc8.1734020337.git.anatoly.burakov@intel.com> References: <3c323577ce36cf4425d2c2def85d0d6644b87dc8.1734020337.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 12 Dec 2024 16:19:03 +0000 Anatoly Burakov wrote: > Currently, the architecture of the base driver is such that it uses > function pointers internally. These are not guaranteed to be valid in > secondary processes, which can lead to crashes. This patch prevents these > functions from being executed in e1000 driver. > > Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov > --- Not a fan of this. It creates so many special cases like: "This is ixgbe, and it can do X but not Y in secondary process". Either the driver should get fixed correctly so that all operations work in secondary process, yes you would have to fix the base code. Or the driver should be not support secondary process model at all. If you have to write lots of documentation about limitations, it is not helping the user.