From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1F33845EF0;
Fri, 20 Dec 2024 01:04:19 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A38E340265;
Fri, 20 Dec 2024 01:04:18 +0100 (CET)
Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com
[209.85.210.176])
by mails.dpdk.org (Postfix) with ESMTP id 23A944025F
for <dev@dpdk.org>; Fri, 20 Dec 2024 01:04:18 +0100 (CET)
Received: by mail-pf1-f176.google.com with SMTP id
d2e1a72fcca58-725ef0397aeso1129607b3a.2
for <dev@dpdk.org>; Thu, 19 Dec 2024 16:04:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1734653057;
x=1735257857; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=7snE5nITxr1oRr7CLL9rSw3MKLihbh38MSAHf8pZC+U=;
b=C8+7TZ5UJnQBFhtK7r7XwKJzi7OsWC7bbD8105X/QJnww9+iJdVjupxtLlwAQcLKmH
ClBLhCVPN9Fktyh2GCGkUp6xgIbZDWA3jSvkx+9952thBDifzp5Av5b5+FSIdLqISfm/
BQ8f/W8OSo6TTc6ZGLdZSpzTVPcQFwXNv394IhvpBJ0CrxXKYW8RScp5oHikSeCh+Ont
rB+Tq6gELr9zOpumovk1X8Lb2+YeIGSkNWZP4WS16Dd8QjmzESQLHniRhMPtmE6y3Gfp
IUso9qXhrvz08ewIqLT/cF9+E+rJZSaznVTK2e/YX09N7S/CXJQKMUkMGi2S1dDGxnEy
vT6w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1734653057; x=1735257857;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=7snE5nITxr1oRr7CLL9rSw3MKLihbh38MSAHf8pZC+U=;
b=u6tBIeSeWww7ewim3Q92F7hLaqzVv3VT6zkKky1Fl95KxNKeZT9SEVRLHmCsIKuRcI
502LaZmu4COIzVgt/5WmIlclN8HxsPnavs4EYjSSOV0OYXbbGps6ufmQ05phPhUCD449
/XBdv9wCoAGRF5wq5JwYJ1RFjdstz5qiI5Gl2W77RtKsH8ZK+FglZIRKx4nHBZYDK8jd
fdUra5/1P3tvWOWkQC3qBEvIYfVITYJyBMs1SOgTwAV1zKjuFdzRn+fNdBjg99mPWn0t
4bwyvCiicp8cI5hCqwiEB6axYkffbKGkFFjNPTjJdPxYtoJRbmkEfD4YwhTAWkl9GvyW
MqAQ==
X-Forwarded-Encrypted: i=1;
AJvYcCUhvzKY7GVK2H/I0iWDNi1Q/fr1pFvjzyl7z/+TqVsTlBYTlNmudfuMVUrd6ZUVbxA/8TI=@dpdk.org
X-Gm-Message-State: AOJu0YxCtipBAd7JC/ovnkVaS80ijfhZi/qqz2jt5TAvg8hNIRvf+mU9
Tk9fbqoEhkuGlYDCxQbfaYbJCC1hZ82AXVxthzCHuftCTCrRkuCBW839FOEV7fM=
X-Gm-Gg: ASbGncvkWR75U8jGrDLuB+4God7jgPX4kcD/udWQAcvrSphr4b6JzsYTUE7zfnSIQ0I
xX6uafa6ht6Q616tCglAFELsS50GUmfovXYeQqSGiRotIWNZIcYZFNVLXK6q+H602+p5J26825U
UYQRhHUgT1YiHFkTfHFQVew6vNHxTg3rlRV2ceB4llzfENgSn3C8wk6RJ2HNuiKS03c4URtCJ+J
aapJDjksk1YbhocE9lPEE9OXo8j11Im2N+Q4s2tc26na3KLsUo8nwhxNluauwBrZVSqBfKWB8Xz
AiXTpBno7DQk1ZIM/48jlWJBkdsFLUkI5g==
X-Google-Smtp-Source: AGHT+IGM5bXb/yD2N9a6muinKi0V5Z6Gr8EyBqgUhgcG8sWZxuUv86QQgsKjDJjXrHC90xGJp/uqGw==
X-Received: by 2002:a05:6a21:100f:b0:1e0:d848:9e83 with SMTP id
adf61e73a8af0-1e5e07a853amr1802471637.25.1734653057270;
Thu, 19 Dec 2024 16:04:17 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
41be03b00d2f7-842bdfb5895sm1757237a12.50.2024.12.19.16.04.16
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 19 Dec 2024 16:04:17 -0800 (PST)
Date: Thu, 19 Dec 2024 16:04:13 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: Joshua Washington <joshwash@google.com>, Jeroen de Borst
<jeroendb@google.com>, Rushil Gupta <rushilg@google.com>, dev@dpdk.org,
Ferruh Yigit <ferruh.yigit@amd.com>, Praveen Kaligineedi
<pkaligineei@google.com>
Subject: Re: [PATCH] net/gve: Allocate qpl pages using malloc if memzone
allocation fails
Message-ID: <20241219160413.117ad234@hermes.local>
In-Reply-To: <CA+f9V1Nq8ZywGuZ6+=22Om5A8f1BQom_bHf4FMyPuBneFCevMw@mail.gmail.com>
References: <20241218234635.2009033-1-joshwash@google.com>
<20241218195140.60a1f58b@hermes.local>
<CA+f9V1Nq8ZywGuZ6+=22Om5A8f1BQom_bHf4FMyPuBneFCevMw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, 19 Dec 2024 12:53:14 -0800
Praveen Kaligineedi <pkaligineedi@google.com> wrote:
> The TX queue requires IOVA contiguous QPL memory. So, we still need
> memzone code for TX queues.
>=20
> Regards,
> Praveen
>=20
> On Wed, Dec 18, 2024 at 7:51=E2=80=AFPM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Wed, 18 Dec 2024 15:46:35 -0800
> > Joshua Washington <joshwash@google.com> wrote:
> > =20
> > > From: Praveen Kaligineedi <pkaligineedi@google.com>
> > >
> > > Allocating QPL for an RX queue might fail if enough contiguous IOVA
> > > memory cannot be allocated. However, the only requirement for QPL
> > > for RX is that each 4K buffer be IOVA contiguous, not the entire
> > > QPL. Therefore, use malloc to allocate 4K buffers if the allocation
> > > using memzone fails.
> > >
> > > Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> > > Reviewed-by: Joshua Washington <joshwash@google.com>
> > > --- =20
> >
> > Why keep the memzone code? rte_malloc and memzone are both coming from
> > huge pages. Is there any advantage to memzone for what you are doing?
> >
> > Better to not have two potential allocation paths to test. =20
Please fix email address typo in next version. I am getting bounces
because it has
Praveen Kaligineedi <pkaligineei@google.com>
in Cc:
Looks like you meant:
Praveen Kaligineedi <pkaligineedi@google.com>