From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2DB145F42; Wed, 25 Dec 2024 22:22:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90FEC402AD; Wed, 25 Dec 2024 22:22:28 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id BE536402A5 for <dev@dpdk.org>; Wed, 25 Dec 2024 22:22:26 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-215770613dbso48615025ad.2 for <dev@dpdk.org>; Wed, 25 Dec 2024 13:22:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1735161746; x=1735766546; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oG2mppidYwu4b3EV66DHpivNNBmZ6PAFTq3gEfc/hXo=; b=FbRaLeziOH8dhKMT1uyc+Hk3SHBfIIFa8P7Nv5yUvSJcc2XnS0KJk1UsAEKoOmifsG MZxRiZ+Q1cf/2Tq3p4pFkS0ofkQjtUnDniIVNjCzlWcsUZqWMzMkskUArw+/iY50rcYn WMvQpoxuuFnC0eJ6udCwEb0vOSeCukUfKYcOSckVRBJfuIax1jY3YVgk73CMYJIoBIFw N85hFziMommfvnUN8SZZffGyoaCQNAb+a7jV62ydRNlqZiMNWxM4CjfIaK1ul3vrZbpl OVm5o3ciQa2IBQedyrBiFf3merS1BvxVqh4GjIXhSwPS22mRFvIXtEEmW4zxwsCqeMsk ibKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735161746; x=1735766546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oG2mppidYwu4b3EV66DHpivNNBmZ6PAFTq3gEfc/hXo=; b=crz0ooESU3TVQjKsEEck4H3LZtoUdYZerpA01J6wcHKwGtH9NSHxpxmy0dTnDhW24D eUpZhPYaRGOPDqfDRKtDw30yhtCUpu37iY9svviz/oAtqf+NdNIViviIE7ak/frMaBUZ IdvC1rTHZGG8k4V9uRgIgvFx4YWv+mKXh6B3Sv8PRB/irMb206BrOTLloaBLL/VziLKN xmFiiUDq0Rp097clksAaqI5zcSVmPfdD9yfCxwrbFmM4xaKJo1SZlQqzArWUO/xdf5J2 DDICEzgoiAWqMmIDlo8dj97ZDvuX4pued95g1vjcfhqlZf/lEIDjnSYABG4I17As50jr Kz6A== X-Gm-Message-State: AOJu0Yww8UVxoXkSYJQt1d5bQfIiokdkKqetSUyPgOyzd84f/6oglc6M ub7gVQqOBIpOQ+HFXQrrXqZjKwZ8hbWojrAfRKMRfT0iNMEvWLgO1dHgnen9DAI= X-Gm-Gg: ASbGncvoNuF9Tp13BG9jfTWR0Se6lECVjzkchFWgXsBRkC7iJ8XPuue0dhjP17wn84m kU/46DH5sVa1hz2lAyLFtow5daDMEQ3Ux8A9Bz6/AmhwhgfA4vXFaBwtdMtdnpH1JPZLlz8mjqD ZNAPaASx6jK80wX6HcLwVX1gT/A6vSOChmDcyI7pQiNGiAEiM6Ug/jAsZThTIvkhX5r1D9V7FGb Al9Pen53qxPvQpXsq42YnKROonsVZQD8qZoNjmpAPRHSaoNteaTou7FDEmlWlBpcczgFA00Z+S1 1g3H+ously+Z X-Google-Smtp-Source: AGHT+IGK/otli0ZhMc/K/HpUkJuSloLgSaqP5qIWXgKpNvs5Lzx27ZcPRbtx+TxtKlVzLKBjX3gQ8g== X-Received: by 2002:a05:6a21:158d:b0:1e0:d89e:f5bc with SMTP id adf61e73a8af0-1e5e046155fmr34511020637.11.1735161745855; Wed, 25 Dec 2024 13:22:25 -0800 (PST) Received: from fedora (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-842b85f00f9sm10766895a12.43.2024.12.25.13.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Dec 2024 13:22:25 -0800 (PST) Date: Wed, 25 Dec 2024 13:22:23 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Chaoyong He <chaoyong.he@corigine.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, oss-drivers <oss-drivers@corigine.com>, Long Wu <Long.Wu@nephogine.com>, Nole Zhang <peng.zhang@corigine.com> Subject: Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size Message-ID: <20241225132223.6ad59de8@fedora> In-Reply-To: <SJ0PR13MB55459C6FE25A00FA3F869D899E062@SJ0PR13MB5545.namprd13.prod.outlook.com> References: <20240624020355.3712965-1-chaoyong.he@corigine.com> <20241011032412.3672788-1-chaoyong.he@corigine.com> <20241011032412.3672788-3-chaoyong.he@corigine.com> <20241203115758.7a74ebcf@hermes.local> <SJ0PR13MB554500C363F7F2E4A4B8C5399E372@SJ0PR13MB5545.namprd13.prod.outlook.com> <20241204080043.2aa5e239@hermes.local> <SJ0PR13MB55451F1DAC105D0521F37FCC9E302@SJ0PR13MB5545.namprd13.prod.outlook.com> <SJ0PR13MB55459C6FE25A00FA3F869D899E062@SJ0PR13MB5545.namprd13.prod.outlook.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Thu, 19 Dec 2024 05:52:40 +0000 Chaoyong He <chaoyong.he@corigine.com> wrote: > > > On Wed, 4 Dec 2024 06:21:00 +0000 > > > Chaoyong He <chaoyong.he@corigine.com> wrote: > > > > > > > > The definition of what a "dedicated queue" is a bit confusing. > > > > > If it is only for LACP packets, it should never need to be very big. > > > > > Only under a mis-configuration and DoS kind of flood should there > > > > > ever be many packets. > > > > > > > > Yes, the dedicated queue is only for LACP packets now and it doesn't > > > > need be > > > set very big. > > > > > > > > But if we use a hardware queue as the "dedicated queue", we must > > > > consider the hardware capability. The minimum queue size of some > > > > NICs may be larger than the hardcode dedicated queue size. In this > > > > case, I think it > > > is better to add an interface to set the dedicated queue size. > > > > > > How about using the existing descriptor queue limits api for that? > > > It is reported by info get > > > > Using existing descriptor queue limits api is good enough for current > > problem(hardware capability), but I think it is not very flexible. > > Now we use a macro as a default value for dedicated queue size, but we can > > replace the macro with queue limit while still retaining the interface for > > modifying queue size. > > What do you think of this? > > A gentle ping ~ Should be a devargs parameter to bonding PMD, not a whole new API.