From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8055D46077;
Mon, 13 Jan 2025 20:12:05 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id DE73C402E4;
Mon, 13 Jan 2025 20:11:55 +0100 (CET)
Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com
[209.85.214.171])
by mails.dpdk.org (Postfix) with ESMTP id 6523C402C4
for <dev@dpdk.org>; Mon, 13 Jan 2025 20:11:54 +0100 (CET)
Received: by mail-pl1-f171.google.com with SMTP id
d9443c01a7336-2163dc5155fso85637915ad.0
for <dev@dpdk.org>; Mon, 13 Jan 2025 11:11:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1736795513;
x=1737400313; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=gC8s2vDnkxWmpfjIAIHLiUE+0es3KQvQ1hw8Q2ohqWE=;
b=EhobRKxjz0/WYJIsjkmb/RbCle6ipLBkt7rPFGRcGEVlQAOPlt+GuYrRpS2bq7RsP6
h4rDq1Wd6pkx9V4jhP1eQSuO3uZ5qqTc6woXwj4y9gZZt/VbriWDTyehtnzX3u7MxoDJ
gHp3Ocm8Vk2F3RzMxTGQBHnF8acu5mtQUvM1O2jJW63DwVdMY+lUuXKvX69X3vEBRRTo
YgvRWh1puvcHxBUAd+Nh2CJts7Z1f8xbr4vzfiy+DycXZn9YAsnZF3L2/L1zD7J4rCNH
v+vlQnc/GMKl8/4X1xJ6fIUc4pHMwwyWybFULiBWyDWj152pMmMu/B97glXoK8msN+p9
nKNA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1736795513; x=1737400313;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=gC8s2vDnkxWmpfjIAIHLiUE+0es3KQvQ1hw8Q2ohqWE=;
b=TAlT2z4ZYltluoey31YyrJfeP5QC/6kUKJaE0L+W3lzAPa6ZnYF2gok8MEGJUIjipG
uIc6tPl9GsrdurU7a0qgvvmDTOPzmGHoR8KT/+Nv3h2QWD3joPTaGIME6359x4v2/nb/
v4aFAbKt3CUr9845/x4wifCGxF0xQSmVJOmsIXIoemkL7Vxe9z8O+MnWLCkNqnRIvEtF
ZZQ+FsQhsQzj2walk4uHFKzGfSlMDIws+xt6Twb9kra93oGXQMqLmLAHoyKkjJpBO9yi
OYqAzANIoeCILLrXfCihH7QVBtXUx2+DUOoaLDhKgk/wLE1TMVkB8kS3hQToJEQLsui2
IhqA==
X-Gm-Message-State: AOJu0YxZo504UURTRPqT4EwxrObSixfwEuARS1bwbcQk8/GvViXO3e6Y
T0cRElQr3xjCDxd091C2LjpWd3yYDZ7AruQadUCx3exZCWYnft/rxyFpuLBXs4I=
X-Gm-Gg: ASbGnctinrDBQxmDwx9ZYmuMTToxdEI7D/KOFXzYdvFXTzKHEiTWxzLhYk0GQAk/FHO
9fJAUDGpn77IS6gqEMqyYHyvAzIu4Pv7j4SAjBYdzdhysYR/ptb2ftXh0pOJw3ad60o/gGs4S77
TaEGRX1eZuNta3H8KExuRseMKxt843mN+qMBBgbiJLwbc6XrU5XuV1Es9cijnnSXzrdmyr7Qsj7
X7g+rI6GP4iCkgwL6Vi7Jlw2nwI7BrdRROe2h+XjnJWs8qI10IL/FVxqLC8xGjDTeeVDinUa6MS
aUxiIgQwST2du2B74Dke4rzD7YQ9rRHIrw==
X-Google-Smtp-Source: AGHT+IGOf5xJfwKEoPRciMH9CAJhaq6sNg3MiWpPB8b9hnscRltrXSHnN4VaU33+Y2Kuydk56Gg/7Q==
X-Received: by 2002:a17:90b:2cd0:b0:2ee:ead6:6213 with SMTP id
98e67ed59e1d1-2f548edf263mr29421885a91.19.1736795513415;
Mon, 13 Jan 2025 11:11:53 -0800 (PST)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
98e67ed59e1d1-2f5593d0911sm9005139a91.8.2025.01.13.11.11.52
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 13 Jan 2025 11:11:52 -0800 (PST)
Date: Mon, 13 Jan 2025 11:10:35 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ariel Otilibili <otilibil@eurecom.fr>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, David Marchand
<david.marchand@redhat.com>
Subject: Re: [PATCH v3 4/6] net/failsafe: remove check around
pthread_mutex_init()
Message-ID: <20250113111035.34b8d194@hermes.local>
In-Reply-To: <20250112202021.179634-5-otilibil@eurecom.fr>
References: <20250112185842.9752-1-otilibil@eurecom.fr>
<20250112202021.179634-1-otilibil@eurecom.fr>
<20250112202021.179634-5-otilibil@eurecom.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Sun, 12 Jan 2025 21:20:19 +0100
Ariel Otilibili <otilibil@eurecom.fr> wrote:
> diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c
> index 32811403b4c8..e1c77cdf4fd1 100644
> --- a/drivers/net/failsafe/failsafe.c
> +++ b/drivers/net/failsafe/failsafe.c
> @@ -147,11 +147,7 @@ fs_mutex_init(struct fs_priv *priv)
> ERROR("Cannot set mutex type - %s", strerror(ret));
> return ret;
> }
> - ret = pthread_mutex_init(&priv->hotplug_mutex, &attr);
> - if (ret) {
> - ERROR("Cannot initiate mutex - %s", strerror(ret));
> - return ret;
> - }
> + pthread_mutex_init(&priv->hotplug_mutex, &attr);
> return 0;
Could be a tail call here.
return pthread_mutex_init(&priv->hotplug_mutex, &attr);