From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 199C94607F;
	Tue, 14 Jan 2025 15:57:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 9C8EF40299;
	Tue, 14 Jan 2025 15:57:53 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 066FB40298
 for <dev@dpdk.org>; Tue, 14 Jan 2025 15:57:51 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1213)
 id 1A6AF20BEBE1; Tue, 14 Jan 2025 06:57:51 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A6AF20BEBE1
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1736866671;
 bh=6YAa1JtB3G+KV+8pW7/s8/PnA7tBlffKN+gYjcZ3Pig=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Cmu/7IVlhyKIKH0gEPlf4c0zkeUqDDHuRNSIzzIe16KviC9gpAH4gDGf5eIIGto9Q
 sqN+jx+SlcF8cO5JtF66QvwXiGMBuEmb+Ql80aMpSTtRGnzMt9Ezeg+xRrpXFXlJuo
 wOd+gDJOZi19Xu4rOTxlLg5xeMm7WR1jvAbpSK28=
Date: Tue, 14 Jan 2025 06:57:51 -0800
From: Andre Muezerie <andremue@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, konstantin.ananyev@huawei.com, homas@monjalon.net,
 david.marchand@redhat.com
Subject: Re: [PATCH v14 03/81] eal/common: remove use of VLAs
Message-ID: <20250114145751.GA11978@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
 <1736540620-21764-1-git-send-email-andremue@linux.microsoft.com>
 <1736540620-21764-4-git-send-email-andremue@linux.microsoft.com>
 <20250110171405.34337a79@hermes.local>
 <20250113213012.GA24441@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20250113213012.GA24441@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Jan 13, 2025 at 01:30:12PM -0800, Andre Muezerie wrote:
> On Fri, Jan 10, 2025 at 05:14:05PM -0800, Stephen Hemminger wrote:
> > On Fri, 10 Jan 2025 12:22:22 -0800
> > Andre Muezerie <andremue@linux.microsoft.com> wrote:
> > 
> > > diff --git a/lib/eal/meson.build b/lib/eal/meson.build
> > > index e1d6c4cf17..352db049e9 100644
> > > --- a/lib/eal/meson.build
> > > +++ b/lib/eal/meson.build
> > > @@ -31,3 +31,11 @@ endif
> > >  if is_freebsd
> > >      annotate_locks = false
> > >  endif
> > > +
> > > +warning_flags = ['-Wvla']
> > > +
> > > +foreach arg: warning_flags
> > > +    if cc.has_argument(arg)
> > > +        cflags += arg
> > > +    endif
> > > +endforeach
> > > -- 
> > 
> > Could we enable it for all libs and only turn it off as required?
> 
> Yes. Although the data types in meson are additive only, we can
> add -Wno-vla to cancel a -Wvla already present. Let me send out a
> new series with this change.

Series v16 has the changes proposed.

There was only one failure reported now, which seems infra-related:
"The requested resource was not found on this server":
https://mails.dpdk.org/archives/test-report/2025-January/842300.html

Let me know if any action is needed from my side.

Thanks,

Andre Muezerie