From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (unknown [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 905AB460A7;
Fri, 17 Jan 2025 11:46:42 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id C793642DD3;
Fri, 17 Jan 2025 11:43:47 +0100 (CET)
Received: from smtpbgjp3.qq.com (smtpbgjp3.qq.com [54.92.39.34])
by mails.dpdk.org (Postfix) with ESMTP id B133042DC9
for <dev@dpdk.org>; Fri, 17 Jan 2025 11:43:45 +0100 (CET)
X-QQ-mid: bizesmtpsz8t1737110621tfjqj6z
X-QQ-Originating-IP: e80A52a6B/4+Z8OdYPmzeXS5czAFeDN9OqebA9GXAfo=
Received: from DSK-zaiyuwang.trustnetic.com ( [36.24.187.167])
by bizesmtp.qq.com (ESMTP) with
id ; Fri, 17 Jan 2025 18:43:40 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 17637268072106803464
From: Zaiyu Wang <zaiyuwang@trustnetic.com>
To: dev@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [PATCH v2 12/15] net/ngbe: add start/stop/reset/close ops for VF
device
Date: Fri, 17 Jan 2025 18:41:11 +0800
Message-Id: <20250117104115.16528-13-zaiyuwang@trustnetic.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20250117104115.16528-1-zaiyuwang@trustnetic.com>
References: <20250109040227.1016-1-zaiyuwang@trustnetic.com>
<20250117104115.16528-1-zaiyuwang@trustnetic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1
X-QQ-XMAILINFO: MviyouKjmhfyCHluLHtkjdXuoD+8CINLwH5dxlXlXNAGRkFDghsOLr4+
t6B0uxpc412yQP5KkGT4jCwNgp9kWz8ma4Jbwl4AZe2622APRZS1AU12bo3rpMUQ17CpzFU
zzQjTHwlCTI/+gJ1ffh7RAGDIZH0Hs+ahC3vyOYwdD/10z22WX2Bk+FVkzEVLugv0dF+ft5
kZFZO581hIu2CERCBIt9jO7wsb1zD2vjXMPYkczyTiKqOGouraz098q65kXgAxE9usJEO+s
jhvS4UqmL9unbxydZkHU/eZ/Q0/b2EFBmpnI4X/elzg0ISouNrzPx0K5CwYU87wONsSx2+c
N45VcBBJLbxiCVUpEMlSre++/8qbOpcjSjn6j63/2Oopmvjip2cdDboJRGO8TCuTZvYj0YS
QIvl75n5+i8nw+bm3shBrlu5oDOHJWcSe7e+ePDbxbrAr7+4PTiXEdkwealZxaIh+JXFeFJ
OTwRWpHo3lWF6QDaBGa8g/wYSeNvcodvciXeHKLuDZEy121Q5EI/4Ee8QXn5+Rgdr6RnJMK
wQCF44E3D8/+fCdP21rxyzzGVS2b8Yi3LhuVfUJSbDm5mI81dPswg/WGgHWvI4Q8Y7aeUcs
vGxsnLKnMnZDsh8StkUEp6G5wmmNt/4nAj/h57hvP7TIBmklrjiFrP7ZUlm9IAQMC9ttPw8
W5tf4vuQOvvSah4+TQm68Q0/a3s6FR1fL7LxjgtjParJEMf+u+dESzJ6vAoioA6Qmb5yunO
B5AxnOT1LFZyQ0V0jA/uDcWgeWhgmuNPkJR7gLl4HkGD8sYWCYs6F4UqtMuL9Y5fORa4adE
eIsmhuWKHQH1RoL62gYxJxVQTpLtIKD8C4k5dxt8fiO3SAG1xJiX/WPCfWkybK+g0pUwEPz
KYIrTvHOazBgPom2EfcuYDYzYb6R4QUN5mCbFvZPle3e2+UKA6Ge7KJCQSG5Y6XI2aUMN3t
OOSkVQVCJHJOm7cvFUc1bW9G28FfdHXUIx5YygOoIYh1px+IBq7S5VqDDVhADWDJOEDSTca
xQ4l0MZ7t84Jnlu8acXj4I6+oG5yU=
X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add the complete configuration process for start/stop/reset/close ops,
so that applications can enable the device correctly.
Signed-off-by: Zaiyu Wang <zaiyuwang@trustnetic.com>
---
drivers/net/ngbe/ngbe_ethdev_vf.c | 170 +++++++++++++++++++++++++++++-
1 file changed, 169 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c
index 46710f7273..53d7767220 100644
--- a/drivers/net/ngbe/ngbe_ethdev_vf.c
+++ b/drivers/net/ngbe/ngbe_ethdev_vf.c
@@ -553,12 +553,151 @@ ngbevf_dev_configure(struct rte_eth_dev *dev)
return 0;
}
+static int
+ngbevf_dev_start(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ uint32_t intr_vector = 0;
+ struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+ struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
+
+ int err, mask = 0;
+
+ PMD_INIT_FUNC_TRACE();
+
+ err = hw->mac.reset_hw(hw);
+ if (err) {
+ PMD_INIT_LOG(ERR, "Unable to reset vf hardware (%d)", err);
+ return err;
+ }
+ hw->mac.get_link_status = true;
+
+ /* negotiate mailbox API version to use with the PF. */
+ ngbevf_negotiate_api(hw);
+
+ ngbevf_dev_tx_init(dev);
+
+ /* This can fail when allocating mbufs for descriptor rings */
+ err = ngbevf_dev_rx_init(dev);
+
+ /**
+ * In this case, reuses the MAC address assigned by VF
+ * initialization.
+ */
+ if (err != 0 && err != NGBE_ERR_INVALID_MAC_ADDR) {
+ PMD_INIT_LOG(ERR, "Unable to initialize RX hardware (%d)", err);
+ ngbe_dev_clear_queues(dev);
+ return err;
+ }
+
+ /* Set vfta */
+ ngbevf_set_vfta_all(dev, 1);
+
+ /* Set HW strip */
+ mask = RTE_ETH_VLAN_STRIP_MASK | RTE_ETH_VLAN_FILTER_MASK |
+ RTE_ETH_VLAN_EXTEND_MASK;
+ err = ngbevf_vlan_offload_config(dev, mask);
+ if (err) {
+ PMD_INIT_LOG(ERR, "Unable to set VLAN offload (%d)", err);
+ ngbe_dev_clear_queues(dev);
+ return err;
+ }
+
+ ngbevf_dev_rxtx_start(dev);
+
+ /* check and configure queue intr-vector mapping */
+ if (rte_intr_cap_multiple(intr_handle) &&
+ dev->data->dev_conf.intr_conf.rxq) {
+ /* According to datasheet, only vector 0/1/2 can be used,
+ * now only one vector is used for Rx queue
+ */
+ intr_vector = 1;
+ if (rte_intr_efd_enable(intr_handle, intr_vector))
+ return -1;
+ }
+
+ if (rte_intr_dp_is_en(intr_handle)) {
+ if (rte_intr_vec_list_alloc(intr_handle, "intr_vec",
+ dev->data->nb_rx_queues)) {
+ PMD_INIT_LOG(ERR,
+ "Failed to allocate %d rx_queues intr_vec",
+ dev->data->nb_rx_queues);
+ return -ENOMEM;
+ }
+ }
+
+ ngbevf_configure_msix(dev);
+
+ /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt
+ * is mapped to VFIO vector 0 in eth_ngbevf_dev_init( ).
+ * If previous VFIO interrupt mapping setting in eth_ngbevf_dev_init( )
+ * is not cleared, it will fail when following rte_intr_enable( ) tries
+ * to map Rx queue interrupt to other VFIO vectors.
+ * So clear uio/vfio intr/evevnfd first to avoid failure.
+ */
+ rte_intr_disable(intr_handle);
+
+ rte_intr_enable(intr_handle);
+
+ /* Re-enable interrupt for VF */
+ ngbevf_intr_enable(dev);
+
+ /*
+ * Update link status right before return, because it may
+ * start link configuration process in a separate thread.
+ */
+ ngbevf_dev_link_update(dev, 0);
+
+ hw->adapter_stopped = false;
+
+ return 0;
+}
+
+static int
+ngbevf_dev_stop(struct rte_eth_dev *dev)
+{
+ struct ngbe_hw *hw = ngbe_dev_hw(dev);
+ struct ngbe_adapter *adapter = ngbe_dev_adapter(dev);
+ struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
+ struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
+
+ if (hw->adapter_stopped)
+ return 0;
+
+ PMD_INIT_FUNC_TRACE();
+
+ ngbevf_intr_disable(dev);
+
+ hw->adapter_stopped = 1;
+ hw->mac.stop_hw(hw);
+
+ /*
+ * Clear what we set, but we still keep shadow_vfta to
+ * restore after device starts
+ */
+ ngbevf_set_vfta_all(dev, 0);
+
+ /* Clear stored conf */
+ dev->data->scattered_rx = 0;
+
+ ngbe_dev_clear_queues(dev);
+
+ /* Clean datapath event and queue/vec mapping */
+ rte_intr_efd_disable(intr_handle);
+ rte_intr_vec_list_free(intr_handle);
+
+ adapter->rss_reta_updated = 0;
+
+ return 0;
+}
+
static int
ngbevf_dev_close(struct rte_eth_dev *dev)
{
struct ngbe_hw *hw = ngbe_dev_hw(dev);
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_intr_handle *intr_handle = pci_dev->intr_handle;
+ int ret;
PMD_INIT_FUNC_TRACE();
if (rte_eal_process_type() != RTE_PROC_PRIMARY)
@@ -566,6 +705,10 @@ ngbevf_dev_close(struct rte_eth_dev *dev)
hw->mac.reset_hw(hw);
+ ret = ngbevf_dev_stop(dev);
+
+ ngbe_dev_free_queues(dev);
+
/**
* Remove the VF MAC address ro ensure
* that the VF traffic goes to the PF
@@ -586,7 +729,24 @@ ngbevf_dev_close(struct rte_eth_dev *dev)
rte_intr_callback_unregister(intr_handle,
ngbevf_dev_interrupt_handler, dev);
- return 0;
+ return ret;
+}
+
+/*
+ * Reset VF device
+ */
+static int
+ngbevf_dev_reset(struct rte_eth_dev *dev)
+{
+ int ret;
+
+ ret = eth_ngbevf_dev_uninit(dev);
+ if (ret)
+ return ret;
+
+ ret = eth_ngbevf_dev_init(dev);
+
+ return ret;
}
static void ngbevf_set_vfta_all(struct rte_eth_dev *dev, bool on)
@@ -1077,12 +1237,16 @@ ngbevf_dev_interrupt_handler(void *param)
*/
static const struct eth_dev_ops ngbevf_eth_dev_ops = {
.dev_configure = ngbevf_dev_configure,
+ .dev_start = ngbevf_dev_start,
+ .dev_stop = ngbevf_dev_stop,
.link_update = ngbevf_dev_link_update,
.stats_get = ngbevf_dev_stats_get,
.xstats_get = ngbevf_dev_xstats_get,
.stats_reset = ngbevf_dev_stats_reset,
.xstats_reset = ngbevf_dev_stats_reset,
.xstats_get_names = ngbevf_dev_xstats_get_names,
+ .dev_close = ngbevf_dev_close,
+ .dev_reset = ngbevf_dev_reset,
.promiscuous_enable = ngbevf_dev_promiscuous_enable,
.promiscuous_disable = ngbevf_dev_promiscuous_disable,
.allmulticast_enable = ngbevf_dev_allmulticast_enable,
@@ -1092,6 +1256,10 @@ static const struct eth_dev_ops ngbevf_eth_dev_ops = {
.vlan_filter_set = ngbevf_vlan_filter_set,
.vlan_strip_queue_set = ngbevf_vlan_strip_queue_set,
.vlan_offload_set = ngbevf_vlan_offload_set,
+ .rx_queue_setup = ngbe_dev_rx_queue_setup,
+ .rx_queue_release = ngbe_dev_rx_queue_release,
+ .tx_queue_setup = ngbe_dev_tx_queue_setup,
+ .tx_queue_release = ngbe_dev_tx_queue_release,
.rx_queue_intr_enable = ngbevf_dev_rx_queue_intr_enable,
.rx_queue_intr_disable = ngbevf_dev_rx_queue_intr_disable,
.mac_addr_add = ngbevf_add_mac_addr,
--
2.21.0.windows.1