From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (unknown [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0F4FF4609E;
Fri, 17 Jan 2025 15:21:07 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9ECAC42E6B;
Fri, 17 Jan 2025 15:20:48 +0100 (CET)
Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com
[209.85.208.182])
by mails.dpdk.org (Postfix) with ESMTP id C461D42E6B;
Fri, 17 Jan 2025 15:20:46 +0100 (CET)
Received: by mail-lj1-f182.google.com with SMTP id
38308e7fff4ca-30036310158so17890191fa.0;
Fri, 17 Jan 2025 06:20:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1737123646; x=1737728446; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=mTvxu63NkMhqqLURP/UKITbG3ss6ZT2T9c3CInPZaPI=;
b=TZYEiAPJ++uKKzA/qlT37o7KhFpHgbEzgEVPn0bYWXd+HnDp7eGYP6X+HSv5NtsyDG
As1yeJHHl/EnIqmPoI7JWoS/aInYJ/RK+h6+OK/aKu57B1BN2+/HmmK6abOn8gQI/V+u
XA63UEeNjt4DhmomDYD3DRHTPNf9BTpnpnuSW54AY7CjEy3oxdU0GgmGgrXSap18jKTT
mkG+797T/CwLaTugWU8r4/CdO49ffWZT2OjfYMm4mXv7VfCzIOsxVWE8KTHZzBLkyMzn
g4/sqknzsJF0euvbHPFeyWGkKgSOAPHKZycVJRBtbeeQ9NHGAz01Liobkf9OJ2p6A2G+
VqqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1737123646; x=1737728446;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=mTvxu63NkMhqqLURP/UKITbG3ss6ZT2T9c3CInPZaPI=;
b=R6ZlSv7ztgFcn2F27C+xVHwTMeKbC9zMCKoow0xBE8pKhQo7j9qItebc0QmOwSaOf1
x8BaJfsxHrmoRmiweiNm/y9zX7YviNOTgunXV1K7wBnSw75uw49TcYYdkyfwtUUP/3ce
tvVjyUI6aJxutttM5ED695oTcEZ9uCVAocG2QgKV7pio1HVmMVwX4+KQxfr1BoOhaG6n
1QAANSTUS/6fFTZgl81QOMXQLEOgTr6DcbMM2dzy+FFxsq9Vr3eDY/c2RV/tViPcHJoL
HRT9k188foAw2oDxHPH1HUwP2djV2DdMtkBa84zb2ZiVCmOLT8JC9FzqdUhUJ3GIYdsA
86NA==
X-Forwarded-Encrypted: i=1;
AJvYcCUyw8K9gqoRlM2pe9nUq7jpgQi9JFiUPjTVUgKPG0NtP7C732AYkrxdk+yBCQZGkAFDDUxCW3Q=@dpdk.org
X-Gm-Message-State: AOJu0Yy5i/9reciEqrHrI4AJM4uH6cACshuuMVYM0K3T+4RcpV5eg4Uu
BivKLP50Q04auLm4YZ3ljdr5XP24gGew8QtW/jp75Pba5xKRkcWN
X-Gm-Gg: ASbGncs1mhPVZMEbOS4qdmD8h2eYD6DVieKCTvKEGdXEWtOkX5nz9J6OmexynM+iUzY
K/Y2+cOP23w59w1XS53nEXFCxuNP+IB/FwyjMkWqRJnZ/F4OwYsjAU3qDFNNTrMYOow203vAC0M
oa4Rl+RURcZIbtSaHItYOcbrR2/ya43TpMCd7654OOYjj1KdxL91q81zBRFZTujb8C8uxfcpsBg
A7Jy/l0KCfbtgeJ18QSAKWLeFZNR5budp9HlWsQPl7vxRw85pPDXQzX3jiXTayYnw33UrQPz3K9
sa1EzS5Z8OqT5z/4n/HcrnM/+/Ar
X-Google-Smtp-Source: AGHT+IFgy2ANlOsq6B5ZBnwGRcnJf7KHzayScmqT3WI+HD5ivwHSwtVP6RfgV8cZwTUtbL2X+TXCpg==
X-Received: by 2002:a2e:a544:0:b0:302:4a61:8bd3 with SMTP id
38308e7fff4ca-3072ca5e1b2mr10099651fa.7.1737123645738;
Fri, 17 Jan 2025 06:20:45 -0800 (PST)
Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru.
[109.173.43.194]) by smtp.gmail.com with ESMTPSA id
38308e7fff4ca-3072a502d23sm4305161fa.103.2025.01.17.06.20.42
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Jan 2025 06:20:44 -0800 (PST)
Date: Fri, 17 Jan 2025 17:20:41 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] test: improve resiliency of malloc autotest
Message-ID: <20250117172041.6bfacba7@sovereign>
In-Reply-To: <20250117135239.1980838-1-bruce.richardson@intel.com>
References: <20250117125912.985475-1-bruce.richardson@intel.com>
<20250117135239.1980838-1-bruce.richardson@intel.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
2025-01-17 13:52 (UTC+0000), Bruce Richardson:
> The test case "test_multi_alloc_statistics" was brittle in that it did
> some allocations and frees and then checked statistics without
> considering the initial state of the malloc heaps. This meant that,
> depending on what allocations/frees were done beforehand, the test can
> sometimes fail.
>
> We can improve resiliency by running the test using a new malloc heap,
> which means it is unaffected by any previous allocations.
>
> Bugzilla ID: 1579
> Fixes: a40a1f8231b4 ("app: various tests update")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2:
> * removed unnecessary extra include
> * only added new code for non-windows, since using mmap for allocation.
Why is it necessary to use `mmap()` and not portable `malloc()`?
Even the comment in the patch says "malloc" :)