From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 995D7460C1;
Mon, 20 Jan 2025 10:44:40 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 379FA4068A;
Mon, 20 Jan 2025 10:44:06 +0100 (CET)
Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130])
by mails.dpdk.org (Postfix) with ESMTP id 4D1C740A81
for <dev@dpdk.org>; Mon, 20 Jan 2025 10:44:00 +0100 (CET)
X-QQ-mid: bizesmtp86t1737366235t1of56zm
X-QQ-Originating-IP: dIiEodtOQkxJbT5HclypADYUN/NY9K8q8qH9i/SSKZE=
Received: from DSK-zaiyuwang.trustnetic.com ( [115.197.136.137])
by bizesmtp.qq.com (ESMTP) with
id ; Mon, 20 Jan 2025 17:43:54 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 5818378702202210211
From: Zaiyu Wang <zaiyuwang@trustnetic.com>
To: dev@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [PATCH v4 10/15] net/ngbe: add link update ops for VF device
Date: Mon, 20 Jan 2025 17:42:36 +0800
Message-Id: <20250120094242.1844-11-zaiyuwang@trustnetic.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20250120094242.1844-1-zaiyuwang@trustnetic.com>
References: <20250109040227.1016-1-zaiyuwang@trustnetic.com>
<20250120094242.1844-1-zaiyuwang@trustnetic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1
X-QQ-XMAILINFO: MviyouKjmhfyOs3MsRivo6B24yIed1EGyvKwTjs+VxL/RS3bY5kBMmnz
IiAMA2hNQOnj0p5bIR/KkbyXgbc79raXageIzTs6/+iblFnCWSk2jqpJUIqLYalsUB9OeDR
03isB5elYVHGZ/UmeFRDUq6Nab902ZRcMgvjc4xsiWy1aqeWTwb26n+Enwz2Z5jxoQ0nJ4U
TZDsqT3r5O691eSed1gfokyfVQa7R7TMQeuG3qQFGWDGBTzlEDJPA+esjuJsmsqN4zmyhPe
PCwPRKLUq/S9o7U4JGnJjvej6byPx5Q0ug2B6QzKFiRf1jbpwA2GxxPbUTRPvTcBJsjXv0N
Qj2ByLXVpnpHvHAgZTp7FYgzeJqlC8IjuoveWMlf1rwGcmssrhTtFG1Hp6XZbePJ5NUsvgN
5mrYVIHuzxKVsgAczaso3HPzqj/wnpBq15fry76kfFNGF6C0Dh+SSOr3YKbX5PUrqpCctCn
eOEK1OeoKyawBFyjx0eh03zMGgZdIkwlnqvXwPMxEjiggWrPjzBJIMMASXtGiVsjFIR3dIG
FyMn2iLJ/1raahcpx3xNlyx2/BkrXNv4KLmlFaueSgfjr1O2LiCBmOh3+/Y7tSBeL+GnczP
BXw+9rwGRPGTxkIuDYd8J9t4Aq/2dAFtavHbxe7gjzLoPTe5tVjFctLgFue8EzeJdz2MmZV
SMqlhrPhFpYejnFg16KGfoJ6SDaWmK7X2ZExEGqsLOunjAMowbPLXVNRdixpYr/MS1l7q2/
WHbfFNL6U6qevzbWbxPthwDYG3zyEuHwm4KQTztYSKFQHt7LBU7gh+JK3SPF3GCMLaxgJCy
H1fup4zVr09A6t7gBVx7GRbqeBsu4a5/R/AicJnbdaqzeAi+XjiQece3IrijlkhwHwjcsrF
T9pRrJPRUVGNR79lYtm3hInFqOSq/4Fp6zJvx3eT4mTbeNs4vCPsqZo2AGrcqM41TICl00A
+2gzpy00sc++6nh58D9Ye3Xm2B7FkbBMjIX+NXKnX9w4BvnS3Qu3rMu9QoXKaHahuFdbBm6
gvAYu6EaHVrdnhZVGSe8/k/wjQs3Bl6xMVajjovW4bCeT3DWje
X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add support to check link feature for VF device, including link speed,
duplex mode and link state.
Signed-off-by: Zaiyu Wang <zaiyuwang@trustnetic.com>
---
doc/guides/nics/features/ngbe_vf.ini | 1 +
drivers/net/ngbe/base/ngbe_vf.c | 96 ++++++++++++++++++++++++++++
drivers/net/ngbe/base/ngbe_vf.h | 2 +
drivers/net/ngbe/ngbe_ethdev_vf.c | 9 +++
4 files changed, 108 insertions(+)
diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini
index d6f2a1d726..8e66565e6a 100644
--- a/doc/guides/nics/features/ngbe_vf.ini
+++ b/doc/guides/nics/features/ngbe_vf.ini
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+Link status = Y
Unicast MAC filter = Y
Rx interrupt = Y
MTU update = Y
diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c
index 039f87423d..52b86afc56 100644
--- a/drivers/net/ngbe/base/ngbe_vf.c
+++ b/drivers/net/ngbe/base/ngbe_vf.c
@@ -337,6 +337,99 @@ s32 ngbevf_set_uc_addr_vf(struct ngbe_hw *hw, u32 index, u8 *addr)
return ret_val;
}
+/**
+ * ngbe_check_mac_link_vf - Get link/speed status
+ * @hw: pointer to hardware structure
+ * @speed: pointer to link speed
+ * @link_up: true is link is up, false otherwise
+ * @autoneg_wait_to_complete: true when waiting for completion is needed
+ *
+ * Reads the links register to determine if link is up and the current speed
+ **/
+s32 ngbe_check_mac_link_vf(struct ngbe_hw *hw, u32 *speed,
+ bool *link_up, bool wait_to_complete)
+{
+ /**
+ * for a quick link status checking, wait_to_compelet == 0,
+ * skip PF link status checking
+ */
+ bool no_pflink_check = 0;
+ struct ngbe_mbx_info *mbx = &hw->mbx;
+ struct ngbe_mac_info *mac = &hw->mac;
+ s32 ret_val = 0;
+ u32 links_reg;
+ u32 in_msg = 0;
+
+ UNREFERENCED_PARAMETER(wait_to_complete);
+
+ /* If we were hit with a reset drop the link */
+ if (!mbx->check_for_rst(hw, 0) || !mbx->timeout)
+ mac->get_link_status = true;
+
+ if (!mac->get_link_status)
+ goto out;
+
+ /* if link status is down no point in checking to see if pf is up */
+ links_reg = rd32(hw, NGBE_VFSTATUS);
+ if (!(links_reg & NGBE_VFSTATUS_BW_MASK))
+ goto out;
+
+ /* for SFP+ modules and DA cables it can take up to 500usecs
+ * before the link status is correct
+ */
+ if (mac->type == ngbe_mac_em_vf) {
+ if (po32m(hw, NGBE_VFSTATUS, NGBE_VFSTATUS_BW_MASK,
+ 0, NULL, 5, 100))
+ goto out;
+ }
+
+ if (links_reg & NGBE_VFSTATUS_BW_1G)
+ *speed = NGBE_LINK_SPEED_1GB_FULL;
+ else if (links_reg & NGBE_VFSTATUS_BW_100M)
+ *speed = NGBE_LINK_SPEED_100M_FULL;
+ else if (links_reg & NGBE_VFSTATUS_BW_10M)
+ *speed = NGBE_LINK_SPEED_10M_FULL;
+ else
+ *speed = NGBE_LINK_SPEED_UNKNOWN;
+
+ if (no_pflink_check) {
+ if (*speed == NGBE_LINK_SPEED_UNKNOWN)
+ mac->get_link_status = true;
+ else
+ mac->get_link_status = false;
+
+ goto out;
+ }
+
+ /* if the read failed it could just be a mailbox collision, best wait
+ * until we are called again and don't report an error
+ */
+ if (mbx->read(hw, &in_msg, 1, 0))
+ goto out;
+
+ if (!(in_msg & NGBE_VT_MSGTYPE_CTS)) {
+ /* msg is not CTS and is NACK we must have lost CTS status */
+ if (in_msg & NGBE_VT_MSGTYPE_NACK)
+ ret_val = -1;
+ goto out;
+ }
+
+ /* the pf is talking, if we timed out in the past we reinit */
+ if (!mbx->timeout) {
+ ret_val = -1;
+ goto out;
+ }
+
+ /* if we passed all the tests above then the link is up and we no
+ * longer need to check for link
+ */
+ mac->get_link_status = false;
+
+out:
+ *link_up = !mac->get_link_status;
+ return ret_val;
+}
+
/**
* ngbevf_rlpml_set_vf - Set the maximum receive packet length
* @hw: pointer to the HW structure
@@ -471,6 +564,9 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw)
mac->get_mac_addr = ngbe_get_mac_addr_vf;
mac->negotiate_api_version = ngbevf_negotiate_api_version;
+ /* Link */
+ mac->check_link = ngbe_check_mac_link_vf;
+
/* RAR, Multicast, VLAN */
mac->set_rar = ngbe_set_rar_vf;
mac->set_uc_addr = ngbevf_set_uc_addr_vf;
diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h
index 596f41dcb0..5cf225dd35 100644
--- a/drivers/net/ngbe/base/ngbe_vf.h
+++ b/drivers/net/ngbe/base/ngbe_vf.h
@@ -17,6 +17,8 @@ s32 ngbe_start_hw_vf(struct ngbe_hw *hw);
s32 ngbe_reset_hw_vf(struct ngbe_hw *hw);
s32 ngbe_stop_hw_vf(struct ngbe_hw *hw);
s32 ngbe_get_mac_addr_vf(struct ngbe_hw *hw, u8 *mac_addr);
+s32 ngbe_check_mac_link_vf(struct ngbe_hw *hw, u32 *speed,
+ bool *link_up, bool autoneg_wait_to_complete);
s32 ngbe_set_rar_vf(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq,
u32 enable_addr);
s32 ngbevf_set_uc_addr_vf(struct ngbe_hw *hw, u32 index, u8 *addr);
diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c
index e1ba8b02d2..01e9d5d8ee 100644
--- a/drivers/net/ngbe/ngbe_ethdev_vf.c
+++ b/drivers/net/ngbe/ngbe_ethdev_vf.c
@@ -18,6 +18,8 @@
#define NGBEVF_PMD_NAME "rte_ngbevf_pmd" /* PMD name */
static int ngbevf_dev_close(struct rte_eth_dev *dev);
+static int ngbevf_dev_link_update(struct rte_eth_dev *dev,
+ int wait_to_complete);
static void ngbevf_intr_disable(struct rte_eth_dev *dev);
static void ngbevf_intr_enable(struct rte_eth_dev *dev);
static int ngbevf_vlan_offload_config(struct rte_eth_dev *dev, int mask);
@@ -345,6 +347,12 @@ ngbevf_dev_info_get(struct rte_eth_dev *dev,
return 0;
}
+static int
+ngbevf_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
+{
+ return ngbe_dev_link_update_share(dev, wait_to_complete);
+}
+
static void
ngbevf_intr_disable(struct rte_eth_dev *dev)
{
@@ -939,6 +947,7 @@ ngbevf_dev_interrupt_handler(void *param)
*/
static const struct eth_dev_ops ngbevf_eth_dev_ops = {
.dev_configure = ngbevf_dev_configure,
+ .link_update = ngbevf_dev_link_update,
.promiscuous_enable = ngbevf_dev_promiscuous_enable,
.promiscuous_disable = ngbevf_dev_promiscuous_disable,
.allmulticast_enable = ngbevf_dev_allmulticast_enable,
--
2.21.0.windows.1