From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 82E1F460C1;
Mon, 20 Jan 2025 10:44:57 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6DB3B40DD5;
Mon, 20 Jan 2025 10:44:12 +0100 (CET)
Received: from smtpbguseast3.qq.com (smtpbguseast3.qq.com [54.243.244.52])
by mails.dpdk.org (Postfix) with ESMTP id E113C40DC9
for <dev@dpdk.org>; Mon, 20 Jan 2025 10:44:07 +0100 (CET)
X-QQ-mid: bizesmtp86t1737366242tsp4iyeb
X-QQ-Originating-IP: 0g2xvR0UkzB7jXd9B4ap0QyQEt3tmcaCwQwgqLOiLtU=
Received: from DSK-zaiyuwang.trustnetic.com ( [115.197.136.137])
by bizesmtp.qq.com (ESMTP) with
id ; Mon, 20 Jan 2025 17:44:01 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 14997177396650096811
From: Zaiyu Wang <zaiyuwang@trustnetic.com>
To: dev@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [PATCH v4 13/15] net/ngbe: add multicast MAC filter ops for VF device
Date: Mon, 20 Jan 2025 17:42:39 +0800
Message-Id: <20250120094242.1844-14-zaiyuwang@trustnetic.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20250120094242.1844-1-zaiyuwang@trustnetic.com>
References: <20250109040227.1016-1-zaiyuwang@trustnetic.com>
<20250120094242.1844-1-zaiyuwang@trustnetic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1
X-QQ-XMAILINFO: Ngk7ShESHkQuxebhBEsiO24IIb0jMxKgOE3z9rfk37yFLirOj/3hQ9vt
srSLNeoq9HWtDU3OqdSjzu5EJxKETuWXskTHBOP9zFDkyQLDQjy8KH3BAFPFiQaObKvQ4x/
GKxfIhUXhVidvDJSnfz1WNTBVb1ZHaqu6a5fFnz8vaPXA8t6c/SYcHrm9l3AcCmT0qijpjy
tb2PzCGr+wraUdsC/30I45kF1+u/EezdR59s85KQ9EigZmepgW1uxkEPnM7T0yhx56K1zV7
6nFn/0ScHlfziwwv+m9tgeYCL7GqgdX+ddu5Y8kvR40wiUdIjpl8La/s8lN9P8zu3FXedQg
eWIHU9COUFRQnHxpNEOWMeGsGLy4DA4VIZMTVSKW2Rq8NIOGu56Ng3HpvXGSWn69EB+ac+6
EmiC+vvlFXdB6wHb0sXcGbkU2rhkx7n5m/bQoexnyzOFqDrP/jPYYayx1wcnQt2cg5oONqi
xLAA2MkJsMeb5EKNnVVILHCk6Lb6M2/JNgmBfU9d1+jZCXZZqBSA2V1Giv+yjfOo32tYx3F
iBGjqKUvYssG79Sc/9F0UYqpLU/w38ktopcOcJLDV/YA55pD+mjEJ3/1sgIunNqb5X5C5hW
lXgbDeyeeZ6h5HLvFNLcs7YLXDJ0oQ8qm/m2iP81zR20fm+74LVv96C+dbz1lsAqBZlVon5
cxRTsQTSy2YzgpasZLmH0sD7lUVvbtWvGab76cKIusVmIefi7Nh8ER0M5KpLN4z4vxNID41
ojZDVsu7Hq/F2jkhZLkaGPitQQRpec6Fyp7ysUm8kloUPBqB3dcUqexLOX0j9OjYjdj0/Gt
jKBIvtpxkdBB+116XpkKedtHxyUnoorcP1VQErxZUIMqeePiitDTkf5QT9Jsbo/vRgWDPDk
9x3Jqw7ORFMeqUDVIwdFHjEmAy+T8ikPRD0HQtlrWUuiehLUOF+bJdrdXwyyNX/P5mXDs20
2Ie3ETv8N3KN4Z+VKPTxkrhDVXVcOAG59iy9Q2T9o2yzvhSJntIzMZ+5oIt6C/FRd6Not0Y
caqzpnANAMJP7Y5F2E
X-QQ-XMRINFO: NI4Ajvh11aEj8Xl/2s1/T8w=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Add support to update multicast MAC filter.
Signed-off-by: Zaiyu Wang <zaiyuwang@trustnetic.com>
---
doc/guides/nics/features/ngbe_vf.ini | 1 +
drivers/net/ngbe/base/ngbe_vf.c | 81 ++++++++++++++++++++++++++++
drivers/net/ngbe/base/ngbe_vf.h | 3 ++
3 files changed, 85 insertions(+)
diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini
index 11a9105abc..3c54047fd8 100644
--- a/doc/guides/nics/features/ngbe_vf.ini
+++ b/doc/guides/nics/features/ngbe_vf.ini
@@ -6,6 +6,7 @@
[Features]
Link status = Y
Unicast MAC filter = Y
+Multicast MAC filter = Y
Rx interrupt = Y
MTU update = Y
Scattered Rx = Y
diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c
index 52b86afc56..e7b94cd44e 100644
--- a/drivers/net/ngbe/base/ngbe_vf.c
+++ b/drivers/net/ngbe/base/ngbe_vf.c
@@ -179,6 +179,39 @@ s32 ngbe_stop_hw_vf(struct ngbe_hw *hw)
return 0;
}
+/**
+ * ngbe_mta_vector - Determines bit-vector in multicast table to set
+ * @hw: pointer to hardware structure
+ * @mc_addr: the multicast address
+ **/
+STATIC s32 ngbe_mta_vector(struct ngbe_hw *hw, u8 *mc_addr)
+{
+ u32 vector = 0;
+
+ switch (hw->mac.mc_filter_type) {
+ case 0: /* use bits [47:36] of the address */
+ vector = ((mc_addr[4] >> 4) | (((u16)mc_addr[5]) << 4));
+ break;
+ case 1: /* use bits [46:35] of the address */
+ vector = ((mc_addr[4] >> 3) | (((u16)mc_addr[5]) << 5));
+ break;
+ case 2: /* use bits [45:34] of the address */
+ vector = ((mc_addr[4] >> 2) | (((u16)mc_addr[5]) << 6));
+ break;
+ case 3: /* use bits [43:32] of the address */
+ vector = ((mc_addr[4]) | (((u16)mc_addr[5]) << 8));
+ break;
+ default: /* Invalid mc_filter_type */
+ DEBUGOUT("MC filter type param set incorrectly");
+ ASSERT(0);
+ break;
+ }
+
+ /* vector can only be 12-bits or boundary will be exceeded */
+ vector &= 0xFFF;
+ return vector;
+}
+
STATIC s32 ngbevf_write_msg_read_ack(struct ngbe_hw *hw, u32 *msg,
u32 *retmsg, u16 size)
{
@@ -225,6 +258,53 @@ s32 ngbe_set_rar_vf(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq,
return ret_val;
}
+/**
+ * ngbe_update_mc_addr_list_vf - Update Multicast addresses
+ * @hw: pointer to the HW structure
+ * @mc_addr_list: array of multicast addresses to program
+ * @mc_addr_count: number of multicast addresses to program
+ * @next: caller supplied function to return next address in list
+ * @clear: unused
+ *
+ * Updates the Multicast Table Array.
+ **/
+s32 ngbe_update_mc_addr_list_vf(struct ngbe_hw *hw, u8 *mc_addr_list,
+ u32 mc_addr_count, ngbe_mc_addr_itr next,
+ bool clear)
+{
+ struct ngbe_mbx_info *mbx = &hw->mbx;
+ u32 msgbuf[NGBE_P2VMBX_SIZE];
+ u16 *vector_list = (u16 *)&msgbuf[1];
+ u32 vector;
+ u32 cnt, i;
+ u32 vmdq;
+
+ UNREFERENCED_PARAMETER(clear);
+
+ /* Each entry in the list uses 1 16 bit word. We have 30
+ * 16 bit words available in our HW msg buffer (minus 1 for the
+ * msg type). That's 30 hash values if we pack 'em right. If
+ * there are more than 30 MC addresses to add then punt the
+ * extras for now and then add code to handle more than 30 later.
+ * It would be unusual for a server to request that many multi-cast
+ * addresses except for in large enterprise network environments.
+ */
+
+ DEBUGOUT("MC Addr Count = %d", mc_addr_count);
+
+ cnt = (mc_addr_count > 30) ? 30 : mc_addr_count;
+ msgbuf[0] = NGBE_VF_SET_MULTICAST;
+ msgbuf[0] |= cnt << NGBE_VT_MSGINFO_SHIFT;
+
+ for (i = 0; i < cnt; i++) {
+ vector = ngbe_mta_vector(hw, next(hw, &mc_addr_list, &vmdq));
+ DEBUGOUT("Hash value = 0x%03X", vector);
+ vector_list[i] = (u16)vector;
+ }
+
+ return mbx->write_posted(hw, msgbuf, NGBE_P2VMBX_SIZE, 0);
+}
+
/**
* ngbevf_update_xcast_mode - Update Multicast mode
* @hw: pointer to the HW structure
@@ -570,6 +650,7 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw)
/* RAR, Multicast, VLAN */
mac->set_rar = ngbe_set_rar_vf;
mac->set_uc_addr = ngbevf_set_uc_addr_vf;
+ mac->update_mc_addr_list = ngbe_update_mc_addr_list_vf;
mac->update_xcast_mode = ngbevf_update_xcast_mode;
mac->set_vfta = ngbe_set_vfta_vf;
mac->set_rlpml = ngbevf_rlpml_set_vf;
diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h
index abe1655f8e..5621ca49cb 100644
--- a/drivers/net/ngbe/base/ngbe_vf.h
+++ b/drivers/net/ngbe/base/ngbe_vf.h
@@ -54,6 +54,9 @@ s32 ngbe_check_mac_link_vf(struct ngbe_hw *hw, u32 *speed,
s32 ngbe_set_rar_vf(struct ngbe_hw *hw, u32 index, u8 *addr, u32 vmdq,
u32 enable_addr);
s32 ngbevf_set_uc_addr_vf(struct ngbe_hw *hw, u32 index, u8 *addr);
+s32 ngbe_update_mc_addr_list_vf(struct ngbe_hw *hw, u8 *mc_addr_list,
+ u32 mc_addr_count, ngbe_mc_addr_itr next,
+ bool clear);
s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode);
s32 ngbe_set_vfta_vf(struct ngbe_hw *hw, u32 vlan, u32 vind,
bool vlan_on, bool vlvf_bypass);
--
2.21.0.windows.1