From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 83A8B460C1;
Mon, 20 Jan 2025 10:44:14 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 043444027A;
Mon, 20 Jan 2025 10:43:54 +0100 (CET)
Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193])
by mails.dpdk.org (Postfix) with ESMTP id CB8914069F
for <dev@dpdk.org>; Mon, 20 Jan 2025 10:43:50 +0100 (CET)
X-QQ-mid: bizesmtp86t1737366224tudaz7ym
X-QQ-Originating-IP: w4Zmo99+NMCXGM2LW0kaJHoCQTpf1alEa44TKpLrt2g=
Received: from DSK-zaiyuwang.trustnetic.com ( [115.197.136.137])
by bizesmtp.qq.com (ESMTP) with
id ; Mon, 20 Jan 2025 17:43:43 +0800 (CST)
X-QQ-SSF: 0000000000000000000000000000000
X-QQ-GoodBg: 0
X-BIZMAIL-ID: 514662785473986892
From: Zaiyu Wang <zaiyuwang@trustnetic.com>
To: dev@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>, Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [PATCH v4 05/15] net/ngbe: add set MTU ops for VF device
Date: Mon, 20 Jan 2025 17:42:31 +0800
Message-Id: <20250120094242.1844-6-zaiyuwang@trustnetic.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20250120094242.1844-1-zaiyuwang@trustnetic.com>
References: <20250109040227.1016-1-zaiyuwang@trustnetic.com>
<20250120094242.1844-1-zaiyuwang@trustnetic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-QQ-SENDSIZE: 520
Feedback-ID: bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1
X-QQ-XMAILINFO: NpzNf8JHXbEIuhgObkh8xaABAamjWIOVHiCs5xtiJAAlj19ydprAp3t/
J0bNyObc6b9WHVoyisf1YKMA48sEJ6iBng/N4C1fT4Jtbvt0KI2aKdSXjv2v/F6pEvf6jhj
++Xnp5w6KWxMVExx/lLrf9Q+7nVeRY5vh/WZcUX0bBq8iAeECrP9W36yexp9eafXkRtnWqu
MTQAIb7v6zrmSgB/sPKTTdbYjnku4ZuF7bYHpfRj2K6cYDaTxR3eyfblwpN8rQ2Kqsb8r6e
8q9UwK5QApjUzYe9WOugfdU4mnpbkIwPtEhrubtNNH/MzgG1l/yiUBK/SB4q1Fc46n1NOP7
dTNB/nUGLDqlI+dfAbCjyIgnPY3bUyLpvUgqUfNX0dsYHQ7v4JacXSBNp52DdZ4waO0Hxi/
IOxkEr8txNhbDOEIndtqB6YYOzM1GhaganhocT4I5gg69GCgYp/6WMs5vZL6GHlvA0N2gpv
Sr8esl40R2Rslcse1ptMVHjtdkTNy7eEvnfBgDBCDCd+7WgYo4jHSw92yNlEsvCKVNDyfPj
JN/goB95DGS4TbdU3hINn66UrZ4BfpMb2qhvnlunG0G6qJauLcj2iFMD3Pb6SxE8UbOSc2r
rFzSW0zBFXPgNUpNyTOp3S4igWJXq4XrXtk6tQ9es8wXWVz0UrbYWk9jjfcMOpUk/JPvdcZ
wEiLQhuZuAAGjXV9X3UOIjmcNDWcSxIswA+lR7wu4nNuUCl8J+LWwgEumlHweGEeamKLfJ+
a/Aiin0iDhGAKxgOP6FG54QNEUWSleODDN1tPa35erVBrNIQS5GJzCBg570yne+n36Grhlj
9vbfpnUKVb6D7I/8rH91LfkAlb5/OlthRb8Hs0vJqfUdPTUJIRgbW4bQU68oXPXgckNzomv
SfBXWT+ejARDLiWcGNE3Yrsb85lO3851IONvka98hicUfSVjp1baQi08A/kNq7nH0aTGQ4i
8xYcdWPapOnecZ2reoH5JK99lDDru2IWfgKnW8Znnxcoo1w==
X-QQ-XMRINFO: NyFYKkN4Ny6FSmKK/uo/jdU=
X-QQ-RECHKSPAM: 0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Support to update MTU for VF device.
Signed-off-by: Zaiyu Wang <zaiyuwang@trustnetic.com>
---
doc/guides/nics/features/ngbe_vf.ini | 1 +
drivers/net/ngbe/base/ngbe_type.h | 1 +
drivers/net/ngbe/base/ngbe_vf.c | 24 +++++++++++++++++++
drivers/net/ngbe/base/ngbe_vf.h | 1 +
drivers/net/ngbe/ngbe_ethdev_vf.c | 36 ++++++++++++++++++++++++++++
5 files changed, 63 insertions(+)
diff --git a/doc/guides/nics/features/ngbe_vf.ini b/doc/guides/nics/features/ngbe_vf.ini
index ba12357255..f2f2ac3881 100644
--- a/doc/guides/nics/features/ngbe_vf.ini
+++ b/doc/guides/nics/features/ngbe_vf.ini
@@ -4,6 +4,7 @@
; Refer to default.ini for the full list of available PMD features.
;
[Features]
+MTU update = Y
Promiscuous mode = Y
Allmulticast mode = Y
CRC offload = P
diff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h
index 29dcd5f912..f780b92efa 100644
--- a/drivers/net/ngbe/base/ngbe_type.h
+++ b/drivers/net/ngbe/base/ngbe_type.h
@@ -352,6 +352,7 @@ struct ngbe_mac_info {
void (*set_vlan_anti_spoofing)(struct ngbe_hw *hw,
bool enable, int vf);
s32 (*update_xcast_mode)(struct ngbe_hw *hw, int xcast_mode);
+ s32 (*set_rlpml)(struct ngbe_hw *hw, u16 max_size);
/* Flow Control */
s32 (*fc_enable)(struct ngbe_hw *hw);
diff --git a/drivers/net/ngbe/base/ngbe_vf.c b/drivers/net/ngbe/base/ngbe_vf.c
index ccf7148b9c..c0436c7b8a 100644
--- a/drivers/net/ngbe/base/ngbe_vf.c
+++ b/drivers/net/ngbe/base/ngbe_vf.c
@@ -228,6 +228,29 @@ s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode)
return 0;
}
+/**
+ * ngbevf_rlpml_set_vf - Set the maximum receive packet length
+ * @hw: pointer to the HW structure
+ * @max_size: value to assign to max frame size
+ **/
+s32 ngbevf_rlpml_set_vf(struct ngbe_hw *hw, u16 max_size)
+{
+ u32 msgbuf[2];
+ s32 retval;
+
+ msgbuf[0] = NGBE_VF_SET_LPE;
+ msgbuf[1] = max_size;
+
+ retval = ngbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);
+ if (retval)
+ return retval;
+ if ((msgbuf[0] & NGBE_VF_SET_LPE) &&
+ (msgbuf[0] & NGBE_VT_MSGTYPE_NACK))
+ return NGBE_ERR_MBX;
+
+ return 0;
+}
+
/**
* ngbevf_negotiate_api_version - Negotiate supported API version
* @hw: pointer to the HW structure
@@ -339,6 +362,7 @@ s32 ngbe_init_ops_vf(struct ngbe_hw *hw)
mac->negotiate_api_version = ngbevf_negotiate_api_version;
mac->update_xcast_mode = ngbevf_update_xcast_mode;
+ mac->set_rlpml = ngbevf_rlpml_set_vf;
mac->max_tx_queues = 1;
mac->max_rx_queues = 1;
diff --git a/drivers/net/ngbe/base/ngbe_vf.h b/drivers/net/ngbe/base/ngbe_vf.h
index 79891e8389..a64de9d332 100644
--- a/drivers/net/ngbe/base/ngbe_vf.h
+++ b/drivers/net/ngbe/base/ngbe_vf.h
@@ -17,6 +17,7 @@ s32 ngbe_start_hw_vf(struct ngbe_hw *hw);
s32 ngbe_reset_hw_vf(struct ngbe_hw *hw);
s32 ngbe_stop_hw_vf(struct ngbe_hw *hw);
s32 ngbevf_update_xcast_mode(struct ngbe_hw *hw, int xcast_mode);
+s32 ngbevf_rlpml_set_vf(struct ngbe_hw *hw, u16 max_size);
int ngbevf_negotiate_api_version(struct ngbe_hw *hw, int api);
int ngbevf_get_queues(struct ngbe_hw *hw, unsigned int *num_tcs,
unsigned int *default_tc);
diff --git a/drivers/net/ngbe/ngbe_ethdev_vf.c b/drivers/net/ngbe/ngbe_ethdev_vf.c
index 28000471b5..f53c17cc82 100644
--- a/drivers/net/ngbe/ngbe_ethdev_vf.c
+++ b/drivers/net/ngbe/ngbe_ethdev_vf.c
@@ -269,6 +269,41 @@ ngbevf_dev_close(struct rte_eth_dev *dev)
return 0;
}
+static int
+ngbevf_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
+{
+ struct ngbe_hw *hw;
+ uint32_t max_frame = mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
+ struct rte_eth_dev_data *dev_data = dev->data;
+
+ hw = ngbe_dev_hw(dev);
+
+ if (mtu < RTE_ETHER_MIN_MTU ||
+ max_frame > RTE_ETHER_MAX_JUMBO_FRAME_LEN)
+ return -EINVAL;
+
+ /* If device is started, refuse mtu that requires the support of
+ * scattered packets when this feature has not been enabled before.
+ */
+ if (dev_data->dev_started && !dev_data->scattered_rx &&
+ (max_frame + 2 * RTE_VLAN_HLEN >
+ dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM)) {
+ PMD_INIT_LOG(ERR, "Stop port first.");
+ return -EINVAL;
+ }
+
+ /*
+ * When supported by the underlying PF driver, use the NGBE_VF_SET_MTU
+ * request of the version 2.0 of the mailbox API.
+ * For now, use the NGBE_VF_SET_LPE request of the version 1.0
+ * of the mailbox API.
+ */
+ if (ngbevf_rlpml_set_vf(hw, max_frame))
+ return -EINVAL;
+
+ return 0;
+}
+
static int
ngbevf_dev_promiscuous_enable(struct rte_eth_dev *dev)
{
@@ -366,6 +401,7 @@ static const struct eth_dev_ops ngbevf_eth_dev_ops = {
.allmulticast_enable = ngbevf_dev_allmulticast_enable,
.allmulticast_disable = ngbevf_dev_allmulticast_disable,
.dev_infos_get = ngbevf_dev_info_get,
+ .mtu_set = ngbevf_dev_set_mtu,
};
RTE_PMD_REGISTER_PCI(net_ngbe_vf, rte_ngbevf_pmd);
--
2.21.0.windows.1