From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH] net/i40e: reduce log level of global register update msg
Date: Tue, 21 Jan 2025 16:35:39 +0000 [thread overview]
Message-ID: <20250121163539.2308702-1-bruce.richardson@intel.com> (raw)
The modifying of a global register value, which has an affect on multiple
ports is an important change to HW. However, the actual details of that
change is only relevant to developers and not general users. Therefore
reduce the log level from "warning" - which implies something is wrong -
to "info".
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 30dcdc68a8..39b6e28aad 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -750,7 +750,7 @@ i40e_write_global_rx_ctl(struct i40e_hw *hw, uint32_t reg_addr,
ori_reg_val = i40e_read_rx_ctl(hw, reg_addr);
i40e_write_rx_ctl(hw, reg_addr, reg_val);
if (ori_reg_val != reg_val)
- PMD_DRV_LOG(WARNING,
+ PMD_DRV_LOG(INFO,
"i40e device %s changed global register [0x%08x]."
" original: 0x%08x, new: 0x%08x",
dev->device->name, reg_addr, ori_reg_val, reg_val);
@@ -1352,7 +1352,7 @@ i40e_aq_debug_write_global_register(struct i40e_hw *hw,
}
if (ori_reg_val != reg_val)
- PMD_DRV_LOG(WARNING,
+ PMD_DRV_LOG(INFO,
"i40e device %s changed global register [0x%08x]."
" original: 0x%"PRIx64", after: 0x%"PRIx64,
dev->device->name, reg_addr, ori_reg_val, reg_val);
@@ -9774,7 +9774,7 @@ i40e_check_write_global_reg(struct i40e_hw *hw, uint32_t addr, uint32_t val)
if (reg != val) {
i40e_write_rx_ctl(hw, addr, val);
- PMD_DRV_LOG(WARNING,
+ PMD_DRV_LOG(INFO,
"i40e device %s changed global register [0x%08x]."
" original: 0x%08x, new: 0x%08x",
dev->device->name, addr, reg,
--
2.43.0
next reply other threads:[~2025-01-21 16:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 16:35 Bruce Richardson [this message]
2025-02-11 13:57 ` David Marchand
2025-02-17 14:56 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121163539.2308702-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).