From: Serhii Iliushyk <sil-plv@napatech.com>
To: dev@dpdk.org
Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com,
stephen@networkplumber.org
Subject: [PATCH v2 00/34] net/ntnic: bugfixes and refactoring
Date: Wed, 5 Feb 2025 11:45:09 +0100 [thread overview]
Message-ID: <20250205104548.1533554-1-sil-plv@napatech.com> (raw)
In-Reply-To: <20250121170814.3252171-2-sil-plv@napatech.com>
This patch set addresses fixing issues in the ntnic PMD driver.
Changes in this patch:
The issues detected by the Coverity Scan tool.
The problems that were detected by the internal tests.
Fix for Bug 1622: ntnic: using signals and threads:
https://bugs.dpdk.org/show_bug.cgi?id=1622.
The handling of signals within the PMD driver was removed.
For manipulation with all threads dedicated EAL API
(rte_thread_create_internal_control) is used.
Product by design requires usage of threads inside PMD driver.
Danylo Vodopianov (26):
net/ntnic: fix index verification
net/ntnic: add thread check return code
net/ntnic: add return code handling
net/ntnic: add array index verification
net/ntnic: fix realloc memory leak
net/ntnic: fix array index verification
net/ntnic: add var definition transparently
net/ntnic: add proper var freed
net/ntnic: remove unused code
net/ntnic: fix potentially overflow
net/ntnic: add null checking
net/ntnic: fix overflow issue
net/ntnic: fix untrusted loop bound
net/ntnic: add null checking
net/ntnic: move null checking
net/ntnic: fix var size
net/ntnic: fix var overflow
net/ntnic: remove unused code
net/ntnic: remove convert error func
net/ntnic: fix array verification
net/ntnic: fix memory leak
net/ntnic: remove unused code
net/ntnic: refactor RSS implementation
net/ntnic: fix age timeout recalculation into fpga unit
net/ntnic: rework age event generation
net/ntnic: fix group print
Oleksandr Kolomeiets (2):
net/ntnic: remove extra address-of operator
net/ntnic: remove extra check for null
Serhii Iliushyk (6):
net/ntnic: extend module mapping
net/ntnic: refactoring of the FPGA initialization
net/ntnic: remove shutdown thread
net/ntnic: add checks for action modify
net/ntnic: add IFR DROP counter
net/ntnic: remove tag EXPERIMENTAL
MAINTAINERS | 2 +-
.../net/ntnic/adapter/nt4ga_stat/nt4ga_stat.c | 18 +-
drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 10 +-
drivers/net/ntnic/include/create_elements.h | 1 -
drivers/net/ntnic/include/flow_api.h | 10 +-
drivers/net/ntnic/include/flow_api_engine.h | 2 +
drivers/net/ntnic/include/hw_mod_backend.h | 24 +-
drivers/net/ntnic/include/hw_mod_tpe_v3.h | 5 +
drivers/net/ntnic/include/ntnic_stat.h | 9 +
.../link_mgmt/link_100g/nt4ga_link_100g.c | 2 +-
drivers/net/ntnic/meson.build | 1 +
drivers/net/ntnic/nthw/core/nthw_fpga.c | 14 +-
drivers/net/ntnic/nthw/flow_api/flow_api.c | 83 +-
.../nthw/flow_api/flow_backend/flow_backend.c | 28 +-
drivers/net/ntnic/nthw/flow_api/flow_group.c | 26 +
.../net/ntnic/nthw/flow_api/flow_hsh_cfg.c | 661 +++++++++++++
.../net/ntnic/nthw/flow_api/flow_hsh_cfg.h | 17 +
.../ntnic/nthw/flow_api/hw_mod/hw_mod_flm.c | 14 +-
.../ntnic/nthw/flow_api/hw_mod/hw_mod_hsh.c | 19 +-
.../ntnic/nthw/flow_api/hw_mod/hw_mod_pdb.c | 18 +-
.../ntnic/nthw/flow_api/hw_mod/hw_mod_tpe.c | 58 +-
.../profile_inline/flow_api_hw_db_inline.c | 29 +-
.../profile_inline/flow_api_profile_inline.c | 925 +++---------------
.../profile_inline/flow_api_profile_inline.h | 8 +-
.../ntnic/nthw/flow_filter/flow_nthw_ifr.c | 32 +
.../ntnic/nthw/flow_filter/flow_nthw_ifr.h | 15 +-
.../ntnic/nthw/flow_filter/flow_nthw_rpp_lr.c | 10 +-
drivers/net/ntnic/nthw/stat/nthw_stat.c | 2 +
.../nthw/supported/nthw_fpga_mod_str_map.c | 24 +
drivers/net/ntnic/ntnic_ethdev.c | 69 +-
drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 155 ++-
drivers/net/ntnic/ntnic_mod_reg.h | 11 +-
drivers/net/ntnic/ntnic_xstats/ntnic_xstats.c | 10 +-
33 files changed, 1204 insertions(+), 1108 deletions(-)
create mode 100644 drivers/net/ntnic/nthw/flow_api/flow_hsh_cfg.c
create mode 100644 drivers/net/ntnic/nthw/flow_api/flow_hsh_cfg.h
--
2.45.0
next prev parent reply other threads:[~2025-02-05 10:46 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 17:07 [PATCH v1 00/31] " Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 01/31] net/ntnic: fix index verification Serhii Iliushyk
2025-02-05 10:45 ` Serhii Iliushyk [this message]
2025-02-05 10:45 ` [PATCH v2 01/34] " Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 02/34] net/ntnic: add thread check return code Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 03/34] net/ntnic: add return code handling Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 04/34] net/ntnic: add array index verification Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 05/34] net/ntnic: fix realloc memory leak Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 06/34] net/ntnic: fix array index verification Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 07/34] net/ntnic: add var definition transparently Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 08/34] net/ntnic: add proper var freed Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 09/34] net/ntnic: remove unused code Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 10/34] net/ntnic: fix potentially overflow Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 11/34] net/ntnic: add null checking Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 12/34] net/ntnic: fix overflow issue Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 13/34] net/ntnic: fix untrusted loop bound Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 14/34] net/ntnic: add null checking Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 15/34] net/ntnic: move " Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 16/34] net/ntnic: fix var size Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 17/34] net/ntnic: fix var overflow Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 18/34] net/ntnic: remove unused code Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 19/34] net/ntnic: remove convert error func Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 20/34] net/ntnic: fix array verification Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 21/34] net/ntnic: fix memory leak Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 22/34] net/ntnic: remove extra address-of operator Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 23/34] net/ntnic: remove extra check for null Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 24/34] net/ntnic: remove unused code Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 25/34] net/ntnic: refactor RSS implementation Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 26/34] net/ntnic: fix age timeout recalculation into fpga unit Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 27/34] net/ntnic: rework age event generation Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 28/34] net/ntnic: fix group print Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 29/34] net/ntnic: extend module mapping Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 30/34] net/ntnic: refactoring of the FPGA initialization Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 31/34] net/ntnic: remove shutdown thread Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 32/34] net/ntnic: add checks for action modify Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 33/34] net/ntnic: add IFR DROP counter Serhii Iliushyk
2025-02-05 10:45 ` [PATCH v2 34/34] net/ntnic: remove tag EXPERIMENTAL Serhii Iliushyk
2025-02-05 16:51 ` [PATCH v2 00/34] net/ntnic: bugfixes and refactoring Stephen Hemminger
2025-01-21 17:07 ` [PATCH v1 02/31] net/ntnic: add thread check return code Serhii Iliushyk
2025-01-21 18:24 ` Stephen Hemminger
2025-01-28 18:54 ` Stephen Hemminger
2025-01-21 17:07 ` [PATCH v1 03/31] net/ntnic: add return code handling Serhii Iliushyk
2025-01-21 18:30 ` Stephen Hemminger
2025-01-21 17:07 ` [PATCH v1 04/31] net/ntnic: add array index verification Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 05/31] net/ntnic: fix realloc memory leak Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 06/31] net/ntnic: fix array index verification Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 07/31] net/ntnic: add var definition transparently Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 08/31] net/ntnic: add proper var freed Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 09/31] net/ntnic: remove deadcode Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 10/31] net/ntnic: fix potentially overflow Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 11/31] net/ntnic: add null checking Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 12/31] net/ntnic: fix overflow issue Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 13/31] net/ntnic: fix untrusted loop bound Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 14/31] net/ntnic: add null checking Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 15/31] net/ntnic: move " Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 16/31] net/ntnic: fix var size Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 17/31] net/ntnic: fix var overflow Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 18/31] net/ntnic: remove dead code Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 19/31] net/ntnic: remove convert error func Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 20/31] net/ntnic: fix array verification Serhii Iliushyk
2025-01-21 17:07 ` [PATCH v1 21/31] net/ntnic: fix memory leak Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 22/31] net/ntnic: remove extra address-of operator Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 23/31] net/ntnic: remove extra check for null Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 24/31] net/ntnic: remove unused code Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 25/31] net/ntnic: refactor RSS implementation Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 26/31] net/ntnic: fix age timeout recalculation into fpga unit Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 27/31] net/ntnic: rework age event generation Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 28/31] net/ntnic: fix group print Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 29/31] net/ntnic: extend module mapping Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 30/31] net/ntnic: refactoring of the FPGA initialization Serhii Iliushyk
2025-01-21 17:08 ` [PATCH v1 31/31] net/ntnic: remove tag EXPERIMENTAL Serhii Iliushyk
2025-01-28 18:51 ` [PATCH v1 00/31] net/ntnic: bugfixes and refactoring Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205104548.1533554-1-sil-plv@napatech.com \
--to=sil-plv@napatech.com \
--cc=ckm@napatech.com \
--cc=dev@dpdk.org \
--cc=mko-plv@napatech.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).