From: Stephen Hemminger <stephen@networkplumber.org>
To: Shani Peretz <shperetz@nvidia.com>
Cc: <dev@dpdk.org>, "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v5 3/4] app/test: add tests to find devices
Date: Wed, 5 Feb 2025 17:03:23 -0800 [thread overview]
Message-ID: <20250205170323.026210bb@hermes.local> (raw)
In-Reply-To: <20250206000838.23428-4-shperetz@nvidia.com>
On Thu, 6 Feb 2025 02:08:37 +0200
Shani Peretz <shperetz@nvidia.com> wrote:
> +static struct rte_device *
> +create_pci_dev(const char *name)
> +{
> + int port_id;
> + struct rte_ether_addr mac_addr = {
> + .addr_bytes = {
> + 0x00, 0xFF, 0x00, 0xFF, 0x00, 0x00
> + }
> + };
> +
> + char pmd_name[RTE_ETH_NAME_MAX_LEN];
Why hardcode a MAC address, which could lead to future issues.
Instead use rte_eth_random_addr().
next prev parent reply other threads:[~2025-02-06 1:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 20:01 [PATCH] eal/common: fix inconsistent representation of PCI numbers Shani Peretz
2024-07-01 22:00 ` Stephen Hemminger
2024-07-08 16:51 ` [PATCH v3] " Shani Peretz
2024-07-12 13:49 ` David Marchand
2024-07-12 17:55 ` Thomas Monjalon
2025-01-29 8:54 ` [PATCH v4] bus: " Shani Peretz
2025-01-29 9:45 ` Bruce Richardson
2025-01-29 16:25 ` Stephen Hemminger
2025-02-05 16:36 ` Shani Peretz
2025-02-05 16:42 ` Stephen Hemminger
2025-02-05 17:37 ` Shani Peretz
2025-02-05 18:46 ` Stephen Hemminger
2025-02-05 20:16 ` Shani Peretz
2025-02-06 0:40 ` Stephen Hemminger
2025-01-29 17:17 ` Stephen Hemminger
2025-01-29 18:06 ` Bruce Richardson
2025-02-05 1:55 ` fengchengwen
2025-02-06 0:08 ` [PATCH v5 0/4] fix comparison between devices Shani Peretz
2025-02-06 0:08 ` [PATCH v5 1/4] bus/pci: fix registration of PCI device Shani Peretz
2025-02-06 0:08 ` [PATCH v5 2/4] lib: fix comparison between devices Shani Peretz
2025-02-06 0:08 ` [PATCH v5 3/4] app/test: add tests to find devices Shani Peretz
2025-02-06 1:03 ` Stephen Hemminger [this message]
2025-02-06 0:08 ` [PATCH v5 4/4] lib: change find device and cmp dev name functions Shani Peretz
2024-10-04 22:21 ` [PATCH] eal/common: fix inconsistent representation of PCI numbers Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205170323.026210bb@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=shperetz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).