From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEC93461B8; Fri, 7 Feb 2025 09:33:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CEDD8427B8; Fri, 7 Feb 2025 09:33:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 891AE427B7 for ; Fri, 7 Feb 2025 09:33:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738917189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pgGdQIfzfTGXcmt33fxUK3CQYs1OJyllsC6ileAvHyM=; b=PwWHIkBHCX4g9WJwKMLQMRU+t1QaRSTcEhcgTmst6Wf7zJG4WwNAfdUTtkNuLYtb7BByyR JiJgpdonTDRPaoUReA5E11cAOJ2BdVPsEyVY62rhQoabN2bV/bDFtsKZb3WQzxnIY/vFse xcqjGuDn1olQzrfvpowYAu9XR0XKPbs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-OukGO2QZMGqQNAJGIGLy0w-1; Fri, 07 Feb 2025 03:33:03 -0500 X-MC-Unique: OukGO2QZMGqQNAJGIGLy0w-1 X-Mimecast-MFC-AGG-ID: OukGO2QZMGqQNAJGIGLy0w Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B52B180087B; Fri, 7 Feb 2025 08:33:02 +0000 (UTC) Received: from dmarchan.com (unknown [10.45.224.27]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EC0071955BCB; Fri, 7 Feb 2025 08:32:59 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, andremue@linux.microsoft.com, Parav Pandit , Xueming Li Subject: [RFC 01/10] bus/auxiliary: remove weak symbols Date: Fri, 7 Feb 2025 09:32:41 +0100 Message-ID: <20250207083252.3131588-2-david.marchand@redhat.com> In-Reply-To: <20250207083252.3131588-1-david.marchand@redhat.com> References: <20250207083252.3131588-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1eXQIqwCuOzUK4a2V1rTR2mvga5eLLGTxNrLYV-tM9k_1738917182 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than use weak symbols, expose stubs symbols when needed. Signed-off-by: David Marchand --- drivers/bus/auxiliary/auxiliary_common.c | 6 ++++-- drivers/bus/auxiliary/meson.build | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index e6cbc4d356..b444eb43ef 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -36,12 +36,13 @@ auxiliary_devargs_lookup(const char *name) return NULL; } +#ifndef AUXILIARY_OS_SUPPORTED /* * Test whether the auxiliary device exist. * * Stub for OS not supporting auxiliary bus. */ -__rte_weak bool +bool auxiliary_dev_exists(const char *name) { RTE_SET_USED(name); @@ -53,11 +54,12 @@ auxiliary_dev_exists(const char *name) * * Stub for OS not supporting auxiliary bus. */ -__rte_weak int +int auxiliary_scan(void) { return 0; } +#endif /* AUXILIARY_OS_SUPPORTED */ /* * Update a device's devargs being scanned. diff --git a/drivers/bus/auxiliary/meson.build b/drivers/bus/auxiliary/meson.build index 10468fd130..38d2f05d4b 100644 --- a/drivers/bus/auxiliary/meson.build +++ b/drivers/bus/auxiliary/meson.build @@ -7,6 +7,7 @@ sources = files( 'auxiliary_params.c', ) if is_linux + cflags += '-DAUXILIARY_OS_SUPPORTED' sources += files( 'linux/auxiliary.c', ) -- 2.48.1