From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6820461B8; Fri, 7 Feb 2025 09:33:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0F6D427E3; Fri, 7 Feb 2025 09:33:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DA949427DD for ; Fri, 7 Feb 2025 09:33:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738917212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/d/QQhEjhj8T8ta6fJNuFmowojB0AARxmtBZ/fRGFY=; b=Gej8oX4UBHAG/9u2JgfuaE/G6EPNFlyvbhP4E+CV7GShx6uKjs1dSzyPfG5afJOMonKI8i VAXolnzpGtoWaQQ05rseSi58JcnWF3dTiSupHTHbGlGHYErk3Wk65SLL8Bm2LsJLiZspRz KGyDUzZojXVSjOX/6RjfPk75fvJMK90= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-3HB-ur2WOGq6LddowFEbzw-1; Fri, 07 Feb 2025 03:33:29 -0500 X-MC-Unique: 3HB-ur2WOGq6LddowFEbzw-1 X-Mimecast-MFC-AGG-ID: 3HB-ur2WOGq6LddowFEbzw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A7091800264; Fri, 7 Feb 2025 08:33:28 +0000 (UTC) Received: from dmarchan.com (unknown [10.45.224.27]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4286919560AE; Fri, 7 Feb 2025 08:33:26 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, andremue@linux.microsoft.com Subject: [RFC 06/10] net/fm10k: remove weak symbols Date: Fri, 7 Feb 2025 09:32:46 +0100 Message-ID: <20250207083252.3131588-7-david.marchand@redhat.com> In-Reply-To: <20250207083252.3131588-1-david.marchand@redhat.com> References: <20250207083252.3131588-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bXqRt1r54ygiD8s6iodA2ESj99B_MSoVB2RyT8fvC-o_1738917208 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than use weak symbols, expose stubs symbols when needed. Signed-off-by: David Marchand --- drivers/net/intel/fm10k/fm10k_ethdev.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/intel/fm10k/fm10k_ethdev.c b/drivers/net/intel/fm10k/fm10k_ethdev.c index 7b490bea17..633c501ce8 100644 --- a/drivers/net/intel/fm10k/fm10k_ethdev.c +++ b/drivers/net/intel/fm10k/fm10k_ethdev.c @@ -129,14 +129,15 @@ fm10k_mbx_unlock(struct fm10k_hw *hw) rte_spinlock_unlock(FM10K_DEV_PRIVATE_TO_MBXLOCK(hw->back)); } -/* Stubs needed for linkage when vPMD is disabled */ -__rte_weak int +#ifndef RTE_ARCH_X86 +/* Stubs for non x86 architectures. */ +int fm10k_rx_vec_condition_check(__rte_unused struct rte_eth_dev *dev) { return -1; } -__rte_weak uint16_t +uint16_t fm10k_recv_pkts_vec( __rte_unused void *rx_queue, __rte_unused struct rte_mbuf **rx_pkts, @@ -145,7 +146,7 @@ fm10k_recv_pkts_vec( return 0; } -__rte_weak uint16_t +uint16_t fm10k_recv_scattered_pkts_vec( __rte_unused void *rx_queue, __rte_unused struct rte_mbuf **rx_pkts, @@ -154,39 +155,40 @@ fm10k_recv_scattered_pkts_vec( return 0; } -__rte_weak int +int fm10k_rxq_vec_setup(__rte_unused struct fm10k_rx_queue *rxq) { return -1; } -__rte_weak void +void fm10k_rx_queue_release_mbufs_vec( __rte_unused struct fm10k_rx_queue *rxq) { return; } -__rte_weak void +void fm10k_txq_vec_setup(__rte_unused struct fm10k_tx_queue *txq) { return; } -__rte_weak int +int fm10k_tx_vec_condition_check(__rte_unused struct fm10k_tx_queue *txq) { return -1; } -__rte_weak uint16_t +uint16_t fm10k_xmit_fixed_burst_vec(__rte_unused void *tx_queue, __rte_unused struct rte_mbuf **tx_pkts, __rte_unused uint16_t nb_pkts) { return 0; } +#endif /* RTE_ARCH_X86 */ /* * reset queue to initial state, allocate software buffers used when starting -- 2.48.1