DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com, kai.ji@intel.com,
	brian.dooley@intel.com
Subject: Re: [PATCH v4] net: add thread-safe crc api
Date: Fri, 7 Feb 2025 09:12:42 -0800	[thread overview]
Message-ID: <20250207091242.07656c4c@hermes.local> (raw)
In-Reply-To: <20250207063758.3971992-1-arkadiuszx.kusztal@intel.com>

On Fri,  7 Feb 2025 06:37:58 +0000
Arkadiusz Kusztal <arkadiuszx.kusztal@intel.com> wrote:

> +* net: A thread/process-safe API was introduced. Old and new APIs share the same
> +  function names, but the old one is versioned. Replaced functions are:
> +  ``rte_net_crc_calc`` and ``rte_net_crc_set_alg``. The new one is ``rte_net_crc_free``

The first sentence should be more specific, and avoid passive voice.
Follow the style of other release notes in other releases.
Also, should indicate that versioning is short term (until 25.11).

Something like:

* **Changed the API for CRC calculation to be thread safe.**

  An opaque context argument was introduced to the net CRC API containing
  the algorithim type and length. This argument is added to
  to ``rte_net_crc_calc``, ``rte_net_crc_set_alg`` and freed with ``rte_net_crc_free``.
  These functions are versioned to retain binary compatiabilty until the next LTS release.

  reply	other threads:[~2025-02-07 17:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-01 18:11 [PATCH v2 0/3] " Arkadiusz Kusztal
2024-10-01 18:11 ` [PATCH v2 1/3] " Arkadiusz Kusztal
2024-10-01 21:44   ` Stephen Hemminger
2024-10-02  8:28     ` Kusztal, ArkadiuszX
2024-10-02  7:42   ` David Marchand
2024-10-02  8:41     ` Kusztal, ArkadiuszX
2024-10-02  9:01       ` David Marchand
2024-10-02  9:16         ` Kusztal, ArkadiuszX
2024-10-08  3:42   ` Ferruh Yigit
2024-10-08 20:51     ` Kusztal, ArkadiuszX
2024-10-09  1:03       ` Ferruh Yigit
2024-10-09  7:48         ` Kusztal, ArkadiuszX
2024-10-09  9:11           ` Ferruh Yigit
2025-02-06 20:54         ` Kusztal, ArkadiuszX
2024-12-02 22:36   ` Stephen Hemminger
2025-02-06 20:43     ` Kusztal, ArkadiuszX
2025-02-06 20:38   ` [PATCH v3] " Arkadiusz Kusztal
2025-02-07  6:37     ` [PATCH v4] " Arkadiusz Kusztal
2025-02-07 17:12       ` Stephen Hemminger [this message]
2025-02-07 17:37         ` Kusztal, ArkadiuszX
2025-02-07 18:24       ` [PATCH v5] " Arkadiusz Kusztal
2024-10-01 18:11 ` [PATCH v2 2/3] crypto/qat: use process safe " Arkadiusz Kusztal
2024-10-01 18:11 ` [PATCH v2 3/3] test/crc: replace thread-unsafe api functions Arkadiusz Kusztal
2024-12-02 22:33   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250207091242.07656c4c@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=brian.dooley@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).