From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4276E461DB; Sun, 9 Feb 2025 18:29:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9130C4068E; Sun, 9 Feb 2025 18:29:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9283B40673 for ; Sun, 9 Feb 2025 18:29:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739122160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MBFBEZJvH/OgKecf6MzEcifa4KGlXCGGvggMt1JfA5E=; b=MZ3oG/UOWTEKmXwB+CFFljzuO9k6OfbAJlXeIkJF2RB3i9NhmT1PEvDcOQ7sZYszC1dN2D BViVf8iJNN56IIl7n9FeOTRzM0SHuKeV+pPY8TBiJf86uynLPzmaYqmA8WEUTgz9C7pN+E XZ4QiL9bJQHYjAuECVA+vItr4dx+xf4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-MmcGr_ohNPqcZ-kry1ysbQ-1; Sun, 09 Feb 2025 12:29:17 -0500 X-MC-Unique: MmcGr_ohNPqcZ-kry1ysbQ-1 X-Mimecast-MFC-AGG-ID: MmcGr_ohNPqcZ-kry1ysbQ Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DBAC3180087A; Sun, 9 Feb 2025 17:29:15 +0000 (UTC) Received: from dmarchan.com (unknown [10.44.32.76]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 42F311800352; Sun, 9 Feb 2025 17:29:13 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, andremue@linux.microsoft.com, John Daley , Hyong Youb Kim Subject: [RFC v2 04/10] net/enic: remove weak symbols Date: Sun, 9 Feb 2025 18:28:42 +0100 Message-ID: <20250209172850.2429075-5-david.marchand@redhat.com> In-Reply-To: <20250209172850.2429075-1-david.marchand@redhat.com> References: <20250207083252.3131588-1-david.marchand@redhat.com> <20250209172850.2429075-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tTa86LZWxXa_J1a83zlmxjUKMBeb_nHls2qKZ-7Vn3Y_1739122156 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than use weak symbols, expose stubs symbols when needed. Signed-off-by: David Marchand --- drivers/net/enic/enic_main.c | 8 +++----- drivers/net/enic/meson.build | 1 + 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index b755b15d92..5ee2ae555d 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -509,15 +509,13 @@ static void enic_prep_wq_for_simple_tx(struct enic *enic, uint16_t queue_idx) } } -/* - * The 'strong' version is in enic_rxtx_vec_avx2.c. This weak version is used - * used when that file is not compiled. - */ -__rte_weak bool +#ifndef ENIC_RXTX_VEC +bool enic_use_vector_rx_handler(__rte_unused struct rte_eth_dev *eth_dev) { return false; } +#endif /* ENIC_RXTX_VEC */ void enic_pick_rx_handler(struct rte_eth_dev *eth_dev) { diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build index 00f8348348..1e26338350 100644 --- a/drivers/net/enic/meson.build +++ b/drivers/net/enic/meson.build @@ -33,6 +33,7 @@ includes += include_directories('base') # may not. This is to support users who build for the min supported machine # and need to run the binary on newer CPUs too. if dpdk_conf.has('RTE_ARCH_X86_64') + cflags += '-DENIC_RXTX_VEC' enic_avx2_lib = static_library('enic_avx2_lib', 'enic_rxtx_vec_avx2.c', dependencies: [static_rte_ethdev, static_rte_bus_pci], -- 2.48.1