From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87716461DB; Sun, 9 Feb 2025 18:29:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8B5B40A6D; Sun, 9 Feb 2025 18:29:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5C83F40695 for ; Sun, 9 Feb 2025 18:29:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739122166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L/lFN6zU1iHSKBiAAvyFvzwskN/GD3skHUU4DAU5mRQ=; b=bz0NRLh1hySZeEO4JgpRmnVfNIXLqzz3owjC08tMAwIBVt6EaPJEMboEpAz0ZE8RxE4Tp7 Ax5dApzlgKcxX6O4FSTlpn3sQii9mL1A6ITmWVuiDVy1hvCbZ0DT610+l+EbzMTt3bJmCz p+uzz03AT6l1o/qSnSEu22jnvO4UK0k= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-4ylZ3AVTNvOgnzMA_8d4Qg-1; Sun, 09 Feb 2025 12:29:22 -0500 X-MC-Unique: 4ylZ3AVTNvOgnzMA_8d4Qg-1 X-Mimecast-MFC-AGG-ID: 4ylZ3AVTNvOgnzMA_8d4Qg Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F1231800875; Sun, 9 Feb 2025 17:29:21 +0000 (UTC) Received: from dmarchan.com (unknown [10.44.32.76]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CF5401800352; Sun, 9 Feb 2025 17:29:18 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, andremue@linux.microsoft.com, Jie Hai Subject: [RFC v2 05/10] net/hns3: remove weak symbols Date: Sun, 9 Feb 2025 18:28:43 +0100 Message-ID: <20250209172850.2429075-6-david.marchand@redhat.com> In-Reply-To: <20250209172850.2429075-1-david.marchand@redhat.com> References: <20250207083252.3131588-1-david.marchand@redhat.com> <20250209172850.2429075-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R_aNTygkN5jzW1PzLP5LJiSIMKHT9VU8_AJl8GySBDo_1739122161 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Rather than use weak symbols, expose stubs symbols when needed. Signed-off-by: David Marchand --- Changes since v1: - fix build for Arm64 without SVE, --- drivers/net/hns3/hns3_rxtx.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c index 09e39cb673..bb7ffee12c 100644 --- a/drivers/net/hns3/hns3_rxtx.c +++ b/drivers/net/hns3/hns3_rxtx.c @@ -2787,32 +2787,36 @@ hns3_recv_scattered_pkts(void *rx_queue, return nb_rx; } -void __rte_weak +#ifndef RTE_ARCH_ARM64 +void hns3_rxq_vec_setup(__rte_unused struct hns3_rx_queue *rxq) { } -int __rte_weak +int hns3_rx_check_vec_support(__rte_unused struct rte_eth_dev *dev) { return -ENOTSUP; } -uint16_t __rte_weak +uint16_t hns3_recv_pkts_vec(__rte_unused void *rx_queue, __rte_unused struct rte_mbuf **rx_pkts, __rte_unused uint16_t nb_pkts) { return 0; } +#endif /* RTE_ARCH_ARM64 */ -uint16_t __rte_weak +#ifndef RTE_HAS_SVE_ACLE +uint16_t hns3_recv_pkts_vec_sve(__rte_unused void *rx_queue, __rte_unused struct rte_mbuf **rx_pkts, __rte_unused uint16_t nb_pkts) { return 0; } +#endif /* RTE_HAS_SVE_ACLE */ int hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, @@ -4256,27 +4260,31 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) return nb_tx; } -int __rte_weak +#ifndef RTE_ARCH_ARM64 +int hns3_tx_check_vec_support(__rte_unused struct rte_eth_dev *dev) { return -ENOTSUP; } -uint16_t __rte_weak +uint16_t hns3_xmit_pkts_vec(__rte_unused void *tx_queue, __rte_unused struct rte_mbuf **tx_pkts, __rte_unused uint16_t nb_pkts) { return 0; } +#endif /* RTE_ARCH_ARM64 */ -uint16_t __rte_weak +#ifndef RTE_HAS_SVE_ACLE +uint16_t hns3_xmit_pkts_vec_sve(void __rte_unused * tx_queue, struct rte_mbuf __rte_unused **tx_pkts, uint16_t __rte_unused nb_pkts) { return 0; } +#endif /* RTE_HAS_SVE_ACLE */ int hns3_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id, -- 2.48.1