From: Stephen Hemminger <stephen@networkplumber.org>
To: Bingbin Chen <chen.bingbin@zte.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1 01/14] net/zxdh: add network processor registers ops
Date: Mon, 10 Feb 2025 08:56:06 -0800 [thread overview]
Message-ID: <20250210085606.3789a116@hermes.local> (raw)
In-Reply-To: <20250210011924.4104325-1-chen.bingbin@zte.com.cn>
On Mon, 10 Feb 2025 09:19:24 +0800
Bingbin Chen <chen.bingbin@zte.com.cn> wrote:
> +ZXDH_REG_T g_dpp_reg_info[] = {
> + {
> + "cpu_ind_cmd",
> + 669,
> + SMMU0,
> + ZXDH_REG_FLAG_DIRECT,
> + ZXDH_REG_NUL_ARRAY,
> + ZXDH_SYS_SE_SMMU0_BASE_ADDR + ZXDH_MODULE_SE_SMMU0_BASE_ADDR + 0x00000014,
> + (32 / 8),
> + 0,
> + 0,
> + 0,
> + 0,
> + 4,
> + g_smmu0_smmu0_cpu_ind_cmd_reg,
> + zxdh_np_se_smmu0_write,
> + zxdh_np_se_smmu0_read,
> + },
For complex initializers like this, it is better to use explicit field names.
{
.name = "cpu_ind_cmd",
...
The problem is that if you get something in wrong place only some analysis
tool many years later will notice.
next prev parent reply other threads:[~2025-02-10 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 1:19 Bingbin Chen
2025-02-10 16:56 ` Stephen Hemminger [this message]
2025-02-10 1:44 Bingbin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210085606.3789a116@hermes.local \
--to=stephen@networkplumber.org \
--cc=chen.bingbin@zte.com.cn \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).