From: Stephen Hemminger <stephen@networkplumber.org>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, <mkashani@nvidia.com>,
rasland@nvidia.com, "Shani Peretz" <shperetz@nvidia.com>
Subject: Re: [PATCH] crypto/mlx5: log when num of segs exceed max segs
Date: Mon, 10 Feb 2025 09:04:07 -0800 [thread overview]
Message-ID: <20250210090407.478ae523@hermes.local> (raw)
In-Reply-To: <20250209120851.254695-1-getelson@nvidia.com>
On Sun, 9 Feb 2025 14:08:51 +0200
Gregory Etelson <getelson@nvidia.com> wrote:
> - MLX5_ASSERT(nb_segs <= qp->priv->max_segs_num);
> + if (nb_segs > qp->priv->max_segs_num) {
> + DRV_LOG(WARNING, "Segment count exceeds limit. "
> + "Current segments: %d, Maximum allowed: %d. "
> + "To resolve, either increase the segment size "
> + "or set a higher value for the devargs max_segs_num parameter.",
> + nb_segs, qp->priv->max_segs_num);
> + RTE_VERIFY(nb_segs <= qp->priv->max_segs_num);
> + return 0;
> + }
Way to verbose.
RTE_VERIFY never returns since it calls rte_panic().
Would it be better to just use RTE_VERIFY()?
Maybe MLX5 should have MLX5_ASSERT() and MLX5_VERIFY() macro.
Je n’ai fait celle-ci plus longue que parce que je n’ai pas eu le loisir de la faire plus courte.
I have made this longer than usual because I have not had time to make it shorter.
prev parent reply other threads:[~2025-02-10 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 12:08 Gregory Etelson
2025-02-10 17:04 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210090407.478ae523@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shperetz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).