From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53EBE461AE; Mon, 10 Feb 2025 17:44:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A492C427BE; Mon, 10 Feb 2025 17:44:39 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by mails.dpdk.org (Postfix) with ESMTP id 7F21B42794 for ; Mon, 10 Feb 2025 17:44:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739205877; x=1770741877; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zPaEO1XKYp5ZzpEfSjKFXHTA82s7DTdMZCtg0OQVmxg=; b=IjsJBwG5xexnEGc221dlU1yL/Ulld5oiZe0HowtluvHTunPCm1/u9VA2 ix8EJu9QczH/2wChDjDNgrrv6QWm/Kpo1GrXgQX+LkEqurSjYkmijE3nW z/nvmdtMrmiy1ZyEKPv/6V/bmvmRGdIKfujqfQniB/bVB8TYrAo0RqU1t q+HXRv1q6Kshe/qfn5b1za1fyB9pSVn8e1TZ3Wn1PMTvP18/wfLNtDPYS WSKPXDk5QEbIqcL3GiQxyYIOYfmKJxztuHzyyzP0uB6pYI9H93bjzUZk+ l9xhvzeU9l6RwbWAv8wICoUrvju1mTxMeSz3Y1oD7CPDDnMPfZGpmgvkm w==; X-CSE-ConnectionGUID: 6CnZh0lNTzK/R+wOYFQx1Q== X-CSE-MsgGUID: u01MUMbQSRC954Ct58xXvg== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="43453710" X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="43453710" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 08:44:37 -0800 X-CSE-ConnectionGUID: X8gR5LmdT1umr6DN3txUQQ== X-CSE-MsgGUID: FDyh+ZLoQcifZOXULc6pFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,275,1732608000"; d="scan'208";a="112753345" Received: from silpixa00401197coob.ir.intel.com (HELO silpixa00401385.ir.intel.com) ([10.237.214.45]) by fmviesa010.fm.intel.com with ESMTP; 10 Feb 2025 08:44:35 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , Praveen Shetty Subject: [PATCH v5 2/4] net/idpf: re-enable unused variable warnings Date: Mon, 10 Feb 2025 16:44:24 +0000 Message-ID: <20250210164427.1118265-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250210164427.1118265-1-bruce.richardson@intel.com> References: <20250128163649.343336-1-bruce.richardson@intel.com> <20250210164427.1118265-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The idpf driver was being built with warnings disabled for unused variables. However, while the warning was being disabled in the base code directory, all suppressed warnings were in the main directory. Therefore, just remove the unused variables and re-enable the warnings. Signed-off-by: Bruce Richardson Acked-by: Praveen Shetty --- drivers/net/intel/idpf/base/meson.build | 9 --------- drivers/net/intel/idpf/idpf_common_rxtx.c | 2 -- drivers/net/intel/idpf/idpf_common_virtchnl.c | 4 ++-- 3 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/net/intel/idpf/base/meson.build b/drivers/net/intel/idpf/base/meson.build index f30ec7dfc2..7316e0a805 100644 --- a/drivers/net/intel/idpf/base/meson.build +++ b/drivers/net/intel/idpf/base/meson.build @@ -5,12 +5,3 @@ sources += files( 'idpf_controlq.c', 'idpf_controlq_setup.c', ) - -error_cflags = [ - '-Wno-unused-variable', -] -foreach flag: error_cflags - if cc.has_argument(flag) - cflags += flag - endif -endforeach diff --git a/drivers/net/intel/idpf/idpf_common_rxtx.c b/drivers/net/intel/idpf/idpf_common_rxtx.c index e04ab40fa2..7171e27b8d 100644 --- a/drivers/net/intel/idpf/idpf_common_rxtx.c +++ b/drivers/net/intel/idpf/idpf_common_rxtx.c @@ -1178,7 +1178,6 @@ idpf_dp_singleq_recv_scatter_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, struct rte_mbuf *last_seg = rxq->pkt_last_seg; struct rte_mbuf *rxm; struct rte_mbuf *nmb; - struct rte_eth_dev *dev; const uint32_t *ptype_tbl = rxq->adapter->ptype_tbl; uint16_t rx_id = rxq->rx_tail; uint16_t rx_packet_len; @@ -1310,7 +1309,6 @@ idpf_xmit_cleanup(struct idpf_tx_queue *txq) uint16_t nb_tx_desc = txq->nb_tx_desc; uint16_t desc_to_clean_to; uint16_t nb_tx_to_clean; - uint16_t i; volatile struct idpf_base_tx_desc *txd = txq->tx_ring; diff --git a/drivers/net/intel/idpf/idpf_common_virtchnl.c b/drivers/net/intel/idpf/idpf_common_virtchnl.c index de511da788..0ae1d55d79 100644 --- a/drivers/net/intel/idpf/idpf_common_virtchnl.c +++ b/drivers/net/intel/idpf/idpf_common_virtchnl.c @@ -362,7 +362,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport, { struct idpf_adapter *adapter = vport->adapter; struct idpf_cmd_info args; - int size, qg_info_size; + int size; int err = -1; size = sizeof(*p2p_queue_grps_info) + @@ -1044,7 +1044,7 @@ int idpf_vc_rxq_config_by_info(struct idpf_vport *vport, struct virtchnl2_rxq_in struct idpf_adapter *adapter = vport->adapter; struct virtchnl2_config_rx_queues *vc_rxqs = NULL; struct idpf_cmd_info args; - int size, err, i; + int size, err; size = sizeof(*vc_rxqs) + (num_qs - 1) * sizeof(struct virtchnl2_rxq_info); -- 2.43.0