From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF675461EE; Mon, 10 Feb 2025 22:02:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDE68402A4; Mon, 10 Feb 2025 22:02:41 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 23C26402A1 for ; Mon, 10 Feb 2025 22:02:40 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1213) id 212E22109CE9; Mon, 10 Feb 2025 13:02:39 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 212E22109CE9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1739221359; bh=PGkjuM1A4GjRRMEe42NN65MSygXofUyC+or3xLczPy4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XUym1lKiF2sBKnNY0VZjiWCEZBfbziXGoK3+atwbzDjJP4CXjDHlz1iqvK1W602x2 4JPlt2b9iYvgyET+XAGKS84vaoJVEo7eHpt05iJd3O0yAnLZviLa+S3LhhMEbFscNU HHgkfQN7N+YNOW5lOs+z1Qd5sXuNWvxxmSNzWUXE= Date: Mon, 10 Feb 2025 13:02:39 -0800 From: Andre Muezerie To: Bruce Richardson Cc: Stephen Hemminger , anatoly.burakov@intel.com, dev@dpdk.org, ian.stokes@intel.com, jochen.behrens@broadcom.com, vladimir.medvedkin@intel.com Subject: Re: [PATCH v5 0/1] use 64-bit shift, avoid signed/unsigned mismatch Message-ID: <20250210210239.GB19575@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1735246770-731-1-git-send-email-andremue@linux.microsoft.com> <1738950069-21059-1-git-send-email-andremue@linux.microsoft.com> <20250207110157.1283d121@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 10, 2025 at 09:35:22AM +0000, Bruce Richardson wrote: > On Fri, Feb 07, 2025 at 11:01:57AM -0800, Stephen Hemminger wrote: > > On Fri, 7 Feb 2025 09:41:08 -0800 > > Andre Muezerie wrote: > > > > > This patch avoids warnings like the ones below emitted by MSVC: > > > > > > 1) > > > ../drivers/net/ice/base/ice_flg_rd.c(71): warning C4334: '<<': > > > result of 32-bit shift implicitly converted to 64 bits > > > (was 64-bit shift intended?) > > > > > > 2) > > > ../drivers/net/ice/ice_dcf_sched.c(177): warning C4018: '>=': > > > signed/unsigned mismatch > > > > > > The fix for (1) is to use 64-bit shifting when appropriate > > > (according to what the result is used for). > > > > > > The fix for (2) is to explicitly cast the variables used in the > > > comparison. > > > > > > v5: > > > * rebase > > > * use uint32_t instead of uint32, to better conform to DPDK standards > > > * rename variable rqID to rq_id to better conform to DPDK standards > > > and avoid checkpatch warning > > > * use 2U instead of (uint32)2, which is shorter > > > * simplify expression in meson.build using compiler id "gcc" > > > > > > Andre Muezerie (1): > > > drivers/net: use 64-bit shift and avoid signed/unsigned mismatch > > > > > > drivers/net/intel/i40e/i40e_ethdev.c | 22 +++++++++++----------- > > > drivers/net/intel/iavf/iavf_ethdev.c | 2 +- > > > drivers/net/intel/iavf/iavf_rxtx.c | 2 +- > > > drivers/net/intel/iavf/iavf_vchnl.c | 2 +- > > > drivers/net/intel/ice/base/meson.build | 19 +++++++++++++------ > > > drivers/net/intel/ice/ice_dcf_sched.c | 2 +- > > > drivers/net/intel/ice/ice_ethdev.c | 4 ++-- > > > drivers/net/intel/ice/ice_rxtx.c | 2 +- > > > drivers/net/intel/ixgbe/ixgbe_ethdev.c | 2 +- > > > 9 files changed, 32 insertions(+), 25 deletions(-) > > > > > > Since all intel, this should get picked up by next-intel > > V4 had some non-intel changes too. Did they get missed in v5? Indeed, I ended up missing one file. I'll send it as a separate patch.