From: Stephen Hemminger <stephen@networkplumber.org>
To: Wenbo Cao <caowenbo@mucse.com>
Cc: thomas@monjalon.net, dev@dpdk.org, ferruh.yigit@amd.com,
andrew.rybchenko@oktetlabs.ru, yaojun@mucse.com
Subject: Re: [PATCH v9 08/28] net/rnp: add queue setup and release operations
Date: Tue, 11 Feb 2025 08:02:02 -0800 [thread overview]
Message-ID: <20250211080202.621a091f@hermes.local> (raw)
In-Reply-To: <1739263818-59770-9-git-send-email-caowenbo@mucse.com>
On Tue, 11 Feb 2025 16:49:58 +0800
Wenbo Cao <caowenbo@mucse.com> wrote:
> diff --git a/drivers/net/rnp/base/rnp_hw.h b/drivers/net/rnp/base/rnp_hw.h
> index da2c1d3b0e..ea4e1b8d83 100644
> --- a/drivers/net/rnp/base/rnp_hw.h
> +++ b/drivers/net/rnp/base/rnp_hw.h
> @@ -120,6 +120,9 @@ struct rnp_hw {
> bool lane_is_sgmii[RNP_MAX_PORT_OF_PF];
> struct rnp_mbx_info mbx;
> struct rnp_fw_info fw_info;
> +
> + spinlock_t rxq_reset_lock; /* reset op isn't thread safe */
> + spinlock_t txq_reset_lock; /* reset op isn't thread safe */
> };
>
In DPDK control operations do not need to be thread safe.
Many other drivers do not allow start/stop in one thread while tx/rx are happening etc.
This is because rx/tx should not have overhead of any locks.
The cost of one spinlock at 10G will drop performance a lot
next prev parent reply other threads:[~2025-02-11 16:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 8:49 [PATCH v9 00/28] [v9]drivers/net Add Support mucse N10 Pmd Driver Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 01/28] net/rnp: add skeleton Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 02/28] net/rnp: add ethdev probe and remove Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 03/28] net/rnp: add log Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 04/28] net/rnp: support mailbox basic operate Wenbo Cao
2025-02-11 15:24 ` Stephen Hemminger
2025-02-11 15:31 ` Stephen Hemminger
2025-02-11 8:49 ` [PATCH v9 05/28] net/rnp: add device init and uninit Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 06/28] net/rnp: add get device information operation Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 07/28] net/rnp: add support MAC promisc mode Wenbo Cao
2025-02-11 8:49 ` [PATCH v9 08/28] net/rnp: add queue setup and release operations Wenbo Cao
2025-02-11 15:22 ` Stephen Hemminger
2025-02-11 16:02 ` Stephen Hemminger [this message]
2025-02-11 16:03 ` Stephen Hemminger
2025-02-11 8:49 ` [PATCH v9 09/28] net/rnp: add queue stop and start operations Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 10/28] net/rnp: add support device start stop operations Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 11/28] net/rnp: add RSS support operations Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 12/28] net/rnp: add support link update operations Wenbo Cao
2025-02-11 15:35 ` Stephen Hemminger
2025-02-11 8:50 ` [PATCH v9 13/28] net/rnp: add support link setup operations Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 14/28] net/rnp: add Rx burst simple support Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 15/28] net/rnp: add Tx " Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 16/28] net/rnp: add MTU set operation Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 17/28] net/rnp: add Rx scatter segment version Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 18/28] net/rnp: add Tx multiple " Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 19/28] net/rnp: add support basic stats operation Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 20/28] net/rnp: add support xstats operation Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 21/28] net/rnp: add unicast MAC filter operation Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 22/28] net/rnp: add supported packet types Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 23/28] net/rnp: add support Rx checksum offload Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 24/28] net/rnp: add support Tx TSO offload Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 25/28] net/rnp: support VLAN offloads Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 26/28] net/rnp: add support VLAN filters operations Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 27/28] net/rnp: add queue info operation Wenbo Cao
2025-02-11 8:50 ` [PATCH v9 28/28] net/rnp: support Rx/Tx burst mode info Wenbo Cao
2025-02-11 14:56 ` [PATCH v9 00/28] [v9]drivers/net Add Support mucse N10 Pmd Driver Stephen Hemminger
2025-02-11 15:18 ` 11
2025-02-11 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211080202.621a091f@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=caowenbo@mucse.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=thomas@monjalon.net \
--cc=yaojun@mucse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).