From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: <dev@dpdk.org>, "Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v5 01/11] eal: introduce new secure memory fill
Date: Wed, 12 Feb 2025 07:03:29 -0800 [thread overview]
Message-ID: <20250212070329.7d1b816c@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FA26@smartserver.smartshare.dk>
On Wed, 12 Feb 2025 10:09:27 +0100
Morten Brørup <mb@smartsharesystems.com> wrote:
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Tuesday, 11 February 2025 18.35
> >
> > When memset() is used before a release function such as free,
> > the compiler if allowed to optimize the memset away under
> > the as-if rules. This is normally ok, but in certain cases such
> > as passwords or security keys it is problematic.
> >
> > Introduce a DPDK wrapper which is equivalent to the C++ memset_s
> > function. Naming chosen to be similar to kernel.
>
> It's not like C11 memset_s, which takes one more parameter, and is an optional part of the C11 standard.
> It's like C23 memset_explicit.
>
> Wouldn't it be better to name it after the C standard function, i.e. rte_memset_explicit?
>
> Or maybe backport memset_explicit from C23, i.e. omit the rte_ prefix, if not using a C23 compiler?
>
I prefer parallel Linux kernal API names, lots of drivers share code.
next prev parent reply other threads:[~2025-02-12 15:03 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 1:10 [PATCH 0/3] introduce rte_memset_sensative Stephen Hemminger
2024-11-14 1:10 ` [PATCH 1/3] eal: " Stephen Hemminger
2024-11-14 1:10 ` [PATCH 2/3] crypto/qat: use rte_memset_sensative Stephen Hemminger
2024-11-14 1:10 ` [PATCH 3/3] eal: add rte_free_sensative Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 0/8] memset security handling Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 1/8] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 2/8] eal: add new secure free function Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 3/8] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 4/8] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 5/8] crypto/qat: use secure memset Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 6/8] bus/uacce: remove memset before free Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 7/8] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14 1:52 ` [PATCH v2 8/8] test: remove unneeded memset Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 00/11] memset security handling Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 01/11] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 02/11] eal: add new secure free function Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 03/11] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 04/11] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 05/11] crypto/qat: use secure memset Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 06/11] bus/uacce: remove memset before free Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 07/11] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 08/11] test: remove unneeded memset Stephen Hemminger
2024-11-14 2:35 ` [PATCH v3 09/11] net/ntnic: remove unnecessary void cast Stephen Hemminger
2024-11-17 18:16 ` Serhii Iliushyk
2024-11-14 2:35 ` [PATCH v3 10/11] net/ntnic: check result of malloc Stephen Hemminger
2024-11-17 18:24 ` Serhii Iliushyk
2024-11-14 2:36 ` [PATCH v3 11/11] net/ntnic: remove unnecessary memset Stephen Hemminger
2024-11-17 18:26 ` Serhii Iliushyk
2024-11-14 18:43 ` [PATCH v4 00/12] memset security fixes Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 01/12] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 02/12] eal: add new secure free function Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 03/12] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 04/12] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 05/12] crypto/qat: use secure memset Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 06/12] bus/uacce: remove memset before free Stephen Hemminger
2024-11-15 6:04 ` fengchengwen
2024-11-14 18:43 ` [PATCH v4 07/12] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 08/12] test: remove unneeded memset Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 09/12] net/ntnic: remove unnecessary void cast Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 10/12] net/ntnic: check result of malloc Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 11/12] net/ntnic: remove unnecessary memset Stephen Hemminger
2024-11-14 18:43 ` [PATCH v4 12/12] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 00/11] memset security fixes Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 01/11] eal: introduce new secure memory fill Stephen Hemminger
2025-02-12 1:37 ` fengchengwen
2025-02-12 9:09 ` Morten Brørup
2025-02-12 15:03 ` Stephen Hemminger [this message]
2025-02-11 17:35 ` [PATCH v5 02/11] eal: add new secure free function Stephen Hemminger
2025-02-12 2:01 ` fengchengwen
2025-02-12 6:46 ` Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 03/11] crypto/qat: force zero of keys Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 04/11] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 05/11] crypto/qat: use secure memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 06/11] bus/uacce: remove memset before free Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 07/11] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 08/11] test: remove unneeded memset Stephen Hemminger
2025-02-12 1:40 ` fengchengwen
2025-02-11 17:35 ` [PATCH v5 09/11] net/ntnic: check result of malloc Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 10/11] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 11/11] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-11 20:59 ` [PATCH v5 00/11] memset security fixes Patrick Robb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212070329.7d1b816c@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).