From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
stable@dpdk.org, Jeroen de Borst <jeroendb@google.com>,
Rushil Gupta <rushilg@google.com>,
Joshua Washington <joshwash@google.com>,
Long Li <longli@microsoft.com>, Wei Hu <weh@microsoft.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbox@nvidia.com>,
Jochen Behrens <jochen.behrens@broadcom.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
John McNamara <john.mcnamara@intel.com>,
Yong Wang <wang.yong19@zte.com.cn>
Subject: [PATCH v2 2/6] doc: fix feature flags for queue start/stop
Date: Fri, 14 Feb 2025 09:38:55 -0800 [thread overview]
Message-ID: <20250214174224.79142-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20250214174224.79142-1-stephen@networkplumber.org>
Several drivers have mismatch between the ethdev ops for queue
start/stop and the documentation. The gve driver does implement
queue start/stop support. The mana, netvsc, virtio and vmxnet3
drivers do not implement the rx_queue_start callback.
Fixes: 410333da8b5f ("net/mana: start/stop Tx queues")
Fixes: beff6d8e8e2e ("net/netvsc: add documentation")
Fixes: 9db3f52126fb ("doc: generate NIC overview table from ini files")
Fixes: 24595041937e ("net/vmxnet3: update feature doc")
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
doc/guides/nics/features.rst | 1 +
doc/guides/nics/features/gve.ini | 1 +
doc/guides/nics/features/mana.ini | 1 -
doc/guides/nics/features/netvsc.ini | 1 -
doc/guides/nics/features/virtio.ini | 1 -
doc/guides/nics/features/vmxnet3.ini | 1 -
6 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index 8bd448139e..a075c057ec 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -149,6 +149,7 @@ Queue start/stop
----------------
Supports starting/stopping a specific Rx/Tx queue of a port.
+This is required for use deferred start configuration option.
* **[implements] eth_dev_ops**: ``rx_queue_start``, ``rx_queue_stop``, ``tx_queue_start``,
``tx_queue_stop``.
diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini
index 8dfa229bb0..f18b829eda 100644
--- a/doc/guides/nics/features/gve.ini
+++ b/doc/guides/nics/features/gve.ini
@@ -6,6 +6,7 @@
[Features]
Speed capabilities = Y
Link status = Y
+Queue start/stop = Y
MTU update = Y
TSO = Y
RSS hash = Y
diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/mana.ini
index 42fd3327d2..db555ffe27 100644
--- a/doc/guides/nics/features/mana.ini
+++ b/doc/guides/nics/features/mana.ini
@@ -8,7 +8,6 @@ Speed capabilities = P
Link status = P
Removal event = Y
Rx interrupt = Y
-Queue start/stop = Y
RSS hash = Y
L3 checksum offload = Y
L4 checksum offload = Y
diff --git a/doc/guides/nics/features/netvsc.ini b/doc/guides/nics/features/netvsc.ini
index de8c698184..32df77a03e 100644
--- a/doc/guides/nics/features/netvsc.ini
+++ b/doc/guides/nics/features/netvsc.ini
@@ -7,7 +7,6 @@
Speed capabilities = P
Link status = Y
Free Tx mbuf on demand = Y
-Queue start/stop = Y
Scattered Rx = Y
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini
index a5eab4932f..f0a1a564f9 100644
--- a/doc/guides/nics/features/virtio.ini
+++ b/doc/guides/nics/features/virtio.ini
@@ -8,7 +8,6 @@ Speed capabilities = P
Link status = Y
Link status event = Y
Rx interrupt = Y
-Queue start/stop = Y
Scattered Rx = P
Promiscuous mode = Y
Allmulticast mode = Y
diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini
index 971695fc4a..749887d642 100644
--- a/doc/guides/nics/features/vmxnet3.ini
+++ b/doc/guides/nics/features/vmxnet3.ini
@@ -7,7 +7,6 @@
Speed capabilities = P
Link status = Y
Link status event = Y
-Queue start/stop = Y
MTU update = Y
LRO = Y
TSO = Y
--
2.47.2
next prev parent reply other threads:[~2025-02-14 17:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 21:48 [PATCH 0/5] centralize deferred start checks Stephen Hemminger
2024-12-13 21:48 ` [PATCH 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-13 21:48 ` [PATCH 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-13 21:48 ` [PATCH 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 4/5] net/enetfec: " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 5/5] net/virtio: " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 0/5] add check for deferred start to ethdev Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-15 8:56 ` Andrew Rybchenko
2024-12-16 18:58 ` Stephen Hemminger
2024-12-17 6:07 ` Andrew Rybchenko
2024-12-14 18:07 ` [PATCH v2 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 4/5] net/enetfec: " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 5/5] net/virtio: " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 2/6] doc: fix feature flags for queue start/stop Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 5/6] net/enetfec: " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 6/6] net/virtio: " Stephen Hemminger
2025-01-28 21:03 ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 0/6] fix the handling of deferred start in ethdev Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2025-02-17 17:12 ` Bruce Richardson
2025-02-14 17:38 ` Stephen Hemminger [this message]
2025-02-14 17:38 ` [PATCH v2 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 5/6] net/enetfec: " Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 6/6] net/virtio: " Stephen Hemminger
2025-02-17 17:13 ` [PATCH v2 0/6] fix the handling of deferred start in ethdev Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214174224.79142-3-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=jochen.behrens@broadcom.com \
--cc=john.mcnamara@intel.com \
--cc=joshwash@google.com \
--cc=longli@microsoft.com \
--cc=maxime.coquelin@redhat.com \
--cc=rushilg@google.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=wang.yong19@zte.com.cn \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).