DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>
Subject: [PATCH v7 07/16] common/cnxk: remove unused variable
Date: Sat, 15 Feb 2025 11:04:35 -0800	[thread overview]
Message-ID: <20250215190544.988310-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20250215190544.988310-1-stephen@networkplumber.org>

A couple places in this code were generating warnings from
PVS studio about memset potentially being ignored. This is because
the ipv6_buf was declared but never used.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/cnxk/roc_npc_utils.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/common/cnxk/roc_npc_utils.c b/drivers/common/cnxk/roc_npc_utils.c
index 75d3b0702c..0b32a148e2 100644
--- a/drivers/common/cnxk/roc_npc_utils.c
+++ b/drivers/common/cnxk/roc_npc_utils.c
@@ -454,11 +454,9 @@ npc_process_ipv6_field_hash_legacy(const struct roc_npc_flow_item_ipv6 *ipv6_spe
 	struct npc_lid_lt_xtract_info *lid_lt_xinfo;
 	uint8_t hash_field[ROC_IPV6_ADDR_LEN];
 	struct npc_xtract_info *xinfo;
-	struct roc_ipv6_hdr ipv6_buf;
 	uint32_t hash = 0, mask;
 	int intf, i, rc = 0;
 
-	memset(&ipv6_buf, 0, sizeof(ipv6_buf));
 	memset(hash_field, 0, sizeof(hash_field));
 
 	intf = pst->nix_intf;
@@ -495,11 +493,9 @@ npc_process_ipv6_field_hash_o20k(const struct roc_npc_flow_item_ipv6 *ipv6_spec,
 	union npc_kex_ldata_flags_cfg *lid_cfg;
 	uint8_t hash_field[ROC_IPV6_ADDR_LEN];
 	struct npc_xtract_info *xinfo;
-	struct roc_ipv6_hdr ipv6_buf;
 	uint32_t hash = 0, mask;
 	int intf, i, rc = 0;
 
-	memset(&ipv6_buf, 0, sizeof(ipv6_buf));
 	memset(hash_field, 0, sizeof(hash_field));
 
 	intf = pst->nix_intf;
-- 
2.47.2


  parent reply	other threads:[~2025-02-15 19:06 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14  1:10 [PATCH 0/3] introduce rte_memset_sensative Stephen Hemminger
2024-11-14  1:10 ` [PATCH 1/3] eal: " Stephen Hemminger
2024-11-14  1:10 ` [PATCH 2/3] crypto/qat: use rte_memset_sensative Stephen Hemminger
2024-11-14  1:10 ` [PATCH 3/3] eal: add rte_free_sensative Stephen Hemminger
2024-11-14  1:52 ` [PATCH v2 0/8] memset security handling Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 1/8] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 2/8] eal: add new secure free function Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 3/8] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 4/8] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 5/8] crypto/qat: use secure memset Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 6/8] bus/uacce: remove memset before free Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 7/8] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14  1:52   ` [PATCH v2 8/8] test: remove unneeded memset Stephen Hemminger
2024-11-14  2:35 ` [PATCH v3 00/11] memset security handling Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 01/11] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 02/11] eal: add new secure free function Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 03/11] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 04/11] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 05/11] crypto/qat: use secure memset Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 06/11] bus/uacce: remove memset before free Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 07/11] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 08/11] test: remove unneeded memset Stephen Hemminger
2024-11-14  2:35   ` [PATCH v3 09/11] net/ntnic: remove unnecessary void cast Stephen Hemminger
2024-11-17 18:16     ` Serhii Iliushyk
2024-11-14  2:35   ` [PATCH v3 10/11] net/ntnic: check result of malloc Stephen Hemminger
2024-11-17 18:24     ` Serhii Iliushyk
2024-11-14  2:36   ` [PATCH v3 11/11] net/ntnic: remove unnecessary memset Stephen Hemminger
2024-11-17 18:26     ` Serhii Iliushyk
2024-11-14 18:43 ` [PATCH v4 00/12] memset security fixes Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 01/12] eal: introduce new secure memory fill Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 02/12] eal: add new secure free function Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 03/12] crypto/qat: force zero of keys Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 04/12] crypto/qat: fix size calculation for memset Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 05/12] crypto/qat: use secure memset Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 06/12] bus/uacce: remove memset before free Stephen Hemminger
2024-11-15  6:04     ` fengchengwen
2024-11-14 18:43   ` [PATCH v4 07/12] compress/octeontx: remove unnecessary memset Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 08/12] test: remove unneeded memset Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 09/12] net/ntnic: remove unnecessary void cast Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 10/12] net/ntnic: check result of malloc Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 11/12] net/ntnic: remove unnecessary memset Stephen Hemminger
2024-11-14 18:43   ` [PATCH v4 12/12] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-11 17:35 ` [PATCH v5 00/11] memset security fixes Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 01/11] eal: introduce new secure memory fill Stephen Hemminger
2025-02-12  1:37     ` fengchengwen
2025-02-12  9:09     ` Morten Brørup
2025-02-12 15:03       ` Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 02/11] eal: add new secure free function Stephen Hemminger
2025-02-12  2:01     ` fengchengwen
2025-02-12  6:46       ` Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 03/11] crypto/qat: force zero of keys Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 04/11] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 05/11] crypto/qat: use secure memset Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 06/11] bus/uacce: remove memset before free Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 07/11] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 08/11] test: remove unneeded memset Stephen Hemminger
2025-02-12  1:40     ` fengchengwen
2025-02-11 17:35   ` [PATCH v5 09/11] net/ntnic: check result of malloc Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 10/11] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-11 17:35   ` [PATCH v5 11/11] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-11 20:59   ` [PATCH v5 00/11] memset security fixes Patrick Robb
2025-02-13 22:16 ` [PATCH v6 00/11] secure zeroing of memory Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 01/11] eal: introduce new secure memory fill Stephen Hemminger
2025-02-15 15:21     ` Morten Brørup
2025-02-13 22:16   ` [PATCH v6 02/11] eal: add new secure free function Stephen Hemminger
2025-02-15 15:25     ` Morten Brørup
2025-02-13 22:16   ` [PATCH v6 03/11] crypto/qat: force zero of keys Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 04/11] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 05/11] crypto/qat: use secure memset Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 06/11] bus/uacce: remove memset before free Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 07/11] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 08/11] test: remove unneeded memset Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 09/11] net/ntnic: check result of malloc Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 10/11] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-13 22:16   ` [PATCH v6 11/11] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-15 19:04 ` [PATCH v7 00/16] Introduce secure memory zero functions Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 01/16] eal: introduce new secure memory zero Stephen Hemminger
2025-02-16  8:30     ` Morten Brørup
2025-02-15 19:04   ` [PATCH v7 02/16] app/test: use unit test runner for string tests Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 03/16] app/test: add test for rte_memzero_explicit Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 04/16] eal: add new secure free function Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 05/16] app/test: use unit test runner for malloc tests Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 06/16] app/test: add test for rte_free_sensitive Stephen Hemminger
2025-02-15 19:04   ` Stephen Hemminger [this message]
2025-02-15 19:04   ` [PATCH v7 08/16] crypto/qat: force zero of keys Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 09/16] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 10/16] crypto/qat: use secure free for keys Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 11/16] bus/uacce: remove memset before free Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 12/16] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 13/16] test: remove unneeded memset Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 14/16] net/ntnic: check result of malloc Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 15/16] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-15 19:04   ` [PATCH v7 16/16] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-16 16:52 ` [PATCH v8 00/17] fix memset warnings reported by PVS studio Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 01/17] eal: introduce new secure memory zero Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 02/17] app/test: use unit test runner for string tests Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 03/17] app/test: add test for rte_memzero_explicit Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 04/17] app/test: remove unused variable Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 05/17] eal: add new secure free function Stephen Hemminger
2025-02-20 12:31     ` Burakov, Anatoly
2025-02-16 16:53   ` [PATCH v8 06/17] app/test: use unit test runner for malloc tests Stephen Hemminger
2025-02-20 12:32     ` Burakov, Anatoly
2025-02-16 16:53   ` [PATCH v8 07/17] app/test: add test for rte_free_sensitive Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 08/17] common/cnxk: remove unused variable Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 09/17] crypto/qat: force zero of keys Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 10/17] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 11/17] crypto/qat: use secure free for keys Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 12/17] bus/uacce: remove memset before free Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 13/17] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 14/17] test: remove unneeded memset Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 15/17] net/ntnic: check result of malloc Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 16/17] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-16 16:53   ` [PATCH v8 17/17] devtools/cocci: add script to find problematic memset Stephen Hemminger
2025-02-20 16:27 ` [PATCH v9 00/15] fix insecure use of memset bugs Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 01/15] eal: introduce new secure memory zero Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 02/15] app/test: remove unused variable Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 03/15] eal: add new secure free function Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 04/15] app/test: use unit test runner for malloc tests Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 05/15] app/test: add test for rte_free_sensitive Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 06/15] common/cnxk: remove unused variable Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 07/15] crypto/qat: force zero of keys Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 08/15] crypto/qat: fix size calculation for memset Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 09/15] crypto/qat: use secure free for keys Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 10/15] bus/uacce: remove memset before free Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 11/15] compress/octeontx: remove unnecessary memset Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 12/15] test: remove unneeded memset Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 13/15] net/ntnic: check result of malloc Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 14/15] net/ntnic: remove unnecessary memset Stephen Hemminger
2025-02-20 16:27   ` [PATCH v9 15/15] devtools/cocci: add script to find problematic memset Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250215190544.988310-8-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).