From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7794B4624E; Mon, 17 Feb 2025 19:58:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7215640672; Mon, 17 Feb 2025 19:58:08 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id CA49340659 for ; Mon, 17 Feb 2025 19:58:02 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2212a930001so33733215ad.0 for ; Mon, 17 Feb 2025 10:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739818682; x=1740423482; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7zkbE8wL4VFuETNbjAMqpcGLRhJxgUoOTgGqh2F5/TY=; b=UunJKe82qiC8eFL8W32CaK6Jkb3JNhWpJah6nCk+FBArg0Kgw5rKiTNyjVaeaVTQDM aJZXeddNihyjsSNrV4rMDeyvvLArL52xohKimIVwvwRyrfQON7Z4o6loHgrBjzChAmEf D9wSBg+xFLYNVxLatnNtmJDrtVI3dIsu2J8lLlG91cfBrr3YRFb/pv6KCDsH7qBMbk8b b3cgFvlwa0zK3OPe/9kpSOLm+6TQzH6Vdxu0D/1aAikCsckCVPjBMbqBrKWX/iAiL8yi tUWuK1nAxBp5D2Ty6n7bwu1pds1+hGYj6ozfaVSq9M9vQy0Qlv6orWyAG0sB+6TRExaR xx9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739818682; x=1740423482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7zkbE8wL4VFuETNbjAMqpcGLRhJxgUoOTgGqh2F5/TY=; b=J1v6nzbTAjWCN79unSenmG7KDM1AsD3P8wo+GlRp9SiuWKxDs+B3FPMo1WlRQ+J6n5 hs0mjpEtQELLPkKMlCOlN/iL2Po3nY80ZOWViVkgO+Jd2r5qUFa+YXdqId7RgIGWdbKI ZwGm0Y+2kakknhD0v8XdAjQ1n5y/GSW3Xpursc2hLO5qwdPqdnkIkkuRj4bAwa55Kctt QtU4twNXANepzpCZYsXU1t9g6UdnbP1fcO/fBiHnGSXXHe0QBKfWCj/vmquACUvSbQV3 IxiwHC8VrJV+GtXOvswW2/qsxoe/8qqrrL0juz5EiCB0uZunuVEVX+dn+vE+f+dRvJIo RMMQ== X-Gm-Message-State: AOJu0YwgH4NPRpqqlecw/eOmPt+nIN1A1zCi1HYUPdkrhKPoJNO1T4Kz XWLZk4NlcH2w26EvBPX2zX9dLTw2IW5SlgvOQY0ahKXc79v6+OxcEcCZvAocgeyoa/b1z3UxiN6 ScsM= X-Gm-Gg: ASbGncunpiajzpl5KHLQ/FaOqqeED0nKmkW/hop7d29ttJrS00WwsigPkuurovakS97 WaaMhVMbWysib2HyRdmT3PXToDxdpLW5ur8qoRl2f02MwMTjVBcFUPDGkFPMzVy+aWfLKI5SldT bGLvdIzMlfovbykMj/S3ooKt/GYO40dqnBGbTFLlEl1fbchx/phyivpoXXGCGK8mItwBLnHYDV9 XG7mkEsh05LNcb7/7KC3INnWyEw5PcR58l5SNhTGTEezfcJ4mRqpkZ/PuPwhzmOOYP1KxG72RZQ gdLMdLB0XXAehmXTAFvf1OjJKGoZYb3mdMiLlKclNQjVy5M96xigYICCeGDTpkB6GQ+F X-Google-Smtp-Source: AGHT+IE6f7vf7PyB+14b4zX36C2W2m0TY9IX1uVUbmozxCO/+sbEBF+EBp6PZcgVgz7bn9c/GoDTTQ== X-Received: by 2002:a17:902:f54e:b0:216:1543:195e with SMTP id d9443c01a7336-22103ef5b35mr189207745ad.5.1739818681939; Mon, 17 Feb 2025 10:58:01 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-adb57c5dc68sm7815149a12.9.2025.02.17.10.58.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2025 10:58:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [RFC 10/11] mldev: remove unnecessary deref of function pointers Date: Mon, 17 Feb 2025 10:54:09 -0800 Message-ID: <20250217185743.169778-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250217185743.169778-1-stephen@networkplumber.org> References: <20250217185743.169778-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger --- lib/mldev/rte_mldev.c | 88 +++++++++++++++++++++---------------------- 1 file changed, 44 insertions(+), 44 deletions(-) diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c index 37d71aebc9..e0e5b8d9e8 100644 --- a/lib/mldev/rte_mldev.c +++ b/lib/mldev/rte_mldev.c @@ -237,7 +237,7 @@ rte_ml_dev_info_get(int16_t dev_id, struct rte_ml_dev_info *dev_info) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_info_get == NULL) + if (dev->dev_ops->dev_info_get == NULL) return -ENOTSUP; if (dev_info == NULL) { @@ -246,7 +246,7 @@ rte_ml_dev_info_get(int16_t dev_id, struct rte_ml_dev_info *dev_info) } memset(dev_info, 0, sizeof(struct rte_ml_dev_info)); - return (*dev->dev_ops->dev_info_get)(dev, dev_info); + return dev->dev_ops->dev_info_get(dev, dev_info); } int @@ -262,7 +262,7 @@ rte_ml_dev_configure(int16_t dev_id, const struct rte_ml_dev_config *config) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_configure == NULL) + if (dev->dev_ops->dev_configure == NULL) return -ENOTSUP; if (dev->data->dev_started) { @@ -285,7 +285,7 @@ rte_ml_dev_configure(int16_t dev_id, const struct rte_ml_dev_config *config) return -EINVAL; } - return (*dev->dev_ops->dev_configure)(dev, config); + return dev->dev_ops->dev_configure(dev, config); } int @@ -299,7 +299,7 @@ rte_ml_dev_close(int16_t dev_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_close == NULL) + if (dev->dev_ops->dev_close == NULL) return -ENOTSUP; /* Device must be stopped before it can be closed */ @@ -308,7 +308,7 @@ rte_ml_dev_close(int16_t dev_id) return -EBUSY; } - return (*dev->dev_ops->dev_close)(dev); + return dev->dev_ops->dev_close(dev); } int @@ -323,7 +323,7 @@ rte_ml_dev_start(int16_t dev_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_start == NULL) + if (dev->dev_ops->dev_start == NULL) return -ENOTSUP; if (dev->data->dev_started != 0) { @@ -331,7 +331,7 @@ rte_ml_dev_start(int16_t dev_id) return -EBUSY; } - ret = (*dev->dev_ops->dev_start)(dev); + ret = dev->dev_ops->dev_start(dev); if (ret == 0) dev->data->dev_started = 1; @@ -350,7 +350,7 @@ rte_ml_dev_stop(int16_t dev_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_stop == NULL) + if (dev->dev_ops->dev_stop == NULL) return -ENOTSUP; if (dev->data->dev_started == 0) { @@ -358,7 +358,7 @@ rte_ml_dev_stop(int16_t dev_id) return -EBUSY; } - ret = (*dev->dev_ops->dev_stop)(dev); + ret = dev->dev_ops->dev_stop(dev); if (ret == 0) dev->data->dev_started = 0; @@ -392,7 +392,7 @@ rte_ml_dev_queue_pair_setup(int16_t dev_id, uint16_t queue_pair_id, } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_queue_pair_setup == NULL) + if (dev->dev_ops->dev_queue_pair_setup == NULL) return -ENOTSUP; if (queue_pair_id >= dev->data->nb_queue_pairs) { @@ -410,7 +410,7 @@ rte_ml_dev_queue_pair_setup(int16_t dev_id, uint16_t queue_pair_id, return -EBUSY; } - return (*dev->dev_ops->dev_queue_pair_setup)(dev, queue_pair_id, qp_conf, socket_id); + return dev->dev_ops->dev_queue_pair_setup(dev, queue_pair_id, qp_conf, socket_id); } int @@ -424,7 +424,7 @@ rte_ml_dev_stats_get(int16_t dev_id, struct rte_ml_dev_stats *stats) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_stats_get == NULL) + if (dev->dev_ops->dev_stats_get == NULL) return -ENOTSUP; if (stats == NULL) { @@ -433,7 +433,7 @@ rte_ml_dev_stats_get(int16_t dev_id, struct rte_ml_dev_stats *stats) } memset(stats, 0, sizeof(struct rte_ml_dev_stats)); - return (*dev->dev_ops->dev_stats_get)(dev, stats); + return dev->dev_ops->dev_stats_get(dev, stats); } void @@ -447,10 +447,10 @@ rte_ml_dev_stats_reset(int16_t dev_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_stats_reset == NULL) + if (dev->dev_ops->dev_stats_reset == NULL) return; - (*dev->dev_ops->dev_stats_reset)(dev); + dev->dev_ops->dev_stats_reset(dev); } int @@ -465,10 +465,10 @@ rte_ml_dev_xstats_names_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, in } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_xstats_names_get == NULL) + if (dev->dev_ops->dev_xstats_names_get == NULL) return -ENOTSUP; - return (*dev->dev_ops->dev_xstats_names_get)(dev, mode, model_id, xstats_map, size); + return dev->dev_ops->dev_xstats_names_get(dev, mode, model_id, xstats_map, size); } int @@ -482,7 +482,7 @@ rte_ml_dev_xstats_by_name_get(int16_t dev_id, const char *name, uint16_t *stat_i } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_xstats_by_name_get == NULL) + if (dev->dev_ops->dev_xstats_by_name_get == NULL) return -ENOTSUP; if (name == NULL) { @@ -495,7 +495,7 @@ rte_ml_dev_xstats_by_name_get(int16_t dev_id, const char *name, uint16_t *stat_i return -EINVAL; } - return (*dev->dev_ops->dev_xstats_by_name_get)(dev, name, stat_id, value); + return dev->dev_ops->dev_xstats_by_name_get(dev, name, stat_id, value); } int @@ -510,7 +510,7 @@ rte_ml_dev_xstats_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_xstats_get == NULL) + if (dev->dev_ops->dev_xstats_get == NULL) return -ENOTSUP; if (stat_ids == NULL) { @@ -523,7 +523,7 @@ rte_ml_dev_xstats_get(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_t return -EINVAL; } - return (*dev->dev_ops->dev_xstats_get)(dev, mode, model_id, stat_ids, values, nb_ids); + return dev->dev_ops->dev_xstats_get(dev, mode, model_id, stat_ids, values, nb_ids); } int @@ -538,10 +538,10 @@ rte_ml_dev_xstats_reset(int16_t dev_id, enum rte_ml_dev_xstats_mode mode, int32_ } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_xstats_reset == NULL) + if (dev->dev_ops->dev_xstats_reset == NULL) return -ENOTSUP; - return (*dev->dev_ops->dev_xstats_reset)(dev, mode, model_id, stat_ids, nb_ids); + return dev->dev_ops->dev_xstats_reset(dev, mode, model_id, stat_ids, nb_ids); } int @@ -555,7 +555,7 @@ rte_ml_dev_dump(int16_t dev_id, FILE *fd) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_dump == NULL) + if (dev->dev_ops->dev_dump == NULL) return -ENOTSUP; if (fd == NULL) { @@ -563,7 +563,7 @@ rte_ml_dev_dump(int16_t dev_id, FILE *fd) return -EINVAL; } - return (*dev->dev_ops->dev_dump)(dev, fd); + return dev->dev_ops->dev_dump(dev, fd); } int @@ -577,10 +577,10 @@ rte_ml_dev_selftest(int16_t dev_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->dev_selftest == NULL) + if (dev->dev_ops->dev_selftest == NULL) return -ENOTSUP; - return (*dev->dev_ops->dev_selftest)(dev); + return dev->dev_ops->dev_selftest(dev); } int @@ -594,7 +594,7 @@ rte_ml_model_load(int16_t dev_id, struct rte_ml_model_params *params, uint16_t * } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_load == NULL) + if (dev->dev_ops->model_load == NULL) return -ENOTSUP; if (params == NULL) { @@ -607,7 +607,7 @@ rte_ml_model_load(int16_t dev_id, struct rte_ml_model_params *params, uint16_t * return -EINVAL; } - return (*dev->dev_ops->model_load)(dev, params, model_id); + return dev->dev_ops->model_load(dev, params, model_id); } int @@ -621,10 +621,10 @@ rte_ml_model_unload(int16_t dev_id, uint16_t model_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_unload == NULL) + if (dev->dev_ops->model_unload == NULL) return -ENOTSUP; - return (*dev->dev_ops->model_unload)(dev, model_id); + return dev->dev_ops->model_unload(dev, model_id); } int @@ -638,10 +638,10 @@ rte_ml_model_start(int16_t dev_id, uint16_t model_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_start == NULL) + if (dev->dev_ops->model_start == NULL) return -ENOTSUP; - return (*dev->dev_ops->model_start)(dev, model_id); + return dev->dev_ops->model_start(dev, model_id); } int @@ -655,10 +655,10 @@ rte_ml_model_stop(int16_t dev_id, uint16_t model_id) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_stop == NULL) + if (dev->dev_ops->model_stop == NULL) return -ENOTSUP; - return (*dev->dev_ops->model_stop)(dev, model_id); + return dev->dev_ops->model_stop(dev, model_id); } int @@ -672,7 +672,7 @@ rte_ml_model_info_get(int16_t dev_id, uint16_t model_id, struct rte_ml_model_inf } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_info_get == NULL) + if (dev->dev_ops->model_info_get == NULL) return -ENOTSUP; if (model_info == NULL) { @@ -681,7 +681,7 @@ rte_ml_model_info_get(int16_t dev_id, uint16_t model_id, struct rte_ml_model_inf return -EINVAL; } - return (*dev->dev_ops->model_info_get)(dev, model_id, model_info); + return dev->dev_ops->model_info_get(dev, model_id, model_info); } int @@ -695,7 +695,7 @@ rte_ml_model_params_update(int16_t dev_id, uint16_t model_id, void *buffer) } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->model_params_update == NULL) + if (dev->dev_ops->model_params_update == NULL) return -ENOTSUP; if (buffer == NULL) { @@ -703,7 +703,7 @@ rte_ml_model_params_update(int16_t dev_id, uint16_t model_id, void *buffer) return -EINVAL; } - return (*dev->dev_ops->model_params_update)(dev, model_id, buffer); + return dev->dev_ops->model_params_update(dev, model_id, buffer); } int @@ -718,7 +718,7 @@ rte_ml_io_quantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg **d } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->io_quantize == NULL) + if (dev->dev_ops->io_quantize == NULL) return -ENOTSUP; if (dbuffer == NULL) { @@ -731,7 +731,7 @@ rte_ml_io_quantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg **d return -EINVAL; } - return (*dev->dev_ops->io_quantize)(dev, model_id, dbuffer, qbuffer); + return dev->dev_ops->io_quantize(dev, model_id, dbuffer, qbuffer); } int @@ -746,7 +746,7 @@ rte_ml_io_dequantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg * } dev = rte_ml_dev_pmd_get_dev(dev_id); - if (*dev->dev_ops->io_dequantize == NULL) + if (dev->dev_ops->io_dequantize == NULL) return -ENOTSUP; if (qbuffer == NULL) { @@ -759,7 +759,7 @@ rte_ml_io_dequantize(int16_t dev_id, uint16_t model_id, struct rte_ml_buff_seg * return -EINVAL; } - return (*dev->dev_ops->io_dequantize)(dev, model_id, qbuffer, dbuffer); + return dev->dev_ops->io_dequantize(dev, model_id, qbuffer, dbuffer); } /** Initialise rte_ml_op mempool element */ -- 2.47.2