Re: [PATCH v2 10/10] app: enable app directory to be compiled with MSVC

[Andre Muezerie <andremue@linux.microsoft.com>]

On Wed, Feb 19, 2025 at 10:15:21AM +0100, David Marchand wrote:
> On Tue, Feb 18, 2025 at 5:33 PM Andre Muezerie
> <andremue@linux.microsoft.com> wrote:
> > diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
> > index f1c36529b4..8e8863812a 100644
> > --- a/app/test-pmd/meson.build
> > +++ b/app/test-pmd/meson.build
> > @@ -3,7 +3,9 @@
> >
> >  # override default name to drop the hyphen
> >  name = 'testpmd'
> > -cflags += '-Wno-deprecated-declarations'
> > +if cc.has_argument('-Wno-deprecated-declarations')
> > +    cflags += '-Wno-deprecated-declarations'
> > +endif
> >  sources = files(
> >          '5tswap.c',
> >          'cmdline.c',
> 
> We don't need this flag anymore.
> 
> This is probably a remnant of 9f2be5b3db8b ("ethdev: deprecate attach
> and detach functions"), which got fixed later with
> c9cce42876f5 ("ethdev: remove deprecated attach/detach functions").
> 
> 
> -- 
> David Marchand

Good to know. I'll remove it then.