From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Fan Zhang <fanzhang.oss@gmail.com>,
Ashish Gupta <ashish.gupta@marvell.com>
Subject: [PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers
Date: Wed, 19 Feb 2025 18:32:13 -0800 [thread overview]
Message-ID: <20250220023509.630569-10-stephen@networkplumber.org> (raw)
In-Reply-To: <20250220023509.630569-1-stephen@networkplumber.org>
The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->info_get
are equivalent.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/compressdev/rte_compressdev.c | 56 +++++++++++++++----------------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/lib/compressdev/rte_compressdev.c b/lib/compressdev/rte_compressdev.c
index cf2c20a704..1fc4661ef0 100644
--- a/lib/compressdev/rte_compressdev.c
+++ b/lib/compressdev/rte_compressdev.c
@@ -316,9 +316,9 @@ rte_compressdev_queue_pairs_config(struct rte_compressdev *dev,
memset(&dev_info, 0, sizeof(struct rte_compressdev_info));
- if (*dev->dev_ops->dev_infos_get == NULL)
+ if (dev->dev_ops->dev_infos_get == NULL)
return -ENOTSUP;
- (*dev->dev_ops->dev_infos_get)(dev, &dev_info);
+ dev->dev_ops->dev_infos_get(dev, &dev_info);
if ((dev_info.max_nb_queue_pairs != 0) &&
(nb_qpairs > dev_info.max_nb_queue_pairs)) {
@@ -346,11 +346,11 @@ rte_compressdev_queue_pairs_config(struct rte_compressdev *dev,
qp = dev->data->queue_pairs;
- if (*dev->dev_ops->queue_pair_release == NULL)
+ if (dev->dev_ops->queue_pair_release == NULL)
return -ENOTSUP;
for (i = nb_qpairs; i < old_nb_queues; i++) {
- ret = (*dev->dev_ops->queue_pair_release)(dev, i);
+ ret = dev->dev_ops->queue_pair_release(dev, i);
if (ret < 0)
return ret;
}
@@ -397,11 +397,11 @@ rte_compressdev_queue_pairs_release(struct rte_compressdev *dev)
COMPRESSDEV_LOG(DEBUG, "Free %d queues pairs on device %u",
dev->data->nb_queue_pairs, dev->data->dev_id);
- if (*dev->dev_ops->queue_pair_release == NULL)
+ if (dev->dev_ops->queue_pair_release == NULL)
return -ENOTSUP;
for (i = 0; i < num_qps; i++) {
- ret = (*dev->dev_ops->queue_pair_release)(dev, i);
+ ret = dev->dev_ops->queue_pair_release(dev, i);
if (ret < 0)
return ret;
}
@@ -432,7 +432,7 @@ rte_compressdev_configure(uint8_t dev_id, struct rte_compressdev_config *config)
return -EBUSY;
}
- if (*dev->dev_ops->dev_configure == NULL)
+ if (dev->dev_ops->dev_configure == NULL)
return -ENOTSUP;
/* Setup new number of queue pairs and reconfigure device. */
@@ -445,7 +445,7 @@ rte_compressdev_configure(uint8_t dev_id, struct rte_compressdev_config *config)
return diag;
}
- return (*dev->dev_ops->dev_configure)(dev, config);
+ return dev->dev_ops->dev_configure(dev, config);
}
int
@@ -463,7 +463,7 @@ rte_compressdev_start(uint8_t dev_id)
dev = &rte_comp_devices[dev_id];
- if (*dev->dev_ops->dev_start == NULL)
+ if (dev->dev_ops->dev_start == NULL)
return -ENOTSUP;
if (dev->data->dev_started != 0) {
@@ -472,7 +472,7 @@ rte_compressdev_start(uint8_t dev_id)
return 0;
}
- diag = (*dev->dev_ops->dev_start)(dev);
+ diag = dev->dev_ops->dev_start(dev);
if (diag == 0)
dev->data->dev_started = 1;
else
@@ -493,7 +493,7 @@ rte_compressdev_stop(uint8_t dev_id)
dev = &rte_comp_devices[dev_id];
- if (*dev->dev_ops->dev_stop == NULL)
+ if (dev->dev_ops->dev_stop == NULL)
return;
if (dev->data->dev_started == 0) {
@@ -502,7 +502,7 @@ rte_compressdev_stop(uint8_t dev_id)
return;
}
- (*dev->dev_ops->dev_stop)(dev);
+ dev->dev_ops->dev_stop(dev);
dev->data->dev_started = 0;
}
@@ -532,9 +532,9 @@ rte_compressdev_close(uint8_t dev_id)
if (retval < 0)
return retval;
- if (*dev->dev_ops->dev_close == NULL)
+ if (dev->dev_ops->dev_close == NULL)
return -ENOTSUP;
- retval = (*dev->dev_ops->dev_close)(dev);
+ retval = dev->dev_ops->dev_close(dev);
if (retval < 0)
return retval;
@@ -571,10 +571,10 @@ rte_compressdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
return -EINVAL;
}
- if (*dev->dev_ops->queue_pair_setup == NULL)
+ if (dev->dev_ops->queue_pair_setup == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->queue_pair_setup)(dev, queue_pair_id,
+ return dev->dev_ops->queue_pair_setup(dev, queue_pair_id,
max_inflight_ops, socket_id);
}
@@ -618,9 +618,9 @@ rte_compressdev_stats_get(uint8_t dev_id, struct rte_compressdev_stats *stats)
dev = &rte_comp_devices[dev_id];
memset(stats, 0, sizeof(*stats));
- if (*dev->dev_ops->stats_get == NULL)
+ if (dev->dev_ops->stats_get == NULL)
return -ENOTSUP;
- (*dev->dev_ops->stats_get)(dev, stats);
+ dev->dev_ops->stats_get(dev, stats);
return 0;
}
@@ -636,9 +636,9 @@ rte_compressdev_stats_reset(uint8_t dev_id)
dev = &rte_comp_devices[dev_id];
- if (*dev->dev_ops->stats_reset == NULL)
+ if (dev->dev_ops->stats_reset == NULL)
return;
- (*dev->dev_ops->stats_reset)(dev);
+ dev->dev_ops->stats_reset(dev);
}
@@ -656,9 +656,9 @@ rte_compressdev_info_get(uint8_t dev_id, struct rte_compressdev_info *dev_info)
memset(dev_info, 0, sizeof(struct rte_compressdev_info));
- if (*dev->dev_ops->dev_infos_get == NULL)
+ if (dev->dev_ops->dev_infos_get == NULL)
return;
- (*dev->dev_ops->dev_infos_get)(dev, dev_info);
+ dev->dev_ops->dev_infos_get(dev, dev_info);
dev_info->driver_name = dev->device->driver->name;
}
@@ -676,9 +676,9 @@ rte_compressdev_private_xform_create(uint8_t dev_id,
if (xform == NULL || priv_xform == NULL || dev == NULL)
return -EINVAL;
- if (*dev->dev_ops->private_xform_create == NULL)
+ if (dev->dev_ops->private_xform_create == NULL)
return -ENOTSUP;
- ret = (*dev->dev_ops->private_xform_create)(dev, xform, priv_xform);
+ ret = dev->dev_ops->private_xform_create(dev, xform, priv_xform);
if (ret < 0) {
COMPRESSDEV_LOG(ERR,
"dev_id %d failed to create private_xform: err=%d",
@@ -700,7 +700,7 @@ rte_compressdev_private_xform_free(uint8_t dev_id, void *priv_xform)
if (dev == NULL || priv_xform == NULL)
return -EINVAL;
- if (*dev->dev_ops->private_xform_free == NULL)
+ if (dev->dev_ops->private_xform_free == NULL)
return -ENOTSUP;
ret = dev->dev_ops->private_xform_free(dev, priv_xform);
if (ret < 0) {
@@ -726,9 +726,9 @@ rte_compressdev_stream_create(uint8_t dev_id,
if (xform == NULL || dev == NULL || stream == NULL)
return -EINVAL;
- if (*dev->dev_ops->stream_create == NULL)
+ if (dev->dev_ops->stream_create == NULL)
return -ENOTSUP;
- ret = (*dev->dev_ops->stream_create)(dev, xform, stream);
+ ret = dev->dev_ops->stream_create(dev, xform, stream);
if (ret < 0) {
COMPRESSDEV_LOG(ERR,
"dev_id %d failed to create stream: err=%d",
@@ -751,7 +751,7 @@ rte_compressdev_stream_free(uint8_t dev_id, void *stream)
if (dev == NULL || stream == NULL)
return -EINVAL;
- if (*dev->dev_ops->stream_free == NULL)
+ if (dev->dev_ops->stream_free == NULL)
return -ENOTSUP;
ret = dev->dev_ops->stream_free(dev, stream);
if (ret < 0) {
--
2.47.2
next prev parent reply other threads:[~2025-02-20 2:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 18:53 [RFC 00/11] Fix dev_ops dereferences Stephen Hemminger
2025-02-17 18:54 ` [RFC 01/11] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 02/11] eventdev: remover " Stephen Hemminger
2025-02-17 18:54 ` [RFC 03/11] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 04/11] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 05/11] cryptodev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 06/11] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 07/11] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 08/11] dmadev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 09/11] rawdev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 10/11] mldev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 11/11] regexdev: " Stephen Hemminger
2025-02-17 20:24 ` [RFC 00/11] Fix dev_ops dereferences Morten Brørup
2025-02-18 3:01 ` Stephen Hemminger
2025-02-18 8:47 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 7:09 ` Andrew Rybchenko
2025-02-20 16:09 ` Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 07/14] cryptodev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 2:32 ` Stephen Hemminger [this message]
2025-02-20 2:32 ` [PATCH v2 10/14] dmadev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 3:00 ` fengchengwen
2025-02-20 2:32 ` [PATCH v2 11/14] rawdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 12/14] mldev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 13/14] regexdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-02-20 8:05 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Morten Brørup
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 16:55 ` [PATCH v3 " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 07/14] cryptodev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 10/14] dmadev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 11/14] rawdev: " Stephen Hemminger
2025-02-21 9:12 ` Hemant Agrawal
2025-02-20 16:55 ` [PATCH v3 12/14] mldev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 13/14] regexdev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 14/14] security: remove unnecessary dereference Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220023509.630569-10-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=ashish.gupta@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).