From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Ori Kam <orika@nvidia.com>
Subject: [PATCH v2 13/14] regexdev: remove unnecessary deref of function pointers
Date: Wed, 19 Feb 2025 18:32:17 -0800 [thread overview]
Message-ID: <20250220023509.630569-14-stephen@networkplumber.org> (raw)
In-Reply-To: <20250220023509.630569-1-stephen@networkplumber.org>
The expression *dev->dev_ops->dev_info_get and
dev->dev_ops->dev_info_get are equivalent in C.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/regexdev/rte_regexdev.c | 72 ++++++++++++++++++-------------------
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/lib/regexdev/rte_regexdev.c b/lib/regexdev/rte_regexdev.c
index b2c4b49d97..431ed911a1 100644
--- a/lib/regexdev/rte_regexdev.c
+++ b/lib/regexdev/rte_regexdev.c
@@ -189,9 +189,9 @@ regexdev_info_get(uint8_t dev_id, struct rte_regexdev_info *dev_info)
if (dev_info == NULL)
return -EINVAL;
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_info_get == NULL)
+ if (dev->dev_ops->dev_info_get == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_info_get)(dev, dev_info);
+ return dev->dev_ops->dev_info_get(dev, dev_info);
}
@@ -212,7 +212,7 @@ rte_regexdev_configure(uint8_t dev_id, const struct rte_regexdev_config *cfg)
if (cfg == NULL)
return -EINVAL;
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_configure == NULL)
+ if (dev->dev_ops->dev_configure == NULL)
return -ENOTSUP;
if (dev->data->dev_started) {
RTE_REGEXDEV_LOG_LINE
@@ -289,7 +289,7 @@ rte_regexdev_configure(uint8_t dev_id, const struct rte_regexdev_config *cfg)
dev_info.max_rules_per_group);
return -EINVAL;
}
- ret = (*dev->dev_ops->dev_configure)(dev, cfg);
+ ret = dev->dev_ops->dev_configure(dev, cfg);
if (ret == 0)
dev->data->dev_conf = *cfg;
return ret;
@@ -303,7 +303,7 @@ rte_regexdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_qp_setup == NULL)
+ if (dev->dev_ops->dev_qp_setup == NULL)
return -ENOTSUP;
if (dev->data->dev_started) {
RTE_REGEXDEV_LOG_LINE
@@ -324,7 +324,7 @@ rte_regexdev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,
dev_id);
return -EBUSY;
}
- return (*dev->dev_ops->dev_qp_setup)(dev, queue_pair_id, qp_conf);
+ return dev->dev_ops->dev_qp_setup(dev, queue_pair_id, qp_conf);
}
int
@@ -335,9 +335,9 @@ rte_regexdev_start(uint8_t dev_id)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_start == NULL)
+ if (dev->dev_ops->dev_start == NULL)
return -ENOTSUP;
- ret = (*dev->dev_ops->dev_start)(dev);
+ ret = dev->dev_ops->dev_start(dev);
if (ret == 0)
dev->data->dev_started = 1;
return ret;
@@ -350,9 +350,9 @@ rte_regexdev_stop(uint8_t dev_id)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_stop == NULL)
+ if (dev->dev_ops->dev_stop == NULL)
return -ENOTSUP;
- (*dev->dev_ops->dev_stop)(dev);
+ dev->dev_ops->dev_stop(dev);
dev->data->dev_started = 0;
return 0;
}
@@ -364,9 +364,9 @@ rte_regexdev_close(uint8_t dev_id)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_close == NULL)
+ if (dev->dev_ops->dev_close == NULL)
return -ENOTSUP;
- (*dev->dev_ops->dev_close)(dev);
+ dev->dev_ops->dev_close(dev);
dev->data->dev_started = 0;
dev->state = RTE_REGEXDEV_UNUSED;
return 0;
@@ -380,14 +380,14 @@ rte_regexdev_attr_get(uint8_t dev_id, enum rte_regexdev_attr_id attr_id,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_attr_get == NULL)
+ if (dev->dev_ops->dev_attr_get == NULL)
return -ENOTSUP;
if (attr_value == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d attribute value can't be NULL",
dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_attr_get)(dev, attr_id, attr_value);
+ return dev->dev_ops->dev_attr_get(dev, attr_id, attr_value);
}
int
@@ -398,14 +398,14 @@ rte_regexdev_attr_set(uint8_t dev_id, enum rte_regexdev_attr_id attr_id,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_attr_set == NULL)
+ if (dev->dev_ops->dev_attr_set == NULL)
return -ENOTSUP;
if (attr_value == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d attribute value can't be NULL",
dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_attr_set)(dev, attr_id, attr_value);
+ return dev->dev_ops->dev_attr_set(dev, attr_id, attr_value);
}
int
@@ -417,14 +417,14 @@ rte_regexdev_rule_db_update(uint8_t dev_id,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_rule_db_update == NULL)
+ if (dev->dev_ops->dev_rule_db_update == NULL)
return -ENOTSUP;
if (rules == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d rules can't be NULL",
dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_rule_db_update)(dev, rules, nb_rules);
+ return dev->dev_ops->dev_rule_db_update(dev, rules, nb_rules);
}
int
@@ -434,9 +434,9 @@ rte_regexdev_rule_db_compile_activate(uint8_t dev_id)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_rule_db_compile_activate == NULL)
+ if (dev->dev_ops->dev_rule_db_compile_activate == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_rule_db_compile_activate)(dev);
+ return dev->dev_ops->dev_rule_db_compile_activate(dev);
}
int
@@ -447,14 +447,14 @@ rte_regexdev_rule_db_import(uint8_t dev_id, const char *rule_db,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_db_import == NULL)
+ if (dev->dev_ops->dev_db_import == NULL)
return -ENOTSUP;
if (rule_db == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d rules can't be NULL",
dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_db_import)(dev, rule_db, rule_db_len);
+ return dev->dev_ops->dev_db_import(dev, rule_db, rule_db_len);
}
int
@@ -464,9 +464,9 @@ rte_regexdev_rule_db_export(uint8_t dev_id, char *rule_db)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_db_export == NULL)
+ if (dev->dev_ops->dev_db_export == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_db_export)(dev, rule_db);
+ return dev->dev_ops->dev_db_export(dev, rule_db);
}
int
@@ -477,14 +477,14 @@ rte_regexdev_xstats_names_get(uint8_t dev_id,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_xstats_names_get == NULL)
+ if (dev->dev_ops->dev_xstats_names_get == NULL)
return -ENOTSUP;
if (xstats_map == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d xstats map can't be NULL",
dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_names_get)(dev, xstats_map);
+ return dev->dev_ops->dev_xstats_names_get(dev, xstats_map);
}
int
@@ -495,7 +495,7 @@ rte_regexdev_xstats_get(uint8_t dev_id, const uint16_t *ids,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_xstats_get == NULL)
+ if (dev->dev_ops->dev_xstats_get == NULL)
return -ENOTSUP;
if (ids == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d ids can't be NULL", dev_id);
@@ -505,7 +505,7 @@ rte_regexdev_xstats_get(uint8_t dev_id, const uint16_t *ids,
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d values can't be NULL", dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_get)(dev, ids, values, n);
+ return dev->dev_ops->dev_xstats_get(dev, ids, values, n);
}
int
@@ -516,7 +516,7 @@ rte_regexdev_xstats_by_name_get(uint8_t dev_id, const char *name,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_xstats_by_name_get == NULL)
+ if (dev->dev_ops->dev_xstats_by_name_get == NULL)
return -ENOTSUP;
if (name == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d name can't be NULL", dev_id);
@@ -530,7 +530,7 @@ rte_regexdev_xstats_by_name_get(uint8_t dev_id, const char *name,
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d value can't be NULL", dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_by_name_get)(dev, name, id, value);
+ return dev->dev_ops->dev_xstats_by_name_get(dev, name, id, value);
}
int
@@ -541,13 +541,13 @@ rte_regexdev_xstats_reset(uint8_t dev_id, const uint16_t *ids,
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_xstats_reset == NULL)
+ if (dev->dev_ops->dev_xstats_reset == NULL)
return -ENOTSUP;
if (ids == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d ids can't be NULL", dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_xstats_reset)(dev, ids, nb_ids);
+ return dev->dev_ops->dev_xstats_reset(dev, ids, nb_ids);
}
int
@@ -557,9 +557,9 @@ rte_regexdev_selftest(uint8_t dev_id)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_selftest == NULL)
+ if (dev->dev_ops->dev_selftest == NULL)
return -ENOTSUP;
- return (*dev->dev_ops->dev_selftest)(dev);
+ return dev->dev_ops->dev_selftest(dev);
}
int
@@ -569,11 +569,11 @@ rte_regexdev_dump(uint8_t dev_id, FILE *f)
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
dev = &rte_regex_devices[dev_id];
- if (*dev->dev_ops->dev_dump == NULL)
+ if (dev->dev_ops->dev_dump == NULL)
return -ENOTSUP;
if (f == NULL) {
RTE_REGEXDEV_LOG_LINE(ERR, "Dev %d file can't be NULL", dev_id);
return -EINVAL;
}
- return (*dev->dev_ops->dev_dump)(dev, f);
+ return dev->dev_ops->dev_dump(dev, f);
}
--
2.47.2
next prev parent reply other threads:[~2025-02-20 2:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 18:53 [RFC 00/11] Fix dev_ops dereferences Stephen Hemminger
2025-02-17 18:54 ` [RFC 01/11] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 02/11] eventdev: remover " Stephen Hemminger
2025-02-17 18:54 ` [RFC 03/11] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 04/11] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 05/11] cryptodev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 06/11] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 07/11] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 08/11] dmadev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 09/11] rawdev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 10/11] mldev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 11/11] regexdev: " Stephen Hemminger
2025-02-17 20:24 ` [RFC 00/11] Fix dev_ops dereferences Morten Brørup
2025-02-18 3:01 ` Stephen Hemminger
2025-02-18 8:47 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 7:09 ` Andrew Rybchenko
2025-02-20 16:09 ` Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 2:32 ` [PATCH v2 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 07/14] cryptodev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 10/14] dmadev: " Stephen Hemminger
2025-02-20 3:00 ` fengchengwen
2025-02-20 2:32 ` [PATCH v2 11/14] rawdev: " Stephen Hemminger
2025-02-20 2:32 ` [PATCH v2 12/14] mldev: " Stephen Hemminger
2025-02-20 2:32 ` Stephen Hemminger [this message]
2025-02-20 2:32 ` [PATCH v2 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-02-20 8:05 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Morten Brørup
2025-02-20 9:17 ` Bruce Richardson
2025-02-20 16:55 ` [PATCH v3 " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 07/14] cryptodev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 10/14] dmadev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 11/14] rawdev: " Stephen Hemminger
2025-02-21 9:12 ` Hemant Agrawal
2025-02-20 16:55 ` [PATCH v3 12/14] mldev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 13/14] regexdev: " Stephen Hemminger
2025-02-20 16:55 ` [PATCH v3 14/14] security: remove unnecessary dereference Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220023509.630569-14-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).