From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 583AB46280; Thu, 20 Feb 2025 17:58:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D51A40691; Thu, 20 Feb 2025 17:57:19 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 000BB40615 for ; Thu, 20 Feb 2025 17:57:13 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2f9b91dff71so1834008a91.2 for ; Thu, 20 Feb 2025 08:57:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1740070633; x=1740675433; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p4YMQSOBDUoR/JYUBxJpDPbI0++BG1cvHkK22nYw6qg=; b=aCCal1gkF1aPstJhS+bA8+LNvlfdZZiEtszZW6Bfg+liN3tJjm7lyJeLRC9wVrSRKr qmU0GH7GvkKFgrJGkAozDPMx0qQQ1+D5fTgXbitLFQm/uH4DbH6Rhz6he2cQ+LCthRDm 7LSaZuFVKbP3JMEkvYt1nsiUHsl/g1qGz1DuW1TZGzfNdfdIVlq/VsebiVFtsD/w+UTF GZpJBmi/qmtwD3uEcjUiiBDyzq+RvToeJhnhPpkc+eVYT4/cWG6Q4oz3bAO+G3X/lNyc J7GVXgY+BYq/thXMlm8nAzrxM4hdVv0fPGX2tsD4f0ddQTj21pJPQhPGw/sjaIR+twE4 d7wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740070633; x=1740675433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p4YMQSOBDUoR/JYUBxJpDPbI0++BG1cvHkK22nYw6qg=; b=chTC6NyzLlvBZEuGM8Atz8I7cwUraUN0rhCQjsylfvPlkLsCfjCjI+xG6oVPhGmMmZ ARvQIorDmCcaFHPa1GRAJaG4QNNVC7I87dKScq4GpG7sQmL3mODTeCirX5Nn/m/JmnDt cP/I/tZ/cpSqcdytXU6ZDlMMvkdgv5/yNFwzZCKPEWphkw5a9V8CmptHNRs1ISo9uqES C1b3KAc/Hrp45MutQ1GekNa6lM8UWwWrX8kIlzSPPRip4pJheLfnprD8an4YjA8HNiuy 1sz85PbWVUJVUWc9Ex9FrBe1cEKfMcN1MeJLyDipFaFAZWvnWobOjdpOQacsxzW+c1f6 kYdQ== X-Gm-Message-State: AOJu0YxyJQDCWebFzSXiAhQ4+zrMtlQ+l7yD4lKfyd4/lk0jg9+xBS9j RSPIszc7ptyQesupBi2kGAC1ca3+9PxTKF2yf0uMajwBtOVcPOfx1JA/c47zQaPMS6r2fwiNaYu S X-Gm-Gg: ASbGncuG4EWj+X0BgQCouJ43MVkkJgA0qfptXoq2v098bth4vgE6W0NwatFtdlMJZeM Va/jaQLl7C5SWJ61VSnsOrjd9/xJTi4ZT0qp4W83qfJK5mwEG/TS07B5Q602H6eckOudi/uoln/ Naf/XXMA8UMXGdoIL9zXuwDqIxOtw1nPzPlh3QZrzEbgB5W2iEfoqdzKDxikBO6AtztS5vXCdCE Jlpp8RJua0kKp1gV69rzVq53+/CENkQMKgG2HI4VWiQDeCAGwgUoncLbkYCwT2pd9nxQMysGmsD a9chHhxfBsF2iPYQMebM4sc+xFEh8mhzobgUMbL/F+baeTiHUxDPnFOoLIqNoRy6NVCw X-Google-Smtp-Source: AGHT+IFqwgODCYrWWHvnFTbsCyuKscMMY90Hw9Alx10GtFdDtmBI9VFKXgcaCd/rQxYPbJ6IcNKqVQ== X-Received: by 2002:a17:90a:ea93:b0:2fc:a3b7:10a2 with SMTP id 98e67ed59e1d1-2fcb5a39f2amr14949570a91.17.1740070633128; Thu, 20 Feb 2025 08:57:13 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d53491b3sm122729435ad.40.2025.02.20.08.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2025 08:57:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Sachin Saxena , Hemant Agrawal Subject: [PATCH v3 11/14] rawdev: remove unnecessary deref of function pointers Date: Thu, 20 Feb 2025 08:55:25 -0800 Message-ID: <20250220165644.16421-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250220165644.16421-1-stephen@networkplumber.org> References: <20250217185743.169778-1-stephen@networkplumber.org> <20250220165644.16421-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The expression *dev->dev_ops->dev_configure and dev->dev_ops->dev_configure are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/rawdev/rte_rawdev.c | 99 ++++++++++++++++++++--------------------- 1 file changed, 48 insertions(+), 51 deletions(-) diff --git a/lib/rawdev/rte_rawdev.c b/lib/rawdev/rte_rawdev.c index 4f8897b639..810e95a440 100644 --- a/lib/rawdev/rte_rawdev.c +++ b/lib/rawdev/rte_rawdev.c @@ -77,9 +77,9 @@ rte_rawdev_info_get(uint16_t dev_id, struct rte_rawdev_info *dev_info, rawdev = &rte_rawdevs[dev_id]; if (dev_info->dev_private != NULL) { - if (*rawdev->dev_ops->dev_info_get == NULL) + if (rawdev->dev_ops->dev_info_get == NULL) return -ENOTSUP; - ret = (*rawdev->dev_ops->dev_info_get)(rawdev, + ret = rawdev->dev_ops->dev_info_get(rawdev, dev_info->dev_private, dev_private_size); } @@ -104,7 +104,7 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf, dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dev_configure == NULL) + if (dev->dev_ops->dev_configure == NULL) return -ENOTSUP; if (dev->started) { @@ -114,8 +114,7 @@ rte_rawdev_configure(uint16_t dev_id, struct rte_rawdev_info *dev_conf, } /* Configure the device */ - diag = (*dev->dev_ops->dev_configure)(dev, dev_conf->dev_private, - dev_private_size); + diag = dev->dev_ops->dev_configure(dev, dev_conf->dev_private, dev_private_size); if (diag != 0) RTE_RDEV_ERR("dev%d dev_configure = %d", dev_id, diag); else @@ -135,10 +134,9 @@ rte_rawdev_queue_conf_get(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->queue_def_conf == NULL) + if (dev->dev_ops->queue_def_conf == NULL) return -ENOTSUP; - return (*dev->dev_ops->queue_def_conf)(dev, queue_id, queue_conf, - queue_conf_size); + return dev->dev_ops->queue_def_conf(dev, queue_id, queue_conf, queue_conf_size); } int @@ -152,10 +150,9 @@ rte_rawdev_queue_setup(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->queue_setup == NULL) + if (dev->dev_ops->queue_setup == NULL) return -ENOTSUP; - return (*dev->dev_ops->queue_setup)(dev, queue_id, queue_conf, - queue_conf_size); + return dev->dev_ops->queue_setup(dev, queue_id, queue_conf, queue_conf_size); } int @@ -166,9 +163,9 @@ rte_rawdev_queue_release(uint16_t dev_id, uint16_t queue_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->queue_release == NULL) + if (dev->dev_ops->queue_release == NULL) return -ENOTSUP; - return (*dev->dev_ops->queue_release)(dev, queue_id); + return dev->dev_ops->queue_release(dev, queue_id); } uint16_t @@ -179,9 +176,9 @@ rte_rawdev_queue_count(uint16_t dev_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->queue_count == NULL) + if (dev->dev_ops->queue_count == NULL) return -ENOTSUP; - return (*dev->dev_ops->queue_count)(dev); + return dev->dev_ops->queue_count(dev); } int @@ -194,9 +191,9 @@ rte_rawdev_get_attr(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->attr_get == NULL) + if (dev->dev_ops->attr_get == NULL) return -ENOTSUP; - return (*dev->dev_ops->attr_get)(dev, attr_name, attr_value); + return dev->dev_ops->attr_get(dev, attr_name, attr_value); } int @@ -209,9 +206,9 @@ rte_rawdev_set_attr(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->attr_set == NULL) + if (dev->dev_ops->attr_set == NULL) return -ENOTSUP; - return (*dev->dev_ops->attr_set)(dev, attr_name, attr_value); + return dev->dev_ops->attr_set(dev, attr_name, attr_value); } int @@ -225,9 +222,9 @@ rte_rawdev_enqueue_buffers(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->enqueue_bufs == NULL) + if (dev->dev_ops->enqueue_bufs == NULL) return -ENOTSUP; - return (*dev->dev_ops->enqueue_bufs)(dev, buffers, count, context); + return dev->dev_ops->enqueue_bufs(dev, buffers, count, context); } int @@ -241,9 +238,9 @@ rte_rawdev_dequeue_buffers(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dequeue_bufs == NULL) + if (dev->dev_ops->dequeue_bufs == NULL) return -ENOTSUP; - return (*dev->dev_ops->dequeue_bufs)(dev, buffers, count, context); + return dev->dev_ops->dequeue_bufs(dev, buffers, count, context); } int @@ -254,9 +251,9 @@ rte_rawdev_dump(uint16_t dev_id, FILE *f) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dump == NULL) + if (dev->dev_ops->dump == NULL) return -ENOTSUP; - return (*dev->dev_ops->dump)(dev, f); + return dev->dev_ops->dump(dev, f); } static int @@ -264,9 +261,9 @@ xstats_get_count(uint16_t dev_id) { struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->xstats_get_names == NULL) + if (dev->dev_ops->xstats_get_names == NULL) return -ENOTSUP; - return (*dev->dev_ops->xstats_get_names)(dev, NULL, 0); + return dev->dev_ops->xstats_get_names(dev, NULL, 0); } int @@ -287,9 +284,9 @@ rte_rawdev_xstats_names_get(uint16_t dev_id, dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->xstats_get_names == NULL) + if (dev->dev_ops->xstats_get_names == NULL) return -ENOTSUP; - return (*dev->dev_ops->xstats_get_names)(dev, xstats_names, size); + return dev->dev_ops->xstats_get_names(dev, xstats_names, size); } /* retrieve rawdev extended statistics */ @@ -302,9 +299,9 @@ rte_rawdev_xstats_get(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -ENODEV); const struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->xstats_get == NULL) + if (dev->dev_ops->xstats_get == NULL) return -ENOTSUP; - return (*dev->dev_ops->xstats_get)(dev, ids, values, n); + return dev->dev_ops->xstats_get(dev, ids, values, n); } uint64_t @@ -322,9 +319,9 @@ rte_rawdev_xstats_by_name_get(uint16_t dev_id, id = &temp; /* driver never gets a NULL value */ /* implemented by driver */ - if (*dev->dev_ops->xstats_get_by_name == NULL) + if (dev->dev_ops->xstats_get_by_name == NULL) return -ENOTSUP; - return (*dev->dev_ops->xstats_get_by_name)(dev, name, id); + return dev->dev_ops->xstats_get_by_name(dev, name, id); } int @@ -334,9 +331,9 @@ rte_rawdev_xstats_reset(uint16_t dev_id, RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->xstats_reset == NULL) + if (dev->dev_ops->xstats_reset == NULL) return -ENOTSUP; - return (*dev->dev_ops->xstats_reset)(dev, ids, nb_ids); + return dev->dev_ops->xstats_reset(dev, ids, nb_ids); } int @@ -345,9 +342,9 @@ rte_rawdev_firmware_status_get(uint16_t dev_id, rte_rawdev_obj_t status_info) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->firmware_status_get == NULL) + if (dev->dev_ops->firmware_status_get == NULL) return -ENOTSUP; - return (*dev->dev_ops->firmware_status_get)(dev, status_info); + return dev->dev_ops->firmware_status_get(dev, status_info); } int @@ -356,9 +353,9 @@ rte_rawdev_firmware_version_get(uint16_t dev_id, rte_rawdev_obj_t version_info) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->firmware_version_get == NULL) + if (dev->dev_ops->firmware_version_get == NULL) return -ENOTSUP; - return (*dev->dev_ops->firmware_version_get)(dev, version_info); + return dev->dev_ops->firmware_version_get(dev, version_info); } int @@ -370,9 +367,9 @@ rte_rawdev_firmware_load(uint16_t dev_id, rte_rawdev_obj_t firmware_image) if (!firmware_image) return -EINVAL; - if (*dev->dev_ops->firmware_load == NULL) + if (dev->dev_ops->firmware_load == NULL) return -ENOTSUP; - return (*dev->dev_ops->firmware_load)(dev, firmware_image); + return dev->dev_ops->firmware_load(dev, firmware_image); } int @@ -381,9 +378,9 @@ rte_rawdev_firmware_unload(uint16_t dev_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->firmware_load == NULL) + if (dev->dev_ops->firmware_load == NULL) return -ENOTSUP; - return (*dev->dev_ops->firmware_unload)(dev); + return dev->dev_ops->firmware_unload(dev); } int @@ -392,9 +389,9 @@ rte_rawdev_selftest(uint16_t dev_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); struct rte_rawdev *dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dev_selftest == NULL) + if (dev->dev_ops->dev_selftest == NULL) return -ENOTSUP; - return (*dev->dev_ops->dev_selftest)(dev_id); + return dev->dev_ops->dev_selftest(dev_id); } int @@ -416,7 +413,7 @@ rte_rawdev_start(uint16_t dev_id) if (dev->dev_ops->dev_start == NULL) goto mark_started; - diag = (*dev->dev_ops->dev_start)(dev); + diag = dev->dev_ops->dev_start(dev); if (diag != 0) return diag; @@ -444,7 +441,7 @@ rte_rawdev_stop(uint16_t dev_id) if (dev->dev_ops->dev_stop == NULL) goto mark_stopped; - (*dev->dev_ops->dev_stop)(dev); + dev->dev_ops->dev_stop(dev); mark_stopped: dev->started = 0; @@ -458,7 +455,7 @@ rte_rawdev_close(uint16_t dev_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dev_close == NULL) + if (dev->dev_ops->dev_close == NULL) return -ENOTSUP; /* Device must be stopped before it can be closed */ if (dev->started == 1) { @@ -467,7 +464,7 @@ rte_rawdev_close(uint16_t dev_id) return -EBUSY; } - return (*dev->dev_ops->dev_close)(dev); + return dev->dev_ops->dev_close(dev); } int @@ -478,10 +475,10 @@ rte_rawdev_reset(uint16_t dev_id) RTE_RAWDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); dev = &rte_rawdevs[dev_id]; - if (*dev->dev_ops->dev_reset == NULL) + if (dev->dev_ops->dev_reset == NULL) return -ENOTSUP; /* Reset is not dependent on state of the device */ - return (*dev->dev_ops->dev_reset)(dev); + return dev->dev_ops->dev_reset(dev); } static inline uint8_t -- 2.47.2