DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: "Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"Jakub Grajciar" <jgrajcia@cisco.com>
Subject: [PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers
Date: Thu, 20 Feb 2025 08:55:20 -0800	[thread overview]
Message-ID: <20250220165644.16421-7-stephen@networkplumber.org> (raw)
In-Reply-To: <20250220165644.16421-1-stephen@networkplumber.org>

Since queue release functions are local to driver, prefer those
over dereferencing the dev_ops table.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/memif/rte_eth_memif.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index c0bf1e3bbf..f7b04c4f9e 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -70,6 +70,8 @@ static const struct rte_eth_link pmd_link = {
 
 static int memif_region_init_zc(const struct rte_memseg_list *msl,
 				const struct rte_memseg *ms, void *arg);
+static void memif_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid);
+static void memif_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid);
 
 const char *
 memif_version(void)
@@ -1418,9 +1420,9 @@ memif_dev_close(struct rte_eth_dev *dev)
 		memif_msg_enq_disconnect(pmd->cc, "Device closed", 0);
 
 		for (i = 0; i < dev->data->nb_rx_queues; i++)
-			(*dev->dev_ops->rx_queue_release)(dev, i);
+			memif_rx_queue_release(dev, i);
 		for (i = 0; i < dev->data->nb_tx_queues; i++)
-			(*dev->dev_ops->tx_queue_release)(dev, i);
+			memif_tx_queue_release(dev, i);
 
 		memif_socket_remove_device(dev);
 	}
-- 
2.47.2


  parent reply	other threads:[~2025-02-20 16:57 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 18:53 [RFC 00/11] Fix dev_ops dereferences Stephen Hemminger
2025-02-17 18:54 ` [RFC 01/11] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 02/11] eventdev: remover " Stephen Hemminger
2025-02-17 18:54 ` [RFC 03/11] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 04/11] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 05/11] cryptodev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 06/11] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-17 18:54 ` [RFC 07/11] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-17 18:54 ` [RFC 08/11] dmadev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 09/11] rawdev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 10/11] mldev: " Stephen Hemminger
2025-02-17 18:54 ` [RFC 11/11] regexdev: " Stephen Hemminger
2025-02-17 20:24 ` [RFC 00/11] Fix dev_ops dereferences Morten Brørup
2025-02-18  3:01   ` Stephen Hemminger
2025-02-18  8:47   ` Bruce Richardson
2025-02-20  2:32 ` [PATCH v2 00/14] Remove unnecessary function pointer deref Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20  7:09     ` Andrew Rybchenko
2025-02-20 16:09       ` Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 02/14] eventdev: remover " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20  9:17     ` Bruce Richardson
2025-02-20  2:32   ` [PATCH v2 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 06/14] net/memif: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 07/14] cryptodev: " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 10/14] dmadev: " Stephen Hemminger
2025-02-20  3:00     ` fengchengwen
2025-02-20  2:32   ` [PATCH v2 11/14] rawdev: " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 12/14] mldev: " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 13/14] regexdev: " Stephen Hemminger
2025-02-20  2:32   ` [PATCH v2 14/14] security: remove unnecessary dereference Stephen Hemminger
2025-02-20  8:05   ` [PATCH v2 00/14] Remove unnecessary function pointer deref Morten Brørup
2025-02-20  9:17   ` Bruce Richardson
2025-02-20 16:55 ` [PATCH v3 " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 02/14] eventdev: remover " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 03/14] net/bonding: remove unnecessary deref of " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 04/14] net/ixgbe: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 05/14] net/ipn3ke: " Stephen Hemminger
2025-02-20 16:55   ` Stephen Hemminger [this message]
2025-02-20 16:55   ` [PATCH v3 07/14] cryptodev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 10/14] dmadev: " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 11/14] rawdev: " Stephen Hemminger
2025-02-21  9:12     ` Hemant Agrawal
2025-02-20 16:55   ` [PATCH v3 12/14] mldev: " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 13/14] regexdev: " Stephen Hemminger
2025-02-20 16:55   ` [PATCH v3 14/14] security: remove unnecessary dereference Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220165644.16421-7-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).