* [PATCH] sched: fix wrr parameter data type
@ 2025-02-21 12:47 Megha Ajmera
2025-02-21 13:02 ` Singh, Jasvinder
2025-02-21 19:14 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: Megha Ajmera @ 2025-02-21 12:47 UTC (permalink / raw)
To: dev; +Cc: jasvinder.singh, cristian.dumitrescu
wrr tokens getting truncated to uint8_t in wrr_store function() due to
type mismatch. This patch chnages the data type to uint16_t.
Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues")
Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
---
lib/sched/rte_sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
index d8ee4e7e91..dcef44b91b 100644
--- a/lib/sched/rte_sched.c
+++ b/lib/sched/rte_sched.c
@@ -66,7 +66,7 @@ struct __rte_cache_aligned rte_sched_pipe {
uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
/* Weighted Round Robin (WRR) */
- uint8_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
+ uint16_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
/* TC oversubscription */
uint64_t tc_ov_credits;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] sched: fix wrr parameter data type
2025-02-21 12:47 [PATCH] sched: fix wrr parameter data type Megha Ajmera
@ 2025-02-21 13:02 ` Singh, Jasvinder
2025-02-21 19:14 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Singh, Jasvinder @ 2025-02-21 13:02 UTC (permalink / raw)
To: Ajmera, Megha, dev; +Cc: Dumitrescu, Cristian
> -----Original Message-----
> From: Ajmera, Megha <megha.ajmera@intel.com>
> Sent: Friday, February 21, 2025 12:48 PM
> To: dev@dpdk.org
> Cc: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH] sched: fix wrr parameter data type
>
> wrr tokens getting truncated to uint8_t in wrr_store function() due to type
> mismatch. This patch chnages the data type to uint16_t.
>
> Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues")
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> lib/sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index
> d8ee4e7e91..dcef44b91b 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -66,7 +66,7 @@ struct __rte_cache_aligned rte_sched_pipe {
> uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
>
> /* Weighted Round Robin (WRR) */
> - uint8_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
> + uint16_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
>
> /* TC oversubscription */
> uint64_t tc_ov_credits;
> --
> 2.34.1
Acked-by: Jasvinder Singh <Jasvinder.singh@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: fix wrr parameter data type
2025-02-21 12:47 [PATCH] sched: fix wrr parameter data type Megha Ajmera
2025-02-21 13:02 ` Singh, Jasvinder
@ 2025-02-21 19:14 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2025-02-21 19:14 UTC (permalink / raw)
To: Megha Ajmera; +Cc: dev, jasvinder.singh, cristian.dumitrescu
On Fri, 21 Feb 2025 18:17:55 +0530
Megha Ajmera <megha.ajmera@intel.com> wrote:
> wrr tokens getting truncated to uint8_t in wrr_store function() due to
> type mismatch. This patch chnages the data type to uint16_t.
>
> Fixes: e16b06da0908 ("sched: remove WRR from strict priority TC queues")
>
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> ---
> lib/sched/rte_sched.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
> index d8ee4e7e91..dcef44b91b 100644
> --- a/lib/sched/rte_sched.c
> +++ b/lib/sched/rte_sched.c
> @@ -66,7 +66,7 @@ struct __rte_cache_aligned rte_sched_pipe {
> uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE];
>
> /* Weighted Round Robin (WRR) */
> - uint8_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
> + uint16_t wrr_tokens[RTE_SCHED_BE_QUEUES_PER_PIPE];
>
> /* TC oversubscription */
> uint64_t tc_ov_credits;
This would be a change in ABI.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-21 19:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-21 12:47 [PATCH] sched: fix wrr parameter data type Megha Ajmera
2025-02-21 13:02 ` Singh, Jasvinder
2025-02-21 19:14 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).