From: Ophir Munk <ophirmu@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>,
<jiaweiw@nvidia.com>
Subject: [PATCH V1 3/4] net/mlx5: remove unneeded FDB flag on representor action
Date: Tue, 25 Feb 2025 14:02:12 +0200 [thread overview]
Message-ID: <20250225120213.2968616-3-ophirmu@nvidia.com> (raw)
In-Reply-To: <20250225120213.2968616-1-ophirmu@nvidia.com>
From: Bing Zhao <bingz@nvidia.com>
The "send_to_kernel" action is shared and created during the HWS
configuration stage. By default, the NIC Rx and Tx flags are needed.
There is only one case that the FDB* flags are needed when creating
the action, the same as other shared actions. Only the transfer proxy
port needs the FDB* flags for shared actions.
Removing the unneeded FDB flags will help to save the resources of
memory and STCs.
Fixes: 07836ba156cb ("net/mlx5: fix device checking for send to kernel action")
Cc: jiaweiw@nvidia.com
Signed-off-by: Bing Zhao <bingz@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_hw.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c
index 4e015bf..6ddf1e5 100644
--- a/drivers/net/mlx5/mlx5_flow_hw.c
+++ b/drivers/net/mlx5/mlx5_flow_hw.c
@@ -9636,21 +9636,18 @@ _create_send_to_kernel_actions(struct mlx5_priv *priv, int type)
}
static void
-flow_hw_create_send_to_kernel_actions(struct mlx5_priv *priv)
+flow_hw_create_send_to_kernel_actions(struct mlx5_priv *priv, bool is_proxy)
{
#ifdef HAVE_MLX5DV_DR_ACTION_CREATE_DEST_ROOT_TABLE
int i, from, to;
- bool is_vf_sf_dev = priv->sh->dev_cap.vf || priv->sh->dev_cap.sf;
bool unified_fdb = is_unified_fdb(priv);
for (i = MLX5DR_TABLE_TYPE_NIC_RX; i <= MLX5DR_TABLE_TYPE_NIC_TX; i++)
_create_send_to_kernel_actions(priv, i);
- if (priv->sh->config.dv_esw_en && !is_vf_sf_dev) {
- from = unified_fdb ? MLX5DR_TABLE_TYPE_FDB_RX :
- MLX5DR_TABLE_TYPE_FDB;
- to = unified_fdb ? MLX5DR_TABLE_TYPE_FDB_UNIFIED :
- MLX5DR_TABLE_TYPE_FDB;
+ if (is_proxy) {
+ from = unified_fdb ? MLX5DR_TABLE_TYPE_FDB_RX : MLX5DR_TABLE_TYPE_FDB;
+ to = unified_fdb ? MLX5DR_TABLE_TYPE_FDB_UNIFIED : MLX5DR_TABLE_TYPE_FDB;
for (i = from; i <= to; i++)
_create_send_to_kernel_actions(priv, i);
}
@@ -9661,6 +9658,7 @@ static void
flow_hw_destroy_send_to_kernel_action(struct mlx5_priv *priv)
{
int i;
+
for (i = MLX5DR_TABLE_TYPE_NIC_RX; i < MLX5DR_TABLE_TYPE_MAX; i++) {
if (priv->hw_send_to_kernel[i]) {
mlx5dr_action_destroy(priv->hw_send_to_kernel[i]);
@@ -12158,7 +12156,7 @@ __flow_hw_configure(struct rte_eth_dev *dev,
}
}
if (!priv->shared_host)
- flow_hw_create_send_to_kernel_actions(priv);
+ flow_hw_create_send_to_kernel_actions(priv, is_proxy);
if (port_attr->nb_conn_tracks || (host_priv && host_priv->hws_ctpool)) {
if (mlx5_flow_ct_init(dev, port_attr->nb_conn_tracks, nb_q_updated))
goto err;
--
2.8.4
next prev parent reply other threads:[~2025-02-25 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 12:02 [PATCH V1 1/4] common/mlx5: support FDB unified capability query Ophir Munk
2025-02-25 12:02 ` [PATCH V1 2/4] net/mlx5: support FDB unified domain Ophir Munk
2025-02-25 12:11 ` Dariusz Sosnowski
2025-02-25 12:21 ` Dariusz Sosnowski
2025-02-25 12:02 ` Ophir Munk [this message]
2025-02-25 12:11 ` [PATCH V1 3/4] net/mlx5: remove unneeded FDB flag on representor action Dariusz Sosnowski
2025-02-25 12:02 ` [PATCH V1 4/4] net/mlx5/hws: allow different types in miss validation Ophir Munk
2025-02-25 12:11 ` Dariusz Sosnowski
2025-02-25 12:10 ` [PATCH V1 1/4] common/mlx5: support FDB unified capability query Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225120213.2968616-3-ophirmu@nvidia.com \
--to=ophirmu@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).