From: Ophir Munk <ophirmu@nvidia.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: [PATCH V1 4/4] net/mlx5/hws: allow different types in miss validation
Date: Tue, 25 Feb 2025 14:02:13 +0200 [thread overview]
Message-ID: <20250225120213.2968616-4-ophirmu@nvidia.com> (raw)
In-Reply-To: <20250225120213.2968616-1-ophirmu@nvidia.com>
In validating Jump from group A to default miss group B DPDK requests
that both groups types will be identical. In practice jumping from
FDB_UNIFIED to FDB_RX or FDB_TX group types (or vice versa) is allowed.
This commit enables this jumping between the different types.
Fixes: b81f95ca770d ("net/mlx5/hws: support default miss table")
Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_table.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c
index b371f42..c1c60b4 100644
--- a/drivers/net/mlx5/hws/mlx5dr_table.c
+++ b/drivers/net/mlx5/hws/mlx5dr_table.c
@@ -626,6 +626,19 @@ int mlx5dr_table_connect_to_miss_table(struct mlx5dr_table *src_tbl,
return 0;
}
+static bool mlx5dr_table_set_default_miss_valid_types(enum mlx5dr_table_type from,
+ enum mlx5dr_table_type to)
+{
+ if (from == to ||
+ ((from == MLX5DR_TABLE_TYPE_FDB_UNIFIED &&
+ (to == MLX5DR_TABLE_TYPE_FDB_RX || to == MLX5DR_TABLE_TYPE_FDB_TX)) ||
+ (to == MLX5DR_TABLE_TYPE_FDB_UNIFIED &&
+ (from == MLX5DR_TABLE_TYPE_FDB_RX || from == MLX5DR_TABLE_TYPE_FDB_TX))))
+ return true;
+
+ return false;
+}
+
static int mlx5dr_table_set_default_miss_not_valid(struct mlx5dr_table *tbl,
struct mlx5dr_table *miss_tbl)
{
@@ -637,8 +650,9 @@ static int mlx5dr_table_set_default_miss_not_valid(struct mlx5dr_table *tbl,
}
if (mlx5dr_table_is_root(tbl) ||
- (miss_tbl && mlx5dr_table_is_root(miss_tbl)) ||
- (miss_tbl && miss_tbl->type != tbl->type)) {
+ (miss_tbl &&
+ ((mlx5dr_table_is_root(miss_tbl)) ||
+ !mlx5dr_table_set_default_miss_valid_types(tbl->type, miss_tbl->type)))) {
DR_LOG(ERR, "Invalid arguments");
rte_errno = EINVAL;
return -rte_errno;
--
2.8.4
next prev parent reply other threads:[~2025-02-25 12:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 12:02 [PATCH V1 1/4] common/mlx5: support FDB unified capability query Ophir Munk
2025-02-25 12:02 ` [PATCH V1 2/4] net/mlx5: support FDB unified domain Ophir Munk
2025-02-25 12:11 ` Dariusz Sosnowski
2025-02-25 12:21 ` Dariusz Sosnowski
2025-02-25 12:02 ` [PATCH V1 3/4] net/mlx5: remove unneeded FDB flag on representor action Ophir Munk
2025-02-25 12:11 ` Dariusz Sosnowski
2025-02-25 12:02 ` Ophir Munk [this message]
2025-02-25 12:11 ` [PATCH V1 4/4] net/mlx5/hws: allow different types in miss validation Dariusz Sosnowski
2025-02-25 12:10 ` [PATCH V1 1/4] common/mlx5: support FDB unified capability query Dariusz Sosnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225120213.2968616-4-ophirmu@nvidia.com \
--to=ophirmu@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).