Re: [PATCH 4/6] drivers/net: make compatible with instruction set updates for MSVC

[Andre Muezerie <andremue@linux.microsoft.com>]

On Tue, Feb 25, 2025 at 09:06:26AM +0000, Bruce Richardson wrote:
> On Mon, Feb 24, 2025 at 01:01:17PM -0800, Andre Muezerie wrote:
> > Top level 'cc_avx2_flags' was created and holds the correct flags
> > depending on the compiler used.
> > 
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> > ---
> >  drivers/net/bnxt/meson.build       | 2 +-
> >  drivers/net/enic/meson.build       | 2 +-
> >  drivers/net/intel/i40e/meson.build | 2 +-
> >  drivers/net/intel/iavf/meson.build | 2 +-
> >  drivers/net/intel/ice/meson.build  | 2 +-
> >  drivers/net/intel/idpf/meson.build | 2 +-
> >  drivers/net/nfp/meson.build        | 2 +-
> >  drivers/net/octeon_ep/meson.build  | 4 ++--
> >  8 files changed, 9 insertions(+), 9 deletions(-)
> > 
> > diff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build
> > index e26cf13a65..fd82d0c409 100644
> > --- a/drivers/net/bnxt/meson.build
> > +++ b/drivers/net/bnxt/meson.build
> > @@ -65,7 +65,7 @@ if arch_subdir == 'x86'
> >                  static_rte_bus_pci,
> >                  static_rte_kvargs, static_rte_hash],
> >              include_directories: includes,
> > -            c_args: [cflags, '-mavx2'])
> > +            c_args: [cflags, cc_avx2_flags])
> >       objs += bnxt_avx2_lib.extract_objects('bnxt_rxtx_vec_avx2.c')
> 
> I like this change, and the consistency of the variable with the equivalent
> avx512 one. To simplify getting this patchset in - or as much of it as
> possible - can you perhaps add the cc_avx2_flags variable earlier in the
> patchset and make these library changes to use it, ahead of the complicated
> changes in patch 3. I think it may be simplier to have everything but patch
> ready since they should be easy to review and merge, and then we can look
> at patch 3 standalone. WDYT?
> 
> /Bruce

I had added all these changes in the same patchset because they are related,
but if splitting them makes the review process easier I’m all for it.
I’ll replace this series with 2 new patchsets.