DPDK patches and discussions
 help / color / mirror / Atom feed
* [RFC] doc: Document frequency and volume limits on patches.
@ 2025-03-05  1:33 Aaron Conole
  0 siblings, 0 replies; only message in thread
From: Aaron Conole @ 2025-03-05  1:33 UTC (permalink / raw)
  To: dev
  Cc: techboard, Aaron Conole, Abhinandan Gujjar, Ajit Khaparde,
	Akhil Goyal, Alok Prasad, Aman Singh, Amit Bernstein,
	Amit Prakash Shukla, Anatoly Burakov, Andrew Boyer,
	Andrew Rybchenko, Ankur Dwivedi, Anoob Joseph, Apeksha Gupta,
	Artem V . Andreev, Ashish Gupta, Ashwin Sekhar T K, Bing Zhao,
	Brian Dooley, Bruce Richardson, Byron Marohn, Chaoyong He,
	Chas Williams, Chenbo Xia, Cheng Jiang, Chengwen Feng,
	Christian Ehrhardt, Christian Koue Muf, Chunhao Lin,
	Ciara Loftus, Conor Walsh, Cristian Dumitrescu,
	Dariusz Sosnowski, David Christensen, David Hunt, David Marchand,
	Devendra Singh Rawat, Dmitry Kozlyuk, Dongwei Xu, Ed Czeck,
	Elena Agostini, Erik Gabriel Carrillo, Evgeny Schemeilin,
	Fan Zhang, Ferruh Yigit, Gaetan Rivet, Gagandeep Singh,
	Gowrishankar Muthukrishnan, Hanxiao Li, Harman Kalra,
	Harry van Haaren, Hemant Agrawal, Honnappa Nagarahalli,
	Howard Wang, Hyong Youb Kim, Ian Stokes, Igor Russkikh,
	Jack Bond-Preston, Jakub Grajciar, Jakub Palider,
	Jasvinder Singh, Jay Zhou, Jerin Jacob, Jeroen de Borst,
	Jian Wang, Jiawen Wu, Jiayu Hu, Jie Hai, Jingjing Wu,
	Jochen Behrens, John Daley, John McNamara, John Miller,
	John W . Linville, Joshua Washington, Julien Aube, Junlong Wang,
	Kai Ji, Kevin Laatz, Kevin Traynor, Kiran Kumar K,
	Kirill Rybalchenko, Konstantin Ananyev, Lee Daly, Liang Ma,
	Lijie Shan, Liron Himi, Long Li, Luca Boccassi, Maciej Czekaj,
	maintainers

The DPDK project has two constrained resources - reviewers and
public CI infrastructure.  These are shared among the entire
project, and there are true costs associated with using these
resources.  Thus, there are two motivations behind this change:
  - Encourage developers to spend more time ensuring their
    changes are in a state that things have gone through some
    basic testing
  - Encourage people to give reviews by guaranteeing that the
    time between series is long enough that comments will be
    valid.

We want to document the guidelines for submitting to the list
to encourage more time for reviews, and also encourage
developers to spend a bit more time to put their submissions
in a 'default accept' condition.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
NOTE: This is a discussion item from the techboard and I'm
      submitting as RFC first to gather feedback.  I've CC'd
      each maintainer individually as well to try and make sure
      it gets into the inboxes.

 doc/guides/contributing/patches.rst | 31 +++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index d21ee288b2..a13f79c7a8 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -644,6 +644,37 @@ environment) by the person named.
 person.
 
 
+Frequency and volume of patches
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Please allow at least 24 hours to pass between posting patch revisions.
+This ensures reviewers from different geographical regions have time to
+provide feedback.
+Additionally, please do not wait too long (read: weeks) between revisions
+as this makes it harder for reviewers and maintainers to recall the context
+of the previous posting.
+
+Please do not post new revisions without addressing all feedback.
+Make sure that all outstanding items have been addressed before posting a new
+revision for review.
+Do not post a new version of a patch while there is ongoing discussion unless
+a reviewer has specifically requested it.
+
+Do not post your patches to the list in lieu of running tests.
+**YOU MUST ENSURE** that your patches are ready by testing them locally before
+posting to the mailing list.
+The infrastructure running the tests is a shared resource among all developers
+on the project, and many frequent reposts will result in delays for all
+developers.
+We do our best to include CI and self-test infrastructure that can be used on
+an individual developer basis.
+
+Your changes are expected to pass on an x86/x86-64 linux system.
+
+Keep all patch sets to a reasonable length.
+Too many or too large patches and series can quickly become very difficult
+for a reasonable review.
+
 
 Steps to getting your patch merged
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- 
2.47.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-03-05  1:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-05  1:33 [RFC] doc: Document frequency and volume limits on patches Aaron Conole

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).