* [PATCH] devtools: fix regex of cnxk skip files
@ 2025-03-06 15:25 pbhagavatula
2025-03-06 16:13 ` Thomas Monjalon
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: pbhagavatula @ 2025-03-06 15:25 UTC (permalink / raw)
To: jerinj, Thomas Monjalon; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
SKIP_FILES should include the path of the file.
Update the regex to match the path.
Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
devtools/checkpatches.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 003bb49e04..63638bc7fa 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -236,7 +236,7 @@ check_forbidden_additions() { # <patch>
# forbid rte_ symbols in cnxk base driver
awk -v FOLDERS='drivers/common/cnxk/roc_*' \
- -v SKIP_FILES='roc_platform*' \
+ -v SKIP_FILES='.*roc_platform*' \
-v EXPRESSIONS="rte_ RTE_" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver' \
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] devtools: fix regex of cnxk skip files
2025-03-06 15:25 [PATCH] devtools: fix regex of cnxk skip files pbhagavatula
@ 2025-03-06 16:13 ` Thomas Monjalon
2025-03-06 16:22 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-03-06 16:15 ` Thomas Monjalon
2025-03-06 17:12 ` [PATCH v2] devtools: fix regex of " pbhagavatula
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2025-03-06 16:13 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: jerinj, dev
06/03/2025 16:25, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> SKIP_FILES should include the path of the file.
> Update the regex to match the path.
>
> Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> - -v SKIP_FILES='roc_platform*' \
> + -v SKIP_FILES='.*roc_platform*' \
I don't think it is what you want.
The last part should be .*
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files
2025-03-06 16:13 ` Thomas Monjalon
@ 2025-03-06 16:22 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 6+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2025-03-06 16:22 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Jerin Jacob, dev
> 06/03/2025 16:25, pbhagavatula@marvell.com:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
> >
> > Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > - -v SKIP_FILES='roc_platform*' \
> > + -v SKIP_FILES='.*roc_platform*' \
>
> I don't think it is what you want.
> The last part should be .*
>
I tested with 0001-common-cnxk-support-for-inline-inbound-queue.patch
with SKIP_FILES='roc_platform.*' and It doesn’t work.
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 63638bc7fa35..64f7b316ea0a 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -236,7 +236,7 @@ check_forbidden_additions() { # <patch>
# forbid rte_ symbols in cnxk base driver
awk -v FOLDERS='drivers/common/cnxk/roc_*' \
- -v SKIP_FILES='.*roc_platform*' \
+ -v SKIP_FILES='roc_platform.*' \
-v EXPRESSIONS="rte_ RTE_" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver' \
(python-venv) lab_pvn@lab-pvn dpdk.org main ± ./devtools/checkpatches.sh 0001-common-cnxk-support-for-inline-inbound-queue.patch
### [PATCH] common/cnxk: support for inline inbound queue
total: 0 errors, 0 warnings, 1 checks, 1173 lines checked
Warning in drivers/common/cnxk/roc_platform.h:
Use plt_ symbols instead of rte_ API in cnxk base driver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] devtools: fix regex of cnxk skip files
2025-03-06 15:25 [PATCH] devtools: fix regex of cnxk skip files pbhagavatula
2025-03-06 16:13 ` Thomas Monjalon
@ 2025-03-06 16:15 ` Thomas Monjalon
2025-03-06 16:23 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-03-06 17:12 ` [PATCH v2] devtools: fix regex of " pbhagavatula
2 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2025-03-06 16:15 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: jerinj, dev
06/03/2025 16:25, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> SKIP_FILES should include the path of the file.
> Update the regex to match the path.
Can you please also check this one:
-v SKIP_FILES='osdep.h$'
Is it really working without the full path?
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] devtools: fix regex of cnxk skip files
2025-03-06 16:15 ` Thomas Monjalon
@ 2025-03-06 16:23 ` Pavan Nikhilesh Bhagavatula
0 siblings, 0 replies; 6+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2025-03-06 16:23 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Jerin Jacob, dev
> 06/03/2025 16:25, pbhagavatula@marvell.com:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > SKIP_FILES should include the path of the file.
> > Update the regex to match the path.
>
> Can you please also check this one:
> -v SKIP_FILES='osdep.h$'
> Is it really working without the full path?
>
Sure, let me check.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] devtools: fix regex of skip files
2025-03-06 15:25 [PATCH] devtools: fix regex of cnxk skip files pbhagavatula
2025-03-06 16:13 ` Thomas Monjalon
2025-03-06 16:15 ` Thomas Monjalon
@ 2025-03-06 17:12 ` pbhagavatula
2 siblings, 0 replies; 6+ messages in thread
From: pbhagavatula @ 2025-03-06 17:12 UTC (permalink / raw)
To: jerinj, Thomas Monjalon; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
SKIP_FILES should include the path of the file along with the name.
Update the regex to match the entire path.
Fixes: dd88f51a5725 ("devtools: forbid DPDK API in cnxk base driver")
Fixes: 2b843cac232e ("drivers: use per line logging in helpers")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
v2 Changes:
- add fix for osdep.h. (Thomas)
- Use the correct regex pattern for matching file name at the end. (Thomas)
devtools/checkpatches.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 003bb49e04..c9088bb403 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -63,7 +63,7 @@ check_forbidden_additions() { # <patch>
# refrain from new calls to RTE_LOG in drivers (but leave some leeway for base drivers)
awk -v FOLDERS="drivers" \
- -v SKIP_FILES='osdep.h$' \
+ -v SKIP_FILES='.*osdep.h$' \
-v EXPRESSIONS="RTE_LOG\\\( RTE_LOG_DP\\\( rte_log\\\(" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE' \
@@ -236,7 +236,7 @@ check_forbidden_additions() { # <patch>
# forbid rte_ symbols in cnxk base driver
awk -v FOLDERS='drivers/common/cnxk/roc_*' \
- -v SKIP_FILES='roc_platform*' \
+ -v SKIP_FILES='.*roc_platform.*' \
-v EXPRESSIONS="rte_ RTE_" \
-v RET_ON_FAIL=1 \
-v MESSAGE='Use plt_ symbols instead of rte_ API in cnxk base driver' \
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-06 17:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-06 15:25 [PATCH] devtools: fix regex of cnxk skip files pbhagavatula
2025-03-06 16:13 ` Thomas Monjalon
2025-03-06 16:22 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-03-06 16:15 ` Thomas Monjalon
2025-03-06 16:23 ` [EXTERNAL] " Pavan Nikhilesh Bhagavatula
2025-03-06 17:12 ` [PATCH v2] devtools: fix regex of " pbhagavatula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).