From: <pbhagavatula@marvell.com>
To: <jerinj@marvell.com>,
Wathsala Vithanage <wathsala.vithanage@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [PATCH] config/arm: fix march features not being set
Date: Sat, 8 Mar 2025 14:29:02 +0530 [thread overview]
Message-ID: <20250308085902.4383-1-pbhagavatula@marvell.com> (raw)
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix extra_march_features not being added to
mcpu flags when SoC configuration advertises
them.
Fixes: c02c01dbf907 ("config/arm: prefer strict use of -mcpu if supported")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
config/arm/meson.build | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index dea329ceb7..7f85b088c9 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -841,6 +841,7 @@ if update_flags
implementer_config = implementers[implementer_id]
part_number = soc_config['part_number']
soc_flags = soc_config.get('flags', [])
+ extra_features = soc_config.get('extra_march_features', [])
if not soc_config.get('numa', true)
has_libnuma = false
endif
@@ -909,11 +910,15 @@ if update_flags
machine_args += march
else
candidate_mcpu = '-mcpu=' + mcpu
- if (cc.has_argument(candidate_mcpu))
- machine_args += candidate_mcpu
- else
+ if not cc.has_argument(candidate_mcpu)
error('Compiler does not support -mcpu=@0@.'.format(mcpu))
endif
+ foreach flag: extra_features
+ if cc.has_argument('+'.join([candidate_mcpu, flag]))
+ candidate_mcpu = '+'.join([candidate_mcpu, flag])
+ endif
+ endforeach
+ machine_args += candidate_mcpu
endif
# apply supported compiler options
--
2.43.0
reply other threads:[~2025-03-08 8:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308085902.4383-1-pbhagavatula@marvell.com \
--to=pbhagavatula@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).