DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, bruce.richardson@intel.com,
	andremue@linux.microsoft.com, Jerin Jacob <jerinj@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Zhirun Yan <yanzhirun_163@163.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Anoob Joseph <anoobj@marvell.com>,
	Volodymyr Fialko <vfialko@marvell.com>,
	Ori Kam <orika@nvidia.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbox@nvidia.com>
Subject: [RFC v3 1/8] lib: remove incorrect exported symbols
Date: Tue, 11 Mar 2025 10:55:59 +0100	[thread overview]
Message-ID: <20250311095609.194523-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20250311095609.194523-1-david.marchand@redhat.com>

Declaring inline helpers in version.map is unnecessary.
There is no exported symbol and this will probably be treated as an
error by MSVC linker.

eal_log_journal has no implementation and can be removed.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/eventdev/version.map | 12 ------------
 lib/graph/version.map    | 17 -----------------
 lib/ipsec/version.map    |  4 ----
 lib/log/log_internal.h   |  3 ---
 lib/log/version.map      |  1 -
 lib/pdcp/version.map     |  4 ----
 lib/regexdev/version.map |  2 --
 lib/vhost/version.map    |  1 -
 8 files changed, 44 deletions(-)

diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index 44687255cb..bff08d6a62 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -102,9 +102,6 @@ DPDK_25 {
 	rte_event_timer_adapter_stats_get;
 	rte_event_timer_adapter_stats_reset;
 	rte_event_timer_adapter_stop;
-	rte_event_timer_arm_burst;
-	rte_event_timer_arm_tmo_tick_burst;
-	rte_event_timer_cancel_burst;
 	rte_event_vector_pool_create;
 
 	local: *;
@@ -149,9 +146,7 @@ EXPERIMENTAL {
 	__rte_eventdev_trace_port_profile_switch;
 
 	# added in 24.11
-	rte_event_port_preschedule_modify;
 	__rte_eventdev_trace_port_preschedule_modify;
-	rte_event_port_preschedule;
 	__rte_eventdev_trace_port_preschedule;
 
 	# added in 25.03
@@ -166,14 +161,7 @@ INTERNAL {
 	event_dev_probing_finish;
 	rte_event_logtype;
 	rte_event_pmd_allocate;
-	rte_event_pmd_get_named_dev;
-	rte_event_pmd_is_valid_dev;
-	rte_event_pmd_pci_probe;
-	rte_event_pmd_pci_probe_named;
-	rte_event_pmd_pci_remove;
 	rte_event_pmd_release;
 	rte_event_pmd_selftest_seqn_dynfield_offset;
-	rte_event_pmd_vdev_init;
-	rte_event_pmd_vdev_uninit;
 	rte_eventdevs;
 };
diff --git a/lib/graph/version.map b/lib/graph/version.map
index 44fadc00fd..d03d44434d 100644
--- a/lib/graph/version.map
+++ b/lib/graph/version.map
@@ -27,9 +27,7 @@ DPDK_25 {
 	rte_graph_node_get;
 	rte_graph_node_get_by_name;
 	rte_graph_obj_dump;
-	rte_graph_walk;
 	rte_graph_worker_model_get;
-	rte_graph_worker_model_no_check_get;
 	rte_graph_worker_model_set;
 	rte_node_clone;
 	rte_node_dump;
@@ -37,25 +35,10 @@ DPDK_25 {
 	rte_node_edge_get;
 	rte_node_edge_shrink;
 	rte_node_edge_update;
-	rte_node_enqueue;
-	rte_node_enqueue_next;
-	rte_node_enqueue_x1;
-	rte_node_enqueue_x2;
-	rte_node_enqueue_x4;
 	rte_node_from_name;
 	rte_node_id_to_name;
 	rte_node_list_dump;
 	rte_node_max_count;
-	rte_node_next_stream_get;
-	rte_node_next_stream_move;
-	rte_node_next_stream_put;
 
 	local: *;
 };
-
-EXPERIMENTAL {
-	global:
-
-	# added in 24.11
-	rte_node_xstat_increment;
-};
diff --git a/lib/ipsec/version.map b/lib/ipsec/version.map
index 308f9d2e0d..47e3df5bb6 100644
--- a/lib/ipsec/version.map
+++ b/lib/ipsec/version.map
@@ -1,9 +1,6 @@
 DPDK_25 {
 	global:
 
-	rte_ipsec_pkt_crypto_group;
-	rte_ipsec_pkt_crypto_prepare;
-	rte_ipsec_pkt_process;
 	rte_ipsec_sa_fini;
 	rte_ipsec_sa_init;
 	rte_ipsec_sa_size;
@@ -14,7 +11,6 @@ DPDK_25 {
 	rte_ipsec_sad_destroy;
 	rte_ipsec_sad_find_existing;
 	rte_ipsec_sad_lookup;
-	rte_ipsec_ses_from_crypto;
 	rte_ipsec_session_prepare;
 	rte_ipsec_telemetry_sa_add;
 	rte_ipsec_telemetry_sa_del;
diff --git a/lib/log/log_internal.h b/lib/log/log_internal.h
index bba7041ea3..525e1397fd 100644
--- a/lib/log/log_internal.h
+++ b/lib/log/log_internal.h
@@ -29,9 +29,6 @@ int eal_log_save_pattern(const char *pattern, uint32_t level);
 __rte_internal
 int eal_log_syslog(const char *name);
 
-__rte_internal
-int eal_log_journal(const char *opt);
-
 /*
  * Convert log level to string.
  */
diff --git a/lib/log/version.map b/lib/log/version.map
index 09d8a4289b..603be493b3 100644
--- a/lib/log/version.map
+++ b/lib/log/version.map
@@ -27,7 +27,6 @@ INTERNAL {
 
 	eal_log_color;
 	eal_log_init;
-	eal_log_journal; # WINDOWS_NO_EXPORT
 	eal_log_level2str;
 	eal_log_save_pattern;
 	eal_log_save_regexp;
diff --git a/lib/pdcp/version.map b/lib/pdcp/version.map
index 9c02303c45..72b2d4729b 100644
--- a/lib/pdcp/version.map
+++ b/lib/pdcp/version.map
@@ -3,13 +3,9 @@ EXPERIMENTAL {
 
 	# added in 23.07
 	rte_pdcp_control_pdu_create;
-	rte_pdcp_en_from_cop;
 	rte_pdcp_entity_establish;
 	rte_pdcp_entity_release;
 	rte_pdcp_entity_suspend;
-	rte_pdcp_pkt_post_process;
-	rte_pdcp_pkt_pre_process;
-	rte_pdcp_pkt_crypto_group;
 	rte_pdcp_t_reordering_expiry_handle;
 
 	local: *;
diff --git a/lib/regexdev/version.map b/lib/regexdev/version.map
index 4c0435180c..713a800ca4 100644
--- a/lib/regexdev/version.map
+++ b/lib/regexdev/version.map
@@ -7,9 +7,7 @@ EXPERIMENTAL {
 	rte_regexdev_close;
 	rte_regexdev_configure;
 	rte_regexdev_count;
-	rte_regexdev_dequeue_burst;
 	rte_regexdev_dump;
-	rte_regexdev_enqueue_burst;
 	rte_regexdev_get_dev_id;
 	rte_regexdev_info_get;
 	rte_regexdev_queue_pair_setup;
diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 8333e100ed..c044bb714e 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -61,7 +61,6 @@ DPDK_25 {
 	rte_vhost_set_last_inflight_io_packed;
 	rte_vhost_set_last_inflight_io_split;
 	rte_vhost_set_vring_base;
-	rte_vhost_va_from_guest_pa;
 	rte_vhost_vring_call;
 	rte_vhost_vring_call_nonblock;
 	rte_vhost_vring_stats_get;
-- 
2.48.1


  reply	other threads:[~2025-03-11  9:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 21:23 [RFC] eal: add new function versioning macros David Marchand
2025-03-06  2:57 ` Patrick Robb
2025-03-06 10:23 ` Bruce Richardson
2025-03-06 12:50 ` [RFC v2 1/2] " David Marchand
2025-03-06 12:50   ` [RFC v2 2/2] build: generate symbol maps David Marchand
2025-03-06 15:45   ` [RFC v2 1/2] eal: add new function versioning macros Andre Muezerie
2025-03-11  9:55 ` [RFC v3 0/8] Symbol versioning and export rework David Marchand
2025-03-11  9:55   ` David Marchand [this message]
2025-03-11  9:56   ` [RFC v3 2/8] drivers: remove incorrect exported symbols David Marchand
2025-03-11  9:56   ` [RFC v3 3/8] eal: rework function versioning macros David Marchand
2025-03-11  9:56   ` [RFC v3 4/8] buildtools: display version when listing symbols David Marchand
2025-03-11  9:56   ` [RFC v3 5/8] build: generate symbol maps David Marchand
2025-03-11  9:56   ` [RFC v3 6/8] build: mark exported symbols David Marchand
2025-03-11  9:56   ` [RFC v3 7/8] build: use dynamically generated version maps David Marchand
2025-03-11  9:56   ` [RFC v3 8/8] build: remove static " David Marchand
2025-03-11 10:18   ` [RFC v3 0/8] Symbol versioning and export rework Morten Brørup
2025-03-11 13:43     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250311095609.194523-2-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=andremue@linux.microsoft.com \
    --cc=anoobj@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=maxime.coquelin@redhat.com \
    --cc=ndabilpuram@marvell.com \
    --cc=orika@nvidia.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=vfialko@marvell.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yanzhirun_163@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).