* [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers
2025-03-11 15:51 [PATCH 0/4] more unnecessary function pointer Stephen Hemminger
@ 2025-03-11 15:51 ` Stephen Hemminger
2025-03-11 16:03 ` Bruce Richardson
2025-03-11 15:51 ` [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer Stephen Hemminger
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2025-03-11 15:51 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Rosen Xu
The expression *dev->ops->start and dev->ops->start are equivalent.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/raw/ifpga/afu_pmd_core.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/raw/ifpga/afu_pmd_core.c b/drivers/raw/ifpga/afu_pmd_core.c
index 3ab1f47ac1..f650b76cfe 100644
--- a/drivers/raw/ifpga/afu_pmd_core.c
+++ b/drivers/raw/ifpga/afu_pmd_core.c
@@ -39,7 +39,7 @@ static int afu_rawdev_configure(const struct rte_rawdev *rawdev,
return -ENODEV;
if (dev->ops && dev->ops->config)
- ret = (*dev->ops->config)(dev, config, config_size);
+ ret = dev->ops->config(dev, config, config_size);
return ret;
}
@@ -62,7 +62,7 @@ static int afu_rawdev_start(struct rte_rawdev *rawdev)
}
if (dev->ops && dev->ops->start)
- ret = (*dev->ops->start)(dev);
+ ret = dev->ops->start(dev);
afu_rawdev_unlock(dev);
@@ -87,7 +87,7 @@ static void afu_rawdev_stop(struct rte_rawdev *rawdev)
}
if (dev->ops && dev->ops->stop)
- ret = (*dev->ops->stop)(dev);
+ ret = dev->ops->stop(dev);
afu_rawdev_unlock(dev);
}
@@ -104,7 +104,7 @@ static int afu_rawdev_close(struct rte_rawdev *rawdev)
return -ENODEV;
if (dev->ops && dev->ops->close)
- ret = (*dev->ops->close)(dev);
+ ret = dev->ops->close(dev);
return ret;
}
@@ -127,7 +127,7 @@ static int afu_rawdev_reset(struct rte_rawdev *rawdev)
}
if (dev->ops && dev->ops->reset)
- ret = (*dev->ops->reset)(dev);
+ ret = dev->ops->reset(dev);
afu_rawdev_unlock(dev);
@@ -155,7 +155,7 @@ static int afu_rawdev_selftest(uint16_t dev_id)
}
if (dev->ops && dev->ops->test)
- ret = (*dev->ops->test)(dev);
+ ret = dev->ops->test(dev);
afu_rawdev_unlock(dev);
@@ -174,7 +174,7 @@ static int afu_rawdev_dump(struct rte_rawdev *rawdev, FILE *f)
return -ENODEV;
if (dev->ops && dev->ops->dump)
- ret = (*dev->ops->dump)(dev, f);
+ ret = dev->ops->dump(dev, f);
return ret;
}
@@ -326,7 +326,7 @@ static int afu_rawdev_create(struct rte_afu_device *afu_dev, int socket_id)
}
if (dev->ops->init) {
- ret = (*dev->ops->init)(dev);
+ ret = dev->ops->init(dev);
if (ret) {
IFPGA_RAWDEV_PMD_ERR("Failed to init %s", name);
goto cleanup;
--
2.47.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer
2025-03-11 15:51 [PATCH 0/4] more unnecessary function pointer Stephen Hemminger
2025-03-11 15:51 ` [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers Stephen Hemminger
@ 2025-03-11 15:51 ` Stephen Hemminger
2025-03-11 15:51 ` [PATCH 3/4] regexdev: another unnecessary deref of function pointers Stephen Hemminger
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2025-03-11 15:51 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Andrew Boyer
The expression *dev->intf->setup_bars and dev->intf->setup_bars
are equivalent.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/crypto/ionic/ionic_crypto.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ionic/ionic_crypto.h b/drivers/crypto/ionic/ionic_crypto.h
index db87ea0490..5a03260486 100644
--- a/drivers/crypto/ionic/ionic_crypto.h
+++ b/drivers/crypto/ionic/ionic_crypto.h
@@ -269,7 +269,7 @@ iocpt_setup_bars(struct iocpt_dev *dev)
if (dev->intf->setup_bars == NULL)
return -EINVAL;
- return (*dev->intf->setup_bars)(dev);
+ return dev->intf->setup_bars(dev);
}
/** iocpt_admin_ctx - Admin command context.
--
2.47.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 3/4] regexdev: another unnecessary deref of function pointers
2025-03-11 15:51 [PATCH 0/4] more unnecessary function pointer Stephen Hemminger
2025-03-11 15:51 ` [PATCH 1/4] raw/ifpga: remove unnecessary deref of function pointers Stephen Hemminger
2025-03-11 15:51 ` [PATCH 2/4] crypto/ionic: remove unnecessary deref of function pointer Stephen Hemminger
@ 2025-03-11 15:51 ` Stephen Hemminger
2025-03-11 15:51 ` [PATCH 4/4] vhost: remove " Stephen Hemminger
2025-03-11 16:04 ` [PATCH 0/4] more unnecessary function pointer Bruce Richardson
4 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2025-03-11 15:51 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Ori Kam
The expression *dev->enqueue and dev->enqueue are equivalent.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/regexdev/rte_regexdev.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
index b18a1d4251..1534e9f84a 100644
--- a/lib/regexdev/rte_regexdev.h
+++ b/lib/regexdev/rte_regexdev.h
@@ -1473,14 +1473,14 @@ rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id,
struct rte_regexdev *dev = &rte_regex_devices[dev_id];
#ifdef RTE_LIBRTE_REGEXDEV_DEBUG
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
- if (*dev->enqueue == NULL)
+ if (dev->enqueue == NULL)
return -ENOTSUP;
if (qp_id >= dev->data->dev_conf.nb_queue_pairs) {
RTE_REGEXDEV_LOG_LINE(ERR, "Invalid queue %d", qp_id);
return -EINVAL;
}
#endif
- return (*dev->enqueue)(dev, qp_id, ops, nb_ops);
+ return dev->enqueue(dev, qp_id, ops, nb_ops);
}
/**
@@ -1533,14 +1533,14 @@ rte_regexdev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,
struct rte_regexdev *dev = &rte_regex_devices[dev_id];
#ifdef RTE_LIBRTE_REGEXDEV_DEBUG
RTE_REGEXDEV_VALID_DEV_ID_OR_ERR_RET(dev_id, -EINVAL);
- if (*dev->dequeue == NULL)
+ if (dev->dequeue == NULL)
return -ENOTSUP;
if (qp_id >= dev->data->dev_conf.nb_queue_pairs) {
RTE_REGEXDEV_LOG_LINE(ERR, "Invalid queue %d", qp_id);
return -EINVAL;
}
#endif
- return (*dev->dequeue)(dev, qp_id, ops, nb_ops);
+ return dev->dequeue(dev, qp_id, ops, nb_ops);
}
#ifdef __cplusplus
--
2.47.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 4/4] vhost: remove unnecessary deref of function pointers
2025-03-11 15:51 [PATCH 0/4] more unnecessary function pointer Stephen Hemminger
` (2 preceding siblings ...)
2025-03-11 15:51 ` [PATCH 3/4] regexdev: another unnecessary deref of function pointers Stephen Hemminger
@ 2025-03-11 15:51 ` Stephen Hemminger
2025-03-11 16:04 ` [PATCH 0/4] more unnecessary function pointer Bruce Richardson
4 siblings, 0 replies; 7+ messages in thread
From: Stephen Hemminger @ 2025-03-11 15:51 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Maxime Coquelin, Chenbo Xia
Since it is a function pointer,
the expression *dev->extern_ops.pre_msg_handle and
dev->extern_ops.pre_msg_handle are the same.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/vhost/vhost_user.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 26dc0bde97..45f2b71e36 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -3186,7 +3186,7 @@ vhost_user_msg_handler(int vid, int fd)
handled = false;
if (dev->extern_ops.pre_msg_handle) {
RTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0);
- msg_result = (*dev->extern_ops.pre_msg_handle)(dev->vid, &ctx);
+ msg_result = dev->extern_ops.pre_msg_handle(dev->vid, &ctx);
switch (msg_result) {
case RTE_VHOST_MSG_RESULT_REPLY:
send_vhost_reply(dev, fd, &ctx);
@@ -3238,7 +3238,7 @@ vhost_user_msg_handler(int vid, int fd)
if (msg_result != RTE_VHOST_MSG_RESULT_ERR &&
dev->extern_ops.post_msg_handle) {
RTE_BUILD_BUG_ON(offsetof(struct vhu_msg_context, msg) != 0);
- msg_result = (*dev->extern_ops.post_msg_handle)(dev->vid, &ctx);
+ msg_result = dev->extern_ops.post_msg_handle(dev->vid, &ctx);
switch (msg_result) {
case RTE_VHOST_MSG_RESULT_REPLY:
send_vhost_reply(dev, fd, &ctx);
--
2.47.2
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 0/4] more unnecessary function pointer
2025-03-11 15:51 [PATCH 0/4] more unnecessary function pointer Stephen Hemminger
` (3 preceding siblings ...)
2025-03-11 15:51 ` [PATCH 4/4] vhost: remove " Stephen Hemminger
@ 2025-03-11 16:04 ` Bruce Richardson
4 siblings, 0 replies; 7+ messages in thread
From: Bruce Richardson @ 2025-03-11 16:04 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
On Tue, Mar 11, 2025 at 08:51:28AM -0700, Stephen Hemminger wrote:
> A few more cases where there is unnecessary deref (*) on
> function pointers.
>
> Stephen Hemminger (4):
> raw/ifpga: remove unnecessary deref of function pointers
> crypto/ionic: remove unnecessary deref of function pointer
> regexdev: another unnecessary deref of function pointers
> vhost: remove unnecessary deref of function pointers
>
> drivers/crypto/ionic/ionic_crypto.h | 2 +-
> drivers/raw/ifpga/afu_pmd_core.c | 16 ++++++++--------
> lib/regexdev/rte_regexdev.h | 8 ++++----
> lib/vhost/vhost_user.c | 4 ++--
> 4 files changed, 15 insertions(+), 15 deletions(-)
>
Series-Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread