From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD
Date: Wed, 12 Mar 2025 16:02:25 -0700 [thread overview]
Message-ID: <20250312160225.2d90e78a@hermes.local> (raw)
In-Reply-To: <12279496.nUPlyArG6x@thomas>
On Wed, 19 Feb 2025 15:55:17 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 14/02/2025 18:20, Stephen Hemminger:
> > The Linux version of sys/queue.h is frozen at an older version
> > and is missing the _SAFE macro variants. Several drivers started
> > introducing the own workarounds for this. Should be handled in EAL.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> We may want to unify with lib/eal/windows/include/sys/queue.h
>
>
Not sure, we have several options here:
1. Keep using Linux sys/queue.h and add enhancements in rte_queue.h
2. Make rte_queue.h a copy of FreeBSD version of queue.h (that is what Windows did)
3. Use the bsd version of queue.h.
On Debian/Ubuntu this in libbsd-dev package and referred to as bsd/sys/queue.h
I chose #1 as simplest. But all of these could work. #3 means DPDK has least new
code, but adds another dependency to the build.
No matter what, should add to checkpatch to block any new files that include sys/queue.h
directly.
next prev parent reply other threads:[~2025-03-12 23:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 18:03 [RFC 0/7] Introduce FreeBSD macros for SAFE iteration Stephen Hemminger
2025-01-27 18:03 ` [RFC 1/7] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-01-27 18:03 ` [RFC 2/7] net/qede: fix use after free Stephen Hemminger
2025-01-27 18:03 ` [RFC 3/7] bus/fslmc: " Stephen Hemminger
2025-01-27 18:03 ` [RFC 4/7] net/bnxt: " Stephen Hemminger
2025-01-27 19:25 ` Ajit Khaparde
2025-01-27 18:03 ` [RFC 5/7] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-27 18:04 ` [RFC 6/7] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-27 18:04 ` [RFC 7/7] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-31 9:03 ` Xu, Rosen
2025-01-27 18:16 ` [RFC 0/7] Introduce FreeBSD macros for SAFE iteration Bruce Richardson
2025-01-27 18:43 ` Stephen Hemminger
2025-01-27 19:29 ` Morten Brørup
2025-01-27 23:14 ` Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 0/7] Introduce FOREACH_SAFE macros Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-02-19 14:55 ` Thomas Monjalon
2025-02-21 23:05 ` Stephen Hemminger
2025-02-22 8:46 ` Thomas Monjalon
2025-03-12 23:02 ` Stephen Hemminger [this message]
2025-03-13 8:00 ` Morten Brørup
2025-02-14 17:20 ` [PATCH v2 2/7] net/qede: fix use after free Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 3/7] bus/fslmc: " Stephen Hemminger
2025-02-15 11:12 ` Hemant Agrawal
2025-02-14 17:20 ` [PATCH v2 4/7] net/bnxt: " Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 5/7] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 6/7] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 7/7] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-15 15:44 ` [PATCH v2 0/7] Introduce FOREACH_SAFE macros Morten Brørup
2025-03-12 23:15 ` [PATCH v3 0/9] introduce common " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 1/9] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 2/9] net/qede: fix use after free Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 3/9] bus/fslmc: " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 4/9] net/bnxt: " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 5/9] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 6/9] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 7/9] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 8/9] net/i40e: replace open coded version of LIST_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 9/9] net/ice: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312160225.2d90e78a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).