From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Rosen Xu <rosen.xu@intel.com>, Rosen Xu <rosen.xu@altera.com>
Subject: [PATCH v3 7/9] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE
Date: Wed, 12 Mar 2025 16:15:36 -0700 [thread overview]
Message-ID: <20250312231715.222149-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20250312231715.222149-1-stephen@networkplumber.org>
Prefer the EAL version over local version of macro.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Rosen Xu <rosen.xu@intel.com>
---
drivers/raw/ifpga/base/ifpga_enumerate.c | 4 +---
drivers/raw/ifpga/base/opae_osdep.h | 1 +
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/raw/ifpga/base/ifpga_enumerate.c b/drivers/raw/ifpga/base/ifpga_enumerate.c
index 61eb6601ea..085fb6db40 100644
--- a/drivers/raw/ifpga/base/ifpga_enumerate.c
+++ b/drivers/raw/ifpga/base/ifpga_enumerate.c
@@ -725,9 +725,7 @@ static void dfl_fpga_enum_info_free(struct dfl_fpga_enum_info *info)
return;
/* remove all device feature lists in the list. */
- for (dfl = TAILQ_FIRST(&info->dfls);
- dfl && (tmp = TAILQ_NEXT(dfl, node), 1);
- dfl = tmp) {
+ TAILQ_FOREACH_SAFE(dfl, &info->dfls, node, tmp) {
TAILQ_REMOVE(&info->dfls, dfl, node);
opae_free(dfl);
}
diff --git a/drivers/raw/ifpga/base/opae_osdep.h b/drivers/raw/ifpga/base/opae_osdep.h
index e35a21c80e..b483d00a54 100644
--- a/drivers/raw/ifpga/base/opae_osdep.h
+++ b/drivers/raw/ifpga/base/opae_osdep.h
@@ -11,6 +11,7 @@
#ifdef RTE_LIB_EAL
#include "osdep_rte/osdep_generic.h"
+#include <rte_queue.h>
#else
#include "osdep_raw/osdep_generic.h"
#endif
--
2.47.2
next prev parent reply other threads:[~2025-03-12 23:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 18:03 [RFC 0/7] Introduce FreeBSD macros for SAFE iteration Stephen Hemminger
2025-01-27 18:03 ` [RFC 1/7] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-01-27 18:03 ` [RFC 2/7] net/qede: fix use after free Stephen Hemminger
2025-01-27 18:03 ` [RFC 3/7] bus/fslmc: " Stephen Hemminger
2025-01-27 18:03 ` [RFC 4/7] net/bnxt: " Stephen Hemminger
2025-01-27 19:25 ` Ajit Khaparde
2025-01-27 18:03 ` [RFC 5/7] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-27 18:04 ` [RFC 6/7] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-27 18:04 ` [RFC 7/7] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-01-31 9:03 ` Xu, Rosen
2025-01-27 18:16 ` [RFC 0/7] Introduce FreeBSD macros for SAFE iteration Bruce Richardson
2025-01-27 18:43 ` Stephen Hemminger
2025-01-27 19:29 ` Morten Brørup
2025-01-27 23:14 ` Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 0/7] Introduce FOREACH_SAFE macros Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 1/7] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-02-19 14:55 ` Thomas Monjalon
2025-02-21 23:05 ` Stephen Hemminger
2025-02-22 8:46 ` Thomas Monjalon
2025-03-12 23:02 ` Stephen Hemminger
2025-03-13 8:00 ` Morten Brørup
2025-02-14 17:20 ` [PATCH v2 2/7] net/qede: fix use after free Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 3/7] bus/fslmc: " Stephen Hemminger
2025-02-15 11:12 ` Hemant Agrawal
2025-02-14 17:20 ` [PATCH v2 4/7] net/bnxt: " Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 5/7] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 6/7] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-14 17:20 ` [PATCH v2 7/7] raw/ifpga: use EAL version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-02-15 15:44 ` [PATCH v2 0/7] Introduce FOREACH_SAFE macros Morten Brørup
2025-03-12 23:15 ` [PATCH v3 0/9] introduce common " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 1/9] eal: add queue macro extensions from FreeBSD Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 2/9] net/qede: fix use after free Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 3/9] bus/fslmc: " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 4/9] net/bnxt: " Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 5/9] net/iavf: replace local version of TAILQ_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 6/9] vhost: replace open coded TAILQ_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` Stephen Hemminger [this message]
2025-03-12 23:15 ` [PATCH v3 8/9] net/i40e: replace open coded version of LIST_FOREACH_SAFE Stephen Hemminger
2025-03-12 23:15 ` [PATCH v3 9/9] net/ice: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312231715.222149-8-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=rosen.xu@altera.com \
--cc=rosen.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).